delta/gitlab/gitlab-ce.git/app/controllers, branch frozen_string_lib_2 gitlab.com: gitlab-org/gitlab-ce.git Add SortingPreference concern 2019-08-21T10:13:45+00:00 George Koltsov koltsov.george@gmail.com 2019-08-21T10:13:45+00:00 8bcc47ac02e69eb4564238b454ca8286a4126765 Sorting preference functionality has been extracted from `IssuableCollections` to a new `SortingPreference` concern in order to reuse this functionality in projects (and groups in the future). 
Sorting preference functionality has been extracted
from `IssuableCollections` to a new `SortingPreference`
concern in order to reuse this functionality in projects
(and groups in the future).
Merge branch '63372-award-emoji-services' into 'master' 2019-08-21T09:38:40+00:00 Grzegorz Bizon grzegorz@gitlab.com 2019-08-21T09:38:40+00:00 89f6584fb30544dbd27c291c3b62e3f2b0399e63 Add service classes for mutating AwardEmoji Closes #63372 See merge request gitlab-org/gitlab-ce!29782 
Add service classes for mutating AwardEmoji

Closes #63372

See merge request gitlab-org/gitlab-ce!29782
 Add service classes for mutating AwardEmoji 2019-08-20T23:39:41+00:00 Luke Duncalfe lduncalfe@eml.cc 2019-06-18T01:44:43+00:00 37b17fa61a1fb5efe5942ab2cb27b15685bf905e Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372 
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.

This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.

Behaviour changes

- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
  longer mark a relevant Todo as done

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
Renaming AwardedEmojiFinder to a Service 2019-08-20T22:00:00+00:00 Luke Duncalfe lduncalfe@eml.cc 2019-06-18T05:15:53+00:00 330cbddec30840a72a52aade383286e58545ce98 This finder class acts more as a service, as it only returns mapped data. Renaming this class allows us to create a new AwardEmojiFinder without the ambiguity of there being two similarly-named finders. https://gitlab.com/gitlab-org/gitlab-ce/issues/63372 
This finder class acts more as a service, as it only returns mapped
data.

Renaming this class allows us to create a new AwardEmojiFinder without
the ambiguity of there being two similarly-named finders.

https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
New wiki page redirects user to random slug 2019-08-20T21:33:12+00:00 Luke Duncalfe lduncalfe@eml.cc 2019-08-01T05:54:52+00:00 93a618f0e54b5ae28f7525b8861763130c692415 Previously we asked a user to enter a new slug before taking them to the Create Page page. As a UX improvement, we now take them to a randomly generated URI so they can begin creating their new page. https://gitlab.com/gitlab-org/gitlab-ce/issues/46299 
Previously we asked a user to enter a new slug before taking them to
the Create Page page.

As a UX improvement, we now take them to a randomly generated URI so
they can begin creating their new page.

https://gitlab.com/gitlab-org/gitlab-ce/issues/46299
Standardize remote_ip and path keys for auth.log and api_json.log 2019-08-20T18:12:28+00:00 Stan Hu stanhu@gmail.com 2019-08-20T18:12:28+00:00 e632ae80845f849f93e4d85ef9f836a4792844c9 Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses `remote_ip` and `path` for the same fields. Let's standardize these namings to make it easier for people working with the data. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167 
Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses
`remote_ip` and `path` for the same fields. Let's standardize these
namings to make it easier for people working with the data.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
Use ActiveModel's type instead of virtus 2019-08-20T10:52:21+00:00 Peter Leitzen pleitzen@gitlab.com 2019-08-20T10:52:21+00:00 6767326267a649a04a0f6c7634be87577a788a3d The virtus project has been discontinued: https://github.com/solnic/virtus/commit/a6f896984 
The virtus project has been discontinued:

https://github.com/solnic/virtus/commit/a6f896984
Fix N+1s queries while loading users 2019-08-19T20:35:46+00:00 Douglas Barbosa Alexandre dbalexandre@gmail.com 2019-08-19T20:33:07+00:00 2067f677df69200338d8d2b78f239759fc293fee 






Merge branch '66023-starrers-count-do-not-match-after-searching' into 'master'
2019-08-16T20:34:27+00:00

Stan Hu
stanhu@gmail.com

2019-08-16T20:34:27+00:00

2dcb69c90342a5333e5701a1cd704ae738e9433b

Fix starrers counts after searching

See merge request gitlab-org/gitlab-ce!31823




Fix starrers counts after searching

See merge request gitlab-org/gitlab-ce!31823






Merge branch '47003-user-onboarding-replace-current-email-confirmation-flow-with-a-soft-email-confirmation-flow' into 'master'
2019-08-16T12:31:16+00:00

Grzegorz Bizon
grzegorz@gitlab.com

2019-08-16T12:31:16+00:00

b1604f7d8f0095d637036721244830e8d3181596

Soft email confirmation flow

Closes #47003

See merge request gitlab-org/gitlab-ce!31245




Soft email confirmation flow

Closes #47003

See merge request gitlab-org/gitlab-ce!31245