<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers, branch document-lambda-deploy</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Preload routes information</title>
<updated>2019-09-03T10:16:03+00:00</updated>
<author>
<name>Andreas Brandl</name>
<email>abrandl@gitlab.com</email>
</author>
<published>2019-08-27T17:15:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=53801b1206ff9e165b30117e3c3bcf543db7ad2c'/>
<id>53801b1206ff9e165b30117e3c3bcf543db7ad2c</id>
<content type='text'>
This fixes a high frequency N+1 issue:

`RoutableActions#find_routable!` is used across many controllers to
retrieve e.g. the Project or Namespace by path. The `#find_routable!`
method calls `#ensure_canonical_path` which in turn retrieves
`#full_path` from the given Routable.

This in turn triggers a lookup on `routes`, leading to a high frequency
of these queries:

```sql
SELECT  "routes".* FROM "routes" WHERE "routes"."source_id" = $1 AND
"routes"."source_type" = $2 LIMIT $3
```

This is unnecessary as we already join `routes` in
`Routable#find_by_full_path` anyways.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes a high frequency N+1 issue:

`RoutableActions#find_routable!` is used across many controllers to
retrieve e.g. the Project or Namespace by path. The `#find_routable!`
method calls `#ensure_canonical_path` which in turn retrieves
`#full_path` from the given Routable.

This in turn triggers a lookup on `routes`, leading to a high frequency
of these queries:

```sql
SELECT  "routes".* FROM "routes" WHERE "routes"."source_id" = $1 AND
"routes"."source_type" = $2 LIMIT $3
```

This is unnecessary as we already join `routes` in
`Routable#find_by_full_path` anyways.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-peek-on-puma' into 'master'</title>
<updated>2019-09-02T08:43:21+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-09-02T08:43:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b7398bc1fdad6c721cfa35ff17cebc2cb00c8240'/>
<id>b7398bc1fdad6c721cfa35ff17cebc2cb00c8240</id>
<content type='text'>
Fix Peek on Puma

Closes #66528

See merge request gitlab-org/gitlab-ce!32213</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix Peek on Puma

Closes #66528

See merge request gitlab-org/gitlab-ce!32213</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid calling freeze on already frozen strings in app/controllers</title>
<updated>2019-08-31T20:27:25+00:00</updated>
<author>
<name>dineshpanda</name>
<email>dineshpanda92@gmail.com</email>
</author>
<published>2019-08-31T19:21:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=980303b542e95d1caf2a4b54113e63b54dbae494'/>
<id>980303b542e95d1caf2a4b54113e63b54dbae494</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Creates Feature Flag for job log</title>
<updated>2019-08-30T21:51:30+00:00</updated>
<author>
<name>Filipa Lacerda</name>
<email>filipa@gitlab.com</email>
</author>
<published>2019-08-30T21:51:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=288e709cb729124b81344912db0a0f8ce9735a7d'/>
<id>288e709cb729124b81344912db0a0f8ce9735a7d</id>
<content type='text'>
Updates frontend code and specs to allow for the new
feature flag
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Updates frontend code and specs to allow for the new
feature flag
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq</title>
<updated>2019-08-29T22:17:37+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2019-08-29T22:17:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7698d405506bc10dfd7fb2e6e02b419dd5925725'/>
<id>7698d405506bc10dfd7fb2e6e02b419dd5925725</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-epic-notes-api-reveals-historical-info-ce-master' into 'master'</title>
<updated>2019-08-29T21:34:24+00:00</updated>
<author>
<name>GitLab Release Tools Bot</name>
<email>robert+release-tools@gitlab.com</email>
</author>
<published>2019-08-29T21:34:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5a008d136840b5c7fd5688060efa73dd1b5491ab'/>
<id>5a008d136840b5c7fd5688060efa73dd1b5491ab</id>
<content type='text'>
Filter out old system notes for epics in notes api endpoint response

See merge request gitlab/gitlabhq!3224</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Filter out old system notes for epics in notes api endpoint response

See merge request gitlab/gitlabhq!3224</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-personal-snippets' into 'master'</title>
<updated>2019-08-29T21:34:22+00:00</updated>
<author>
<name>GitLab Release Tools Bot</name>
<email>robert+release-tools@gitlab.com</email>
</author>
<published>2019-08-29T21:34:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=34c2b6adf9966ac7ad9a9e699211a6074af13fbc'/>
<id>34c2b6adf9966ac7ad9a9e699211a6074af13fbc</id>
<content type='text'>
Add direct upload support for personal snippets

See merge request gitlab/gitlabhq!3226</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add direct upload support for personal snippets

See merge request gitlab/gitlabhq!3226</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-59549-add-capcha-for-failed-logins' into 'master'</title>
<updated>2019-08-29T21:34:12+00:00</updated>
<author>
<name>GitLab Release Tools Bot</name>
<email>robert+release-tools@gitlab.com</email>
</author>
<published>2019-08-29T21:34:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a5b2a3786056ddf99de06c8315e9a42c3bf86cd5'/>
<id>a5b2a3786056ddf99de06c8315e9a42c3bf86cd5</id>
<content type='text'>
Require a captcha after unique failed logins from the same IP

See merge request gitlab/gitlabhq!3270</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Require a captcha after unique failed logins from the same IP

See merge request gitlab/gitlabhq!3270</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-mr-head-pipeline-leak' into 'master'</title>
<updated>2019-08-29T21:34:10+00:00</updated>
<author>
<name>GitLab Release Tools Bot</name>
<email>robert+release-tools@gitlab.com</email>
</author>
<published>2019-08-29T21:34:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e20fb7cb395e9c6594a098eddd816079259f64d9'/>
<id>e20fb7cb395e9c6594a098eddd816079259f64d9</id>
<content type='text'>
Permission fix for MergeRequestsController#pipeline_status

See merge request gitlab/gitlabhq!3274</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Permission fix for MergeRequestsController#pipeline_status

See merge request gitlab/gitlabhq!3274</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-group-runners-permissions' into 'master'</title>
<updated>2019-08-29T21:33:57+00:00</updated>
<author>
<name>GitLab Release Tools Bot</name>
<email>robert+release-tools@gitlab.com</email>
</author>
<published>2019-08-29T21:33:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=be128484b5f74b25ac9559bc47375d30a803f296'/>
<id>be128484b5f74b25ac9559bc47375d30a803f296</id>
<content type='text'>
admin_group authorization for Groups::RunnersController

See merge request gitlab/gitlabhq!3325</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
admin_group authorization for Groups::RunnersController

See merge request gitlab/gitlabhq!3325</pre>
</div>
</content>
</entry>
</feed>
