<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/users, branch patch-53</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Enable even more frozen string in app/controllers</title>
<updated>2018-09-26T05:43:49+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-09-26T03:45:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12ee2753c1e27c0c9480a8e79db2463ba51ba3ec'/>
<id>12ee2753c1e27c0c9480a8e79db2463ba51ba3ec</id>
<content type='text'>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Users can accept terms during registration</title>
<updated>2018-06-08T17:17:00+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2018-06-08T11:20:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3d713ac114085e091815aa486fb96905347c3002'/>
<id>3d713ac114085e091815aa486fb96905347c3002</id>
<content type='text'>
When a user checks the `accept` checkbox, we will track that
acceptance as usual. That way they don't need to accept again after
they complete the registration.

When an unauthenticated user visits the `/-/users/terms` page, there
is no button to accept, decline or continue. The 'current-user menu'
is also hidden from the top bar.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a user checks the `accept` checkbox, we will track that
acceptance as usual. That way they don't need to accept again after
they complete the registration.

When an unauthenticated user visits the `/-/users/terms` page, there
is no button to accept, decline or continue. The 'current-user menu'
is also hidden from the top bar.
</pre>
</div>
</content>
</entry>
<entry>
<title>Messaging on terms page when user already accepted</title>
<updated>2018-06-04T20:22:11+00:00</updated>
<author>
<name>tauriedavis</name>
<email>taurie@gitlab.com</email>
</author>
<published>2018-05-25T23:17:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=285ffb223896f2226531be2ba10933414194155c'/>
<id>285ffb223896f2226531be2ba10933414194155c</id>
<content type='text'>
We show a blue flash banner if the user already accepted, and show a
button allowing them to continue to the application.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We show a blue flash banner if the user already accepted, and show a
button allowing them to continue to the application.
</pre>
</div>
</content>
</entry>
<entry>
<title>Enforce terms acceptance before other requirements</title>
<updated>2018-05-11T12:27:22+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2018-05-11T07:35:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f25e00bc1e2ece94189cffbc3ffdda6588084cb3'/>
<id>f25e00bc1e2ece94189cffbc3ffdda6588084cb3</id>
<content type='text'>
This prevents a redirect loop when a user has to enable 2FA and accept
the terms.

Now they will need to accept the terms, then enable 2FA, or any other requirements.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This prevents a redirect loop when a user has to enable 2FA and accept
the terms.

Now they will need to accept the terms, then enable 2FA, or any other requirements.
</pre>
</div>
</content>
</entry>
<entry>
<title>Enforces terms in the web application</title>
<updated>2018-05-04T11:54:43+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2018-04-27T14:50:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7684217d6806408cd338260119364419260d1720'/>
<id>7684217d6806408cd338260119364419260d1720</id>
<content type='text'>
This enforces the terms in the web application. These cases are
specced:

- Logging in: When terms are enforced, and a user logs in that has not
  accepted the terms, they are presented with the screen. They get
  directed to their customized root path afterwards.
- Signing up: After signing up, the first screen the user is presented
  with the screen to accept the terms. After they accept they are
  directed to the dashboard.
- While a session is active:
  - For a GET: The user will be directed to the terms page first,
    after they accept the terms, they will be directed to the page
    they were going to
  - For any other request: They are directed to the terms, after they
    accept the terms, they are directed back to the page they came
    from to retry the request. Any information entered would be
    persisted in localstorage and available on the page.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This enforces the terms in the web application. These cases are
specced:

- Logging in: When terms are enforced, and a user logs in that has not
  accepted the terms, they are presented with the screen. They get
  directed to their customized root path afterwards.
- Signing up: After signing up, the first screen the user is presented
  with the screen to accept the terms. After they accept they are
  directed to the dashboard.
- While a session is active:
  - For a GET: The user will be directed to the terms page first,
    after they accept the terms, they will be directed to the page
    they were going to
  - For any other request: They are directed to the terms, after they
    accept the terms, they are directed back to the page they came
    from to retry the request. Any information entered would be
    persisted in localstorage and available on the page.
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow a user to accept/decline terms</title>
<updated>2018-05-04T11:54:43+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2018-04-27T12:56:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=10aa55a770c2985c22c92d17b8a7ea90b0a09085'/>
<id>10aa55a770c2985c22c92d17b8a7ea90b0a09085</id>
<content type='text'>
When a user accepts, we store this in the agreements to keep track of
which terms they accepted. We also update the flag on the user.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a user accepts, we store this in the agreements to keep track of
which terms they accepted. We also update the flag on the user.
</pre>
</div>
</content>
</entry>
<entry>
<title>Display terms to a user</title>
<updated>2018-05-04T11:52:55+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2018-04-26T11:28:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3629dc338fbe6c351ce89a94caa4c238965ee33a'/>
<id>3629dc338fbe6c351ce89a94caa4c238965ee33a</id>
<content type='text'>
When terms are present, they can be viewed on `/-/users/terms`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When terms are present, they can be viewed on `/-/users/terms`.
</pre>
</div>
</content>
</entry>
</feed>
