delta/gitlab/gitlab-ce.git/app/controllers/sessions_controller.rb, branch frozen_string_spec_models gitlab.com: gitlab-org/gitlab-ce.git Rails5: env is deprecated and will be removed from Rails 5.1 2018-11-15T07:12:24+00:00 Jasper Maes jaspermaes.jm@gmail.com 2018-10-26T16:51:22+00:00 616fbd028c05667f7094e38c81c5db3db379cc1e 






Enable frozen string in app/controllers/**/*.rb
2018-09-19T04:22:45+00:00

gfyoung
gfyoung17@gmail.com

2018-09-14T05:42:05+00:00

73322a0e551bbbc42d429b15e7ad9fd375ab761d

Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.





Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.







Disable existing offenses for the CodeReuse cops
2018-09-11T15:32:00+00:00

Yorick Peterse
yorickpeterse@gmail.com

2018-08-27T15:31:01+00:00

2039c8280db1646845c33d6c5a74e5f23ca6f4de

This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.





This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.







Merge branch 'feature/gb/login-activity-metrics' into 'master'
2018-07-31T10:44:22+00:00

Sean McGivern
sean@mcgivern.me.uk

2018-07-31T10:44:22+00:00

e6dd3c527626af1c0f521792360f7c4b29bfee36

Add user authentication activity metrics

Closes #47789

See merge request gitlab-org/gitlab-ce!20668




Add user authentication activity metrics

Closes #47789

See merge request gitlab-org/gitlab-ce!20668






Track blocked users and two factor authentications
2018-07-23T13:13:11+00:00

Grzegorz Bizon
grzesiek.bizon@gmail.com

2018-07-23T13:13:11+00:00

68547bc0e0e3f85e8ac07c6f81c316e1f4456758












Disable SAML if OmniAuth is disabled
2018-07-20T10:54:46+00:00

Lin Jen-Shin
godfat@godfat.org

2018-07-13T10:39:31+00:00

d0afab482f1157d0b41631cb4dbdfdfeadabb7c8

We also try to unify the way we setup OmniAuth, and how we check
if it's enabled or not.





We also try to unify the way we setup OmniAuth, and how we check
if it's enabled or not.







Updates from `rubocop -a`
2018-07-09T13:13:08+00:00

Lin Jen-Shin
godfat@godfat.org

2018-07-02T10:43:06+00:00

4ee08b77bc5ae11553d59c182ea8292b77699115












Add Prometheus metrics to track reCAPTCHA success/failures
2018-07-03T18:39:00+00:00

Stan Hu
stanhu@gmail.com

2018-06-22T06:25:00+00:00

7376ffc3a3f3d0f3bc294c4431370c5560c19a00












Show a reCAPTCHA on signin page if custom header is set
2018-06-21T22:37:34+00:00

Stan Hu
stanhu@gmail.com

2018-06-21T18:13:08+00:00

9b48d9f43f237ccf87594a944a00896996cadf55

This will only be displayed if `X-GitLab-Show-Login-Captcha` is set as an HTTP
header.





This will only be displayed if `X-GitLab-Show-Login-Captcha` is set as an HTTP
header.







Reuses `InternalRedirect` when possible
2018-05-04T11:54:43+00:00

Bob Van Landuyt
bob@vanlanduyt.co

2018-05-02T18:25:21+00:00

39916fdfeddfd75279d13fa976fdb07f3b9b0e26

`InternalRedirect` prevents Open redirect issues by only allowing
redirection to paths on the same host.

It cleans up any unwanted strings from the path that could point to
another host (fe. //about.gitlab.com/hello). While preserving the
querystring and fragment of the uri.

It is already used by:

- `TermsController`
- `ContinueParams`
  - `ImportsController`
  - `ForksController`
- `SessionsController`: Only for verifying the host in CE. EE allows
   redirecting to a different instance using Geo.





`InternalRedirect` prevents Open redirect issues by only allowing
redirection to paths on the same host.

It cleans up any unwanted strings from the path that could point to
another host (fe. //about.gitlab.com/hello). While preserving the
querystring and fragment of the uri.

It is already used by:

- `TermsController`
- `ContinueParams`
  - `ImportsController`
  - `ForksController`
- `SessionsController`: Only for verifying the host in CE. EE allows
   redirecting to a different instance using Geo.