<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/projects/network_controller.rb, branch docs/doc-README</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Remove `options` assignment from ExtractsPath</title>
<updated>2018-11-27T18:07:02+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2018-11-27T18:04:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=df8f0ab52128e173690f624575fef286d1a3cf4c'/>
<id>df8f0ab52128e173690f624575fef286d1a3cf4c</id>
<content type='text'>
This assignment is only used by the Projects::NetworkController, so
we're needlessly assigning this very generically-named instance variable
on every controller which includes `ExtractsPath`, which is quite a few.

Further, the way we were passing this hash to
`HashWithIndifferentAccess` caused the following deprecation warning
after upgrading to Rails 5:

    DEPRECATION WARNING: #to_hash unexpectedly ignores parameter
    filtering, and will change to enforce it in Rails 5.1. Enable
    `raise_on_unfiltered_parameters` to respect parameter filtering,
    which is the default in new applications. For the existing
    deprecated behaviour, call #to_unsafe_h instead. (called from new at
    lib/extracts_path.rb:116)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This assignment is only used by the Projects::NetworkController, so
we're needlessly assigning this very generically-named instance variable
on every controller which includes `ExtractsPath`, which is quite a few.

Further, the way we were passing this hash to
`HashWithIndifferentAccess` caused the following deprecation warning
after upgrading to Rails 5:

    DEPRECATION WARNING: #to_hash unexpectedly ignores parameter
    filtering, and will change to enforce it in Rails 5.1. Enable
    `raise_on_unfiltered_parameters` to respect parameter filtering,
    which is the default in new applications. For the existing
    deprecated behaviour, call #to_unsafe_h instead. (called from new at
    lib/extracts_path.rb:116)
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable even more frozen string in app/controllers</title>
<updated>2018-09-26T05:43:49+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-09-26T03:45:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12ee2753c1e27c0c9480a8e79db2463ba51ba3ec'/>
<id>12ee2753c1e27c0c9480a8e79db2463ba51ba3ec</id>
<content type='text'>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Gitaly n+1 in NetworkController#show</title>
<updated>2018-03-06T13:32:48+00:00</updated>
<author>
<name>Andrew Newdigate</name>
<email>andrew@gitlab.com</email>
</author>
<published>2018-03-06T13:32:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b5ec6097b75819626083726d1073978d11aba7e3'/>
<id>b5ec6097b75819626083726d1073978d11aba7e3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Track and act upon the number of executed queries</title>
<updated>2018-02-01T16:00:46+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-01-15T15:21:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cca61980d5ad9c4db65b9498fe49d936657bc0e2'/>
<id>cca61980d5ad9c4db65b9498fe49d936657bc0e2</id>
<content type='text'>
This ensures that we have more visibility in the number of SQL queries
that are executed in web requests. The current threshold is hardcoded to
100 as we will rarely (maybe once or twice) change it.

In production and development we use Sentry if enabled, in the test
environment we raise an error. This feature is also only enabled in
production/staging when running on GitLab.com as it's not very useful to
other users.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This ensures that we have more visibility in the number of SQL queries
that are executed in web requests. The current threshold is hardcoded to
100 as we will rarely (maybe once or twice) change it.

In production and development we use Sentry if enabled, in the test
environment we raise an error. This feature is also only enabled in
production/staging when running on GitLab.com as it's not very useful to
other users.
</pre>
</div>
</content>
</entry>
<entry>
<title>Detect n+1 issues involving Gitaly</title>
<updated>2017-09-19T10:55:37+00:00</updated>
<author>
<name>Andrew Newdigate</name>
<email>andrew@gitlab.com</email>
</author>
<published>2017-09-19T10:55:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=64d7ec0a9e3ffd6233ccfbe9100f8a9391c648e5'/>
<id>64d7ec0a9e3ffd6233ccfbe9100f8a9391c648e5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Create and use project path helpers that only need a project, no namespace</title>
<updated>2017-07-05T16:11:59+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-06-29T17:06:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fe13f110412d85c05dc68e5ee1db499f681bf722'/>
<id>fe13f110412d85c05dc68e5ee1db499f681bf722</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor method name</title>
<updated>2016-11-07T20:12:17+00:00</updated>
<author>
<name>Hiroyuki Sato</name>
<email>h-sato@ruby-dev.jp</email>
</author>
<published>2016-11-07T20:12:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5569573a24efca76abede20370988a81d623e6a5'/>
<id>5569573a24efca76abede20370988a81d623e6a5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix bug of json request url</title>
<updated>2016-11-07T11:44:15+00:00</updated>
<author>
<name>Hiroyuki Sato</name>
<email>h-sato@ruby-dev.jp</email>
</author>
<published>2016-11-07T11:44:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=95a78fb53bbddfa10db7da3b12406332a7fafacc'/>
<id>95a78fb53bbddfa10db7da3b12406332a7fafacc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove 'extended_sha1' option from ExtractsPath module</title>
<updated>2016-11-06T03:33:39+00:00</updated>
<author>
<name>Hiroyuki Sato</name>
<email>h-sato@ruby-dev.jp</email>
</author>
<published>2016-11-06T03:33:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d8cc8d7adc4c50843ecacc77a30b2e6db4e3fd84'/>
<id>d8cc8d7adc4c50843ecacc77a30b2e6db4e3fd84</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Separete a very long line</title>
<updated>2016-11-06T03:05:13+00:00</updated>
<author>
<name>Hiroyuki Sato</name>
<email>h-sato@ruby-dev.jp</email>
</author>
<published>2016-10-28T12:48:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ee7374a9fb16ca65603ef095de2856694612d68f'/>
<id>ee7374a9fb16ca65603ef095de2856694612d68f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
