<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/projects/hooks_controller.rb, branch mr-diff-data</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Enable even more frozen string in app/controllers</title>
<updated>2018-09-26T05:43:49+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-09-26T03:45:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12ee2753c1e27c0c9480a8e79db2463ba51ba3ec'/>
<id>12ee2753c1e27c0c9480a8e79db2463ba51ba3ec</id>
<content type='text'>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Filter project hooks by branch</title>
<updated>2018-08-13T11:20:58+00:00</updated>
<author>
<name>Duana Saskia</name>
<email>starkcoffee@users.noreply.github.com</email>
</author>
<published>2018-06-07T07:35:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ece6a1ea6ecffdbde5ff7d663f1ad1eb74f78aa6'/>
<id>ece6a1ea6ecffdbde5ff7d663f1ad1eb74f78aa6</id>
<content type='text'>
Allow specificying a branch filter for a project hook and only trigger
a project hook if either the branch filter is blank or the branch matches.
Only supported for push_events for now.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Allow specificying a branch filter for a project hook and only trigger
a project hook if either the branch filter is blank or the branch matches.
Only supported for push_events for now.
</pre>
</div>
</content>
</entry>
<entry>
<title>Updates from `rubocop -a`</title>
<updated>2018-07-09T13:13:08+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2018-07-02T10:43:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ee08b77bc5ae11553d59c182ea8292b77699115'/>
<id>4ee08b77bc5ae11553d59c182ea8292b77699115</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed pagination of web hook logs</title>
<updated>2018-07-03T12:24:17+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-06-28T13:34:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f30089075fabfbac45c6382c0a2717bbb682734e'/>
<id>f30089075fabfbac45c6382c0a2717bbb682734e</id>
<content type='text'>
For reasons unknown, the logs of a web hook were paginated in memory.
This would result in the "Edit" page of a web hook timing out once it
has more than a few thousand log entries.

This commit makes the following changes:

1. We use LIMIT/OFFSET to paginate the data, instead of doing this in
   memory.

2. We limit the logs to the last two days, just like the documentation
   says (instead of retrieving everything).

3. We change the indexes on "web_hook_logs" so the query to get the data
   can perform a backwards index scan, without the need for a Filter.

These changes combined ensure that Projects::HooksController#edit no
longer times out.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For reasons unknown, the logs of a web hook were paginated in memory.
This would result in the "Edit" page of a web hook timing out once it
has more than a few thousand log entries.

This commit makes the following changes:

1. We use LIMIT/OFFSET to paginate the data, instead of doing this in
   memory.

2. We limit the logs to the last two days, just like the documentation
   says (instead of retrieving everything).

3. We change the indexes on "web_hook_logs" so the query to get the data
   can perform a backwards index scan, without the need for a Filter.

These changes combined ensure that Projects::HooksController#edit no
longer times out.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'feature/merge-request-system-hook' into 'master'</title>
<updated>2018-01-18T11:37:16+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2018-01-18T11:37:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8e9c073a146f655cea2fd13f259bd68dc2c37259'/>
<id>8e9c073a146f655cea2fd13f259bd68dc2c37259</id>
<content type='text'>
System hooks for Merge Requests

See merge request gitlab-org/gitlab-ce!14387</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
System hooks for Merge Requests

See merge request gitlab-org/gitlab-ce!14387</pre>
</div>
</content>
</entry>
<entry>
<title>reference triggers.values for permitted parameters</title>
<updated>2018-01-17T08:55:00+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2017-12-18T10:14:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=337ced28bcdff25a2d2d4c726d37c782c4cc2d24'/>
<id>337ced28bcdff25a2d2d4c726d37c782c4cc2d24</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Adds Rubocop rule for line break around conditionals</title>
<updated>2018-01-11T16:34:01+00:00</updated>
<author>
<name>🙈  jacopo beschi 🙉</name>
<email>intrip@gmail.com</email>
</author>
<published>2018-01-11T16:34:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=729f05f0e3c4835c91e20ccd1ddb630eb7ef4379'/>
<id>729f05f0e3c4835c91e20ccd1ddb630eb7ef4379</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Wrong data type when testing webhooks</title>
<updated>2017-07-20T15:12:06+00:00</updated>
<author>
<name>Alexander Randa</name>
<email>randa.alex@gmail.com</email>
</author>
<published>2017-07-20T15:12:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e0ab5618a0998175df9f90c95ebd35d7afa01db7'/>
<id>e0ab5618a0998175df9f90c95ebd35d7afa01db7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Create and use project path helpers that only need a project, no namespace</title>
<updated>2017-07-05T16:11:59+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-06-29T17:06:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fe13f110412d85c05dc68e5ee1db499f681bf722'/>
<id>fe13f110412d85c05dc68e5ee1db499f681bf722</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers</title>
<updated>2017-06-06T22:45:16+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2017-06-06T22:45:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a544e46bb083c27bfa2966ea67ddf97b5dc7cb08'/>
<id>a544e46bb083c27bfa2966ea67ddf97b5dc7cb08</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
