delta/gitlab/gitlab-ce.git/app/controllers/projects/discussions_controller.rb, branch update-csslab-version

Resolve "Projects::MergeRequestsController#show is slow (implement skeleton loading)"

2018-03-13T12:01:36+00:00

Render MR Notes with Vue with behind a cookie

2018-02-28T00:10:43+00:00

Use the new check_project_feature_available! method in project controllers

2017-06-21T09:56:45+00:00

Add option to start a new discussion on an MR

2017-04-05T16:44:14+00:00

Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'

2016-12-09T00:42:07+00:00

Replace MR access checks with use of MergeRequestsFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :bomb:  app/finders/notes_finder.rb:17
- [x] :warning:  app/views/layouts/nav/_project.html.haml:80 [`.count`]
- [x] :bomb:  app/controllers/concerns/creates_commit.rb:84
- [x] :traffic_light:  app/controllers/projects/commits_controller.rb:24
- [x] :traffic_light:  app/controllers/projects/compare_controller.rb:56
- [x] :vertical_traffic_light:  app/controllers/projects/discussions_controller.rb:29
- [x] :white_check_mark:  app/controllers/projects/todos_controller.rb:27
- [x] :vertical_traffic_light:  app/models/commit.rb:268
- [x] :white_check_mark: lib/gitlab/search_results.rb:71

- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)`
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`.
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use  of unchecked `merged_merge_request?`

See merge request !2033

Feature: delegate all open discussions to Issue

2016-12-05T19:55:45+00:00

When a merge request can only be merged when all discussions are
resolved. This feature allows to easily delegate those discussions to a
new issue, while marking them as resolved in the merge request.

The user is presented with a new issue, prepared with mentions of all
unresolved discussions, including the first unresolved note of the
discussion, time and link to the note.

When the issue is created, the discussions in the merge request will get
a system note directing the user to the newly created issue.

Project tools visibility level

2016-09-01T14:47:59+00:00

Store discussion_id on Note for faster discussion lookup.

2016-08-17T17:16:46+00:00

Address review feedback

2016-08-16T16:04:26+00:00

Add specs for NotesController and DiscussionsController

2016-08-12T21:24:09+00:00