delta/gitlab/gitlab-ce.git/app/controllers/projects/cycle_analytics_controller.rb, branch docs/api-nil

refactor cycle analytics - updated based on MR feedback

2017-01-17T10:32:55+00:00

Fix other spec failures

2017-01-17T10:32:55+00:00

more refactoring and fixing old specs

2017-01-17T10:32:54+00:00

added new summary serializers and refactor all of the summary stuff into separate logical classes

2017-01-17T10:32:54+00:00

Merge branch 'jej-fix-missing-access-check-on-issues' into 'security'

2016-11-29T00:25:46+00:00

Fix missing access checks on issue lookup using IssuableFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :white_check_mark: app/controllers/projects/branches_controller.rb:39
  - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with
    confidential issues, issues only visible to team, etc.
- [x] :traffic_light: app/models/cycle_analytics/summary.rb:9 [`.count`]
- [x] :white_check_mark: app/controllers/projects/todos_controller.rb:19

- [x] Potential double render in app/controllers/projects/todos_controller.rb

- https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24

See merge request !2030

Use stage description form endpoint response

2016-11-21T18:57:10+00:00

Provide stage legend on server response

2016-11-21T18:57:09+00:00

Updated code based on feedback

2016-11-21T16:29:07+00:00

rename method

2016-11-21T16:19:18+00:00

Adds a flag to reflect whether or not there is data in cycle analytics

2016-11-21T16:19:18+00:00