delta/gitlab/gitlab-ce.git/app/controllers/projects/commits_controller.rb, branch git-user-encoding gitlab.com: gitlab-org/gitlab-ce.git Optimise getting the pipeline status of commits 2017-11-16T15:01:14+00:00 Yorick Peterse yorickpeterse@gmail.com 2017-11-10T19:57:11+00:00 ab16a6fb34c0f3e4d9afed3332c559868201e606 This adds an optimised way of getting the latest pipeline status for a list of Commit objects (or just a single one). 
This adds an optimised way of getting the latest pipeline status for a
list of Commit objects (or just a single one).
Use Commit#notes and Note.for_commit_id when possible to make sure we use all the indexes available to us 2017-11-08T11:22:11+00:00 Douwe Maan douwe@selenight.nl 2017-11-07T16:11:37+00:00 fec48c6e170fb0032cece5d8cc3b06bb45caee57 






Renders 404 in commits controller if no commits are found
2017-10-19T01:41:00+00:00

Guilherme Vieira
guilherme@flipstudio.net

2017-10-01T14:54:12+00:00

ada114065f332bb7d4add3156dd177eaf6662aaa












Adds cacheless render to Banzai object render
2017-09-06T14:35:35+00:00

Tiago Botelho
tiagonbotelho@hotmail.com

2017-08-23T16:53:29+00:00

6d8e102c740b75ac9e1d168a84f532f6d9ebaa65












fetch gpg signature badges by ajax
2017-07-27T13:46:03+00:00

Alexis Reigel
mail@koffeinfrei.org

2017-07-25T07:40:23+00:00

eda001565c5afbf6e2eb9b8b5cf4fa9d6525ed71












Enable Style/DotPosition Rubocop :cop:
2017-06-21T13:48:12+00:00

Grzegorz Bizon
grzegorz@gitlab.com

2017-06-21T13:48:12+00:00

0430b7644101fc70ed4be6bf69ccf05b900f4cdf












Refactor atom builder by using xml.atom layout
2017-06-12T17:21:13+00:00

Tieu-Philippe KHIM
khim.tieu.philippe@gmail.com

2017-06-12T17:21:13+00:00

3c1700cde65ef8a410c2c2a9f44727613d3ef9ff












Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'
2016-12-09T00:42:07+00:00

Douwe Maan
douwe@gitlab.com

2016-11-29T13:47:43+00:00

f23b1cb453deea2659c0cb9e9047c72d859bbf9d

Replace MR access checks with use of MergeRequestsFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :bomb:  app/finders/notes_finder.rb:17
- [x] :warning:  app/views/layouts/nav/_project.html.haml:80 [`.count`]
- [x] :bomb:  app/controllers/concerns/creates_commit.rb:84
- [x] :traffic_light:  app/controllers/projects/commits_controller.rb:24
- [x] :traffic_light:  app/controllers/projects/compare_controller.rb:56
- [x] :vertical_traffic_light:  app/controllers/projects/discussions_controller.rb:29
- [x] :white_check_mark:  app/controllers/projects/todos_controller.rb:27
- [x] :vertical_traffic_light:  app/models/commit.rb:268
- [x] :white_check_mark: lib/gitlab/search_results.rb:71

- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)`
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`.
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use  of unchecked `merged_merge_request?`

See merge request !2033





Replace MR access checks with use of MergeRequestsFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :bomb:  app/finders/notes_finder.rb:17
- [x] :warning:  app/views/layouts/nav/_project.html.haml:80 [`.count`]
- [x] :bomb:  app/controllers/concerns/creates_commit.rb:84
- [x] :traffic_light:  app/controllers/projects/commits_controller.rb:24
- [x] :traffic_light:  app/controllers/projects/compare_controller.rb:56
- [x] :vertical_traffic_light:  app/controllers/projects/discussions_controller.rb:29
- [x] :white_check_mark:  app/controllers/projects/todos_controller.rb:27
- [x] :vertical_traffic_light:  app/models/commit.rb:268
- [x] :white_check_mark: lib/gitlab/search_results.rb:71

- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)`
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`.
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use  of unchecked `merged_merge_request?`

See merge request !2033







Pass `@ref` along so we know which pipeline to show
2016-10-24T14:26:06+00:00

Lin Jen-Shin
godfat@godfat.org

2016-10-21T08:22:43+00:00

5416d0e0837f69f35a3a9deaf947fd62e5293661

Closes #23615





Closes #23615







Refactoring find_commits functionality
2016-10-20T09:45:34+00:00

Valery Sizov
valery@gitlab.com

2016-10-19T16:43:04+00:00

fd2c3a3da0302a474d7c1adbd409aedea2a41053