<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/projects/commits_controller.rb, branch docs/remove-cephfs-example</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Expand FindCommit caching to blob and refs</title>
<updated>2019-04-06T12:16:22+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-04-06T12:04:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0d8e9f6ee3a49e00b7831b88486b1cbda83026cb'/>
<id>0d8e9f6ee3a49e00b7831b88486b1cbda83026cb</id>
<content type='text'>
This enables FindCommit caching to the following actions:

* BlobController#show
* RefsController#logs_tree

It also improves caching in CommitsController since some
duplicate requests were occuring inside the before_action
definitions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This enables FindCommit caching to the following actions:

* BlobController#show
* RefsController#logs_tree

It also improves caching in CommitsController since some
duplicate requests were occuring inside the before_action
definitions.
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable FindCommit caching for project and commits pages</title>
<updated>2019-04-05T11:52:42+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-04-05T11:33:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f1dce2160956f27fecc4a59d36d1e1e03903a84b'/>
<id>f1dce2160956f27fecc4a59d36d1e1e03903a84b</id>
<content type='text'>
This reduces a handful of duplicate FindCommit calls while viewing the
projects and commits pages.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reduces a handful of duplicate FindCommit calls while viewing the
projects and commits pages.
</pre>
</div>
</content>
</entry>
<entry>
<title>Check for valid refs in CommitController before doing anything</title>
<updated>2018-12-10T05:56:31+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-12-10T05:23:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=384a92b7362ad75801add04292f6ef7938207fc4'/>
<id>384a92b7362ad75801add04292f6ef7938207fc4</id>
<content type='text'>
Before a 404 would be rendered only after a request to Gitaly would
return with an InvalidArgument error. Now we check that the ref have a
valid format before sending it to Gitaly. In both cases, a 404 is
returned to the user, but this change prevents Gitaly from generating
error noise in production.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1425
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before a 404 would be rendered only after a request to Gitaly would
return with an InvalidArgument error. Now we check that the ref have a
valid format before sending it to Gitaly. In both cases, a 404 is
returned to the user, but this change prevents Gitaly from generating
error noise in production.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1425
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "[Rails5] Set request.format in commits_controller"</title>
<updated>2018-12-03T11:29:01+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2018-11-30T11:55:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=19ad2a4987c3ce8d15b9f778333701597252855f'/>
<id>19ad2a4987c3ce8d15b9f778333701597252855f</id>
<content type='text'>
This reverts commit 6da19415531e4c40f48df2c604efe51578cea295.

# Conflicts:
#	app/controllers/projects/commits_controller.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit 6da19415531e4c40f48df2c604efe51578cea295.

# Conflicts:
#	app/controllers/projects/commits_controller.rb
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-fix-pat-web-access' into 'master'</title>
<updated>2018-11-29T00:13:59+00:00</updated>
<author>
<name>Cindy Pallares</name>
<email>cindy@gitlab.com</email>
</author>
<published>2018-11-28T19:06:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fe5f75930e781ef854b458fafa307ebb90a8ed2e'/>
<id>fe5f75930e781ef854b458fafa307ebb90a8ed2e</id>
<content type='text'>
[master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request"

See merge request gitlab/gitlabhq!2583</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
[master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request"

See merge request gitlab/gitlabhq!2583</pre>
</div>
</content>
</entry>
<entry>
<title>Enable even more frozen string in app/controllers</title>
<updated>2018-09-26T05:43:49+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-09-26T03:45:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12ee2753c1e27c0c9480a8e79db2463ba51ba3ec'/>
<id>12ee2753c1e27c0c9480a8e79db2463ba51ba3ec</id>
<content type='text'>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Disable existing offenses for the CodeReuse cops</title>
<updated>2018-09-11T15:32:00+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-08-27T15:31:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2039c8280db1646845c33d6c5a74e5f23ca6f4de'/>
<id>2039c8280db1646845c33d6c5a74e5f23ca6f4de</id>
<content type='text'>
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
</pre>
</div>
</content>
</entry>
<entry>
<title>Speed up diff comparisons by limiting number of commit messages rendered</title>
<updated>2018-08-22T13:28:31+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-08-21T17:47:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5138d659b5b16ebeadf37165bc461c5906f53e8e'/>
<id>5138d659b5b16ebeadf37165bc461c5906f53e8e</id>
<content type='text'>
When a diff has a significant number of commits, the previous behavior would
attempt to render the Markdown on all the commit messages but only display
1000 of them. To avoid additional work, we only need to render the Markdown
on the set that is displayed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a diff has a significant number of commits, the previous behavior would
attempt to render the Markdown on all the commit messages but only display
1000 of them. To avoid additional work, we only need to render the Markdown
on the set that is displayed.
</pre>
</div>
</content>
</entry>
<entry>
<title>Transfer to commits_controller, add test, and update changelog</title>
<updated>2018-07-24T00:04:16+00:00</updated>
<author>
<name>Kia Mei Somabes</name>
<email>kssomabes@up.edu.ph</email>
</author>
<published>2018-07-24T00:04:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c03bc268be7769ceeb9d1738d6b887a7c866e2a0'/>
<id>c03bc268be7769ceeb9d1738d6b887a7c866e2a0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[Rails5] Set request.format in commits_controller</title>
<updated>2018-06-20T10:42:52+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2018-06-20T10:42:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6da19415531e4c40f48df2c604efe51578cea295'/>
<id>6da19415531e4c40f48df2c604efe51578cea295</id>
<content type='text'>
Since Rails 5.0 `request.format` is being set depending on the route extension.

In commits pages we pass a ref as a URL parameter.
If the ref is an extension-like, Rails converts it and sets to
`request.format`.

E.g. if the ref is `some_branch.atom`, Rails starts responding with
`atom` format, but it should response with `html` because `.atom` is the
part of ref name, not the format.

This commit explicitly sets `request.format` to `:html` when needed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since Rails 5.0 `request.format` is being set depending on the route extension.

In commits pages we pass a ref as a URL parameter.
If the ref is an extension-like, Rails converts it and sets to
`request.format`.

E.g. if the ref is `some_branch.atom`, Rails starts responding with
`atom` format, but it should response with `html` because `.atom` is the
part of ref name, not the format.

This commit explicitly sets `request.format` to `:html` when needed.
</pre>
</div>
</content>
</entry>
</feed>
