<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/projects/artifacts_controller.rb, branch patch-61</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Remove get_build method for find_by_id</title>
<updated>2019-01-09T15:33:22+00:00</updated>
<author>
<name>Steve Azzopardi</name>
<email>steveazz@outlook.com</email>
</author>
<published>2019-01-09T15:33:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ab6b9a1c4350bbaf8b907efb28fbe456e4fe09d5'/>
<id>ab6b9a1c4350bbaf8b907efb28fbe456e4fe09d5</id>
<content type='text'>
The original intention of `get_build` was as a workaround not to violate
`CodeReuse/ActiveRecord`. `find_by_id` does the exact same thing but
does not violate the rubocop rule.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The original intention of `get_build` was as a workaround not to violate
`CodeReuse/ActiveRecord`. `find_by_id` does the exact same thing but
does not violate the rubocop rule.
</pre>
</div>
</content>
</entry>
<entry>
<title>Create `get_build` for project model</title>
<updated>2019-01-07T16:29:26+00:00</updated>
<author>
<name>Steve Azzopardi</name>
<email>steveazz@outlook.com</email>
</author>
<published>2018-12-06T10:55:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f9c8822afdddcd83434432dc2c36b87cc1886602'/>
<id>f9c8822afdddcd83434432dc2c36b87cc1886602</id>
<content type='text'>
Inside of `Projects::ArtifactsController` and
`Projects::BuildArtifactsController` we fetching the build by id using
active record directly which violates `CodeReuse/ActiveRecord` rubocop
rule. Create `get_build` inside of `project` model which does the same
thing.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Inside of `Projects::ArtifactsController` and
`Projects::BuildArtifactsController` we fetching the build by id using
active record directly which violates `CodeReuse/ActiveRecord` rubocop
rule. Create `get_build` inside of `project` model which does the same
thing.
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor project.latest_successful_builds_for def</title>
<updated>2019-01-07T16:29:26+00:00</updated>
<author>
<name>Steve Azzopardi</name>
<email>steveazz@outlook.com</email>
</author>
<published>2018-12-06T10:25:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7ac32ae282fa2d35a3651de08f35aad1b85ffca0'/>
<id>7ac32ae282fa2d35a3651de08f35aad1b85ffca0</id>
<content type='text'>
`project.latest_successful_builds_for(ref)` is being used to find a
single job all the time. This results into us having to call `find_by`
inside of the controller which violates our CodeReuse/ActiveRecord
rubocop rule.

Refactor `project.latest_successful_builds_for(ref)` to
`project.latest_successful_build_for(job_name, ref)` which will execute
the `find_by` inside of the model.

Also create `project.latest_successful_build_for!(job_name, ref)` which
raises an exception instead of returning nil.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`project.latest_successful_builds_for(ref)` is being used to find a
single job all the time. This results into us having to call `find_by`
inside of the controller which violates our CodeReuse/ActiveRecord
rubocop rule.

Refactor `project.latest_successful_builds_for(ref)` to
`project.latest_successful_build_for(job_name, ref)` which will execute
the `find_by` inside of the model.

Also create `project.latest_successful_build_for!(job_name, ref)` which
raises an exception instead of returning nil.
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "[Rails5] Set request.format for artifacts_controller"</title>
<updated>2018-12-03T11:29:01+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2018-11-30T11:54:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=16f7243fefff4a65cee777e5d2b00800872ab6a4'/>
<id>16f7243fefff4a65cee777e5d2b00800872ab6a4</id>
<content type='text'>
This reverts commit c48e7dc2633f8ee8f38150b050938f43e75bd207.

# Conflicts:
#	app/controllers/projects/artifacts_controller.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit c48e7dc2633f8ee8f38150b050938f43e75bd207.

# Conflicts:
#	app/controllers/projects/artifacts_controller.rb
</pre>
</div>
</content>
</entry>
<entry>
<title>backport: Always proxy reports downloads</title>
<updated>2018-11-07T20:49:45+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-11-07T15:54:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5da2f42dc9609c07fd60d9d1c7a2302353a820c0'/>
<id>5da2f42dc9609c07fd60d9d1c7a2302353a820c0</id>
<content type='text'>
This makes to always proxy reports
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes to always proxy reports
</pre>
</div>
</content>
</entry>
<entry>
<title>Disable artifact validation for download action</title>
<updated>2018-10-16T13:01:48+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-10-16T13:01:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=22d1ec661d478b46e4e667316303803973f8d5fb'/>
<id>22d1ec661d478b46e4e667316303803973f8d5fb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>CE Resolve "Refactor code quality similar to JUnit tests"</title>
<updated>2018-10-02T17:01:26+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-10-02T17:01:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=48c911b75e96563991387dc1c7b3aaa071d511cc'/>
<id>48c911b75e96563991387dc1c7b3aaa071d511cc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable even more frozen string in app/controllers</title>
<updated>2018-09-26T05:43:49+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-09-26T03:45:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12ee2753c1e27c0c9480a8e79db2463ba51ba3ec'/>
<id>12ee2753c1e27c0c9480a8e79db2463ba51ba3ec</id>
<content type='text'>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Disable existing offenses for the CodeReuse cops</title>
<updated>2018-09-11T15:32:00+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-08-27T15:31:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2039c8280db1646845c33d6c5a74e5f23ca6f4de'/>
<id>2039c8280db1646845c33d6c5a74e5f23ca6f4de</id>
<content type='text'>
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
</pre>
</div>
</content>
</entry>
<entry>
<title>[Rails5] Set request.format for artifacts_controller</title>
<updated>2018-06-16T10:46:31+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2018-06-16T10:46:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c48e7dc2633f8ee8f38150b050938f43e75bd207'/>
<id>c48e7dc2633f8ee8f38150b050938f43e75bd207</id>
<content type='text'>
Since Rails 5 request.format gets set by extension if it's not explicitly
set.
That means artifacts_controller#file no longer works as expected.
This commit explicitly sets request.format for artifacts_controller#file.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since Rails 5 request.format gets set by extension if it's not explicitly
set.
That means artifacts_controller#file no longer works as expected.
This commit explicitly sets request.format for artifacts_controller#file.
</pre>
</div>
</content>
</entry>
</feed>
