<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/metrics_controller.rb, branch frozen_string_spec_support</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix deprecation: render :text is deprecated because it does not actually render a text/plain response</title>
<updated>2018-11-29T07:05:13+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2018-11-28T18:08:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1bb4ad9262efde3b7aefddf849480a102763a68f'/>
<id>1bb4ad9262efde3b7aefddf849480a102763a68f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable frozen string in app/controllers/**/*.rb</title>
<updated>2018-09-19T04:22:45+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-09-14T05:42:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=73322a0e551bbbc42d429b15e7ad9fd375ab761d'/>
<id>73322a0e551bbbc42d429b15e7ad9fd375ab761d</id>
<content type='text'>
Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>[Rails5] Force the `protect_from_forgery` callback run first</title>
<updated>2018-06-21T10:44:31+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2018-06-21T10:44:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6fef87f17fa6fde7c15668faa43b563eebc0a918'/>
<id>6fef87f17fa6fde7c15668faa43b563eebc0a918</id>
<content type='text'>
Since Rails 5.0 the `protect_from_forgery` callback doesn't run first by
default anymore. [1]

Instead it gets inserted into callbacks chain where callbacks get
called in order.

This commit forces the callback to run first.

[1]: https://github.com/rails/rails/commit/39794037817703575c35a75f1961b01b83791191
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since Rails 5.0 the `protect_from_forgery` callback doesn't run first by
default anymore. [1]

Instead it gets inserted into callbacks chain where callbacks get
called in order.

This commit forces the callback to run first.

[1]: https://github.com/rails/rails/commit/39794037817703575c35a75f1961b01b83791191
</pre>
</div>
</content>
</entry>
<entry>
<title>Adds Rubocop rule for line break around conditionals</title>
<updated>2018-01-11T16:34:01+00:00</updated>
<author>
<name>🙈  jacopo beschi 🙉</name>
<email>intrip@gmail.com</email>
</author>
<published>2018-01-11T16:34:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=729f05f0e3c4835c91e20ccd1ddb630eb7ef4379'/>
<id>729f05f0e3c4835c91e20ccd1ddb630eb7ef4379</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Make Prometheus metrics endpoint return empty response when metrics are disabled</title>
<updated>2017-09-25T21:38:34+00:00</updated>
<author>
<name>Pawel Chojnacki</name>
<email>pawel@chojnacki.ws</email>
</author>
<published>2017-09-25T21:38:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1ea2a85cbe61222765dc3ef50e8c0e4c1b2f5bfa'/>
<id>1ea2a85cbe61222765dc3ef50e8c0e4c1b2f5bfa</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove the need to use health check token</title>
<updated>2017-07-04T22:46:11+00:00</updated>
<author>
<name>Pawel Chojnacki</name>
<email>pawel@chojnacki.ws</email>
</author>
<published>2017-07-03T15:09:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=18521584bd6cfc8de9511722696e87aef59795c5'/>
<id>18521584bd6cfc8de9511722696e87aef59795c5</id>
<content type='text'>
in favor of whitelist that will be used to
control the access to monitoring resources
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
in favor of whitelist that will be used to
control the access to monitoring resources
</pre>
</div>
</content>
</entry>
<entry>
<title>Move Prometheus presentation logic to PrometheusText</title>
<updated>2017-06-02T17:45:58+00:00</updated>
<author>
<name>Pawel Chojnacki</name>
<email>pawel@chojnacki.ws</email>
</author>
<published>2017-05-29T12:19:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c134a72cdb7e6de8b70dc60de99cf4edc68a9227'/>
<id>c134a72cdb7e6de8b70dc60de99cf4edc68a9227</id>
<content type='text'>
+ Use NullMetrics to mock metrics when unused
+ Use method_missing in NullMetrics mocking
+ Update prometheus gem to version that correctly uses transitive dependencies
+ Ensure correct folders are used in Multiprocess prometheus client tests.
+ rename Sessions controller's metric
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
+ Use NullMetrics to mock metrics when unused
+ Use method_missing in NullMetrics mocking
+ Update prometheus gem to version that correctly uses transitive dependencies
+ Ensure correct folders are used in Multiprocess prometheus client tests.
+ rename Sessions controller's metric
</pre>
</div>
</content>
</entry>
<entry>
<title>Make login_counter instance variable instead of class one.</title>
<updated>2017-06-02T17:45:58+00:00</updated>
<author>
<name>Pawel Chojnacki</name>
<email>pawel@chojnacki.ws</email>
</author>
<published>2017-05-23T14:23:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=770f07cd5c68075bb261f4b6139c92b2ac9309c0'/>
<id>770f07cd5c68075bb261f4b6139c92b2ac9309c0</id>
<content type='text'>
 + remove unecessarey require
 + fix small formatiing issues
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 + remove unecessarey require
 + fix small formatiing issues
</pre>
</div>
</content>
</entry>
<entry>
<title>Move most of MetricsController logic to MetricsService</title>
<updated>2017-06-02T17:45:58+00:00</updated>
<author>
<name>Pawel Chojnacki</name>
<email>pawel@chojnacki.ws</email>
</author>
<published>2017-05-23T13:42:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=254830c1f963f344585a45d96a03985e1ec2df0e'/>
<id>254830c1f963f344585a45d96a03985e1ec2df0e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use interpolation instead of concatenation</title>
<updated>2017-06-02T17:45:58+00:00</updated>
<author>
<name>Pawel Chojnacki</name>
<email>pawel@chojnacki.ws</email>
</author>
<published>2017-05-23T13:18:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=466beeb31f9ede870f1e6f4e85642a375663eaf2'/>
<id>466beeb31f9ede870f1e6f4e85642a375663eaf2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
