delta/gitlab/gitlab-ce.git/app/controllers/dashboard, branch remove-admin-runner-projects gitlab.com: gitlab-org/gitlab-ce.git Merge branch 'meinac/gitlab-ce-change_deprecated_render_usage' 2016-05-18T17:48:23+00:00 Dmitriy Zaporozhets dmitriy.zaporozhets@gmail.com 2016-05-18T17:48:23+00:00 253a017b0173ae12d83dc4c6976f1b0a838448a6 Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Merge branch '17249-starred' into 'master' 2016-05-11T12:49:29+00:00 Robert Speicher robert@gitlab.com 2016-05-11T12:49:29+00:00 24f353edc4e90a7846bb6706f6b89e1bb6db7469 Restrict starred projects to viewable ones `User#starred_projects` doesn't perform any visibility checks. This has a couple of problems: 1. It assumes a user can always view all of their starred projects in perpetuity (project not changed to private, access revoked, etc.). 2. It assumes that we'll only ever allow a user to star a project they can view. This is currently the case, but bugs happen. Add `User#viewable_starred_projects` to filter the starred projects by those the user either has explicit access to, or are public or internal. Then use that in all places where we list the user's starred projects. Closes #17249. See merge request !4108 

Restrict starred projects to viewable ones

`User#starred_projects` doesn't perform any visibility checks. This has
a couple of problems:

1. It assumes a user can always view all of their starred projects in
   perpetuity (project not changed to private, access revoked, etc.).
2. It assumes that we'll only ever allow a user to star a project they
   can view. This is currently the case, but bugs happen.

Add `User#viewable_starred_projects` to filter the starred projects by
those the user either has explicit access to, or are public or
internal. Then use that in all places where we list the user's starred
projects.

Closes #17249.

See merge request !4108
 Restrict starred projects to viewable ones 2016-05-10T17:13:52+00:00 Sean McGivern sean@gitlab.com 2016-05-10T17:03:55+00:00 97424ea544d0954e582a356586270e983d3bbb7a `User#starred_projects` doesn't perform any visibility checks. This has a couple of problems: 1. It assumes a user can always view all of their starred projects in perpetuity (project not changed to private, access revoked, etc.). 2. It assumes that we'll only ever allow a user to star a project they can view. This is currently the case, but bugs happen. Add `User#viewable_starred_projects` to filter the starred projects by those the user either has explicit access to, or are public or internal. Then use that in all places where we list the user's starred projects. 
`User#starred_projects` doesn't perform any visibility checks. This has
a couple of problems:

1. It assumes a user can always view all of their starred projects in
   perpetuity (project not changed to private, access revoked, etc.).
2. It assumes that we'll only ever allow a user to star a project they
   can view. This is currently the case, but bugs happen.

Add `User#viewable_starred_projects` to filter the starred projects by
those the user either has explicit access to, or are public or
internal. Then use that in all places where we list the user's starred
projects.
Add to label :id to response 2016-05-03T16:58:43+00:00 Alfredo Sumaran alfredo@gitlab.com 2016-05-03T16:58:43+00:00 faaab2aef8e7f6b06f8f04dc68596e1229d507db 






Add missing Dashboard::LabelsController
2016-03-23T11:02:15+00:00

Rémy Coutable
remy@rymai.me

2016-03-23T10:39:58+00:00

ce44e5a787482e4d02cee007d35ab30ab651f6f8












Use respond_to instead of a conditional to paginate milestones
2016-03-23T11:02:15+00:00

Rémy Coutable
remy@rymai.me

2016-03-23T08:09:58+00:00

e989d12b0768f0caa7ea1a429a2182e26bbf225a












Fix an issue causing the Dashboard/Milestones page to be blank
2016-03-23T11:02:15+00:00

Rémy Coutable
remy@rymai.me

2016-03-22T18:19:53+00:00

7dc16346bba174d6075cf438adcd70a5596ba935












Use the configured Kaminari "per page" default
2016-03-19T21:37:54+00:00

Robert Speicher
rspeicher@gmail.com

2016-03-19T21:37:54+00:00

085538c2bd817fc083ee9e42c9fdd7f74fc48ecb












Use todo.done without ! in the controller to mark todo as done
2016-03-18T14:00:53+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-03-16T23:56:23+00:00

fb72271e24663c74e6dd66e610fd1add98628648












Mark all as done through AJAX
2016-03-17T13:08:59+00:00

Phil Hughes
me@iamphill.com

2016-03-17T13:08:59+00:00

41c107beccda574aefd3e5d992345087b2e0d848