<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/concerns, branch docs/autodeploy-refactor</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Re-use issue/MR counts for the pagination system</title>
<updated>2017-09-05T09:53:45+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-08-24T16:17:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=42062a454a650d81d9fe6dddde7b39b056ec0a88'/>
<id>42062a454a650d81d9fe6dddde7b39b056ec0a88</id>
<content type='text'>
This changes the issue and MR index pages so the pagination system
re-uses the output of the COUNT(*) query used to calculate the number of
rows per state (opened, closed, etc). This removes the need for an
additional COUNT(*) on both pages.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This changes the issue and MR index pages so the pagination system
re-uses the output of the COUNT(*) query used to calculate the number of
rows per state (opened, closed, etc). This removes the need for an
additional COUNT(*) on both pages.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' into issue-discussions-refactor</title>
<updated>2017-08-31T16:02:19+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-08-31T16:02:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=92edb3edab89dcb7b87bad3ac0fe7fed404fea85'/>
<id>92edb3edab89dcb7b87bad3ac0fe7fed404fea85</id>
<content type='text'>
# Conflicts:
#	app/models/issue.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
# Conflicts:
#	app/models/issue.rb
</pre>
</div>
</content>
</entry>
<entry>
<title>`current_application_settings` belongs on `Gitlab::CurrentSettings`</title>
<updated>2017-08-31T12:38:33+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-08-31T09:47:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5883ce95efcc4cc04f949f9b4e66d73fbede94e2'/>
<id>5883ce95efcc4cc04f949f9b4e66d73fbede94e2</id>
<content type='text'>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix specs</title>
<updated>2017-08-30T08:43:10+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-08-30T08:43:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a540f55c6e8ff64f7284ec4194f4c16ca711c685'/>
<id>a540f55c6e8ff64f7284ec4194f4c16ca711c685</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' into issue-discussions-refactor</title>
<updated>2017-08-30T08:14:56+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-08-30T08:14:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b181d3124e4aefca59fb8fe64400eab8d9c73ad8'/>
<id>b181d3124e4aefca59fb8fe64400eab8d9c73ad8</id>
<content type='text'>
# Conflicts:
#	app/models/issue.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
# Conflicts:
#	app/models/issue.rb
</pre>
</div>
</content>
</entry>
<entry>
<title>Eager load head pipeline projects for MRs index</title>
<updated>2017-08-28T15:36:31+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-08-28T15:35:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b870ae1f59ab0b3f4a10f9dbb2d64324b90ba38b'/>
<id>b870ae1f59ab0b3f4a10f9dbb2d64324b90ba38b</id>
<content type='text'>
This ensures the project of an MR's head pipeline is eager loaded,
preventing an N+1 query problem from occurring when viewing the list of
MRs of a project.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This ensures the project of an MR's head pipeline is eager loaded,
preventing an N+1 query problem from occurring when viewing the list of
MRs of a project.
</pre>
</div>
</content>
</entry>
<entry>
<title>No explicit `to_a` or instance variables needed.</title>
<updated>2017-08-18T10:47:50+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-08-18T10:47:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b7c1b05f30fc45484510f65a5889a89869a7937c'/>
<id>b7c1b05f30fc45484510f65a5889a89869a7937c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Prefer polymorphism over `is_a?`</title>
<updated>2017-08-17T17:26:45+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-08-17T17:26:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5f758aff57dc54df7d92d0fb63e706d58cf1093d'/>
<id>5f758aff57dc54df7d92d0fb63e706d58cf1093d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove view=full_data from NotesController</title>
<updated>2017-08-17T16:55:04+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-08-17T16:55:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=99ba5d0d5097e3170747d17261bb3b9f60aa49fb'/>
<id>99ba5d0d5097e3170747d17261bb3b9f60aa49fb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' into issue-discussions-refactor</title>
<updated>2017-08-17T12:01:31+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-08-17T12:01:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=834f1b30d50dc3ad9d0f6ff81cef24dc6ebc375c'/>
<id>834f1b30d50dc3ad9d0f6ff81cef24dc6ebc375c</id>
<content type='text'>
# Conflicts:
#	package.json
#	spec/support/features/reportable_note_shared_examples.rb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
# Conflicts:
#	package.json
#	spec/support/features/reportable_note_shared_examples.rb
</pre>
</div>
</content>
</entry>
</feed>
