delta/gitlab/gitlab-ce.git/app/controllers/concerns/creates_commit.rb, branch diff-notes-refactor

Make sure different project gets a merge request

2017-01-26T14:37:22+00:00

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_21626479

@tree_edit_project is no longer used

2017-01-26T11:13:02+00:00

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_21626434

Rename from base to start because base could mean merge base

2017-01-06T15:29:13+00:00

Detect if we really want a new merge request properly

2017-01-06T14:49:23+00:00

Properly fix the edge case!

2017-01-06T14:20:02+00:00

Rename source to base to avoid confusion from MR

2017-01-06T14:05:30+00:00

Don't set invalid @mr_source_branch when create_merge_request?

2017-01-06T12:59:38+00:00

Fix for initial commit and remove unneeded args

2017-01-05T20:18:51+00:00

Just trust set_commit_variables to set everything!

2017-01-05T18:11:27+00:00

Removing those weird setup in assign_change_commit_vars
fixed all the failures in the tests. I still cannot say
why but clearly we need to have better names. It's so
confusing right now. We should seriously stop fiddling
those instance variables.

Merge request terms are reversed for GitOperationService

2017-01-05T15:15:58+00:00

This is seriously confusing but a target branch in merge request,
is actually the source branch for GitOperationService, which is
the base branch. The source branch in a merge request, is the
target branch for GitOperationService, which is where we want to
make commits.

Perhaps we should rename source branch in GitOperationService to
base branch, and target branch to committing branch.