<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/autocomplete_controller.rb, branch backport-issues-controller-changes</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Move "Move to different project" to sidebar</title>
<updated>2017-09-04T03:03:17+00:00</updated>
<author>
<name>Eric Eastwood</name>
<email>contact@ericeastwood.com</email>
</author>
<published>2017-08-14T07:26:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=90c60138db4e1f86026aac5760febe4ba066ca30'/>
<id>90c60138db4e1f86026aac5760febe4ba066ca30</id>
<content type='text'>
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/34261
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/34261
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix MySQL failure for emoji autocomplete</title>
<updated>2017-08-30T10:30:12+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-08-30T10:30:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=07a7801c03ec6f5bccd517c38beaec426c554e11'/>
<id>07a7801c03ec6f5bccd517c38beaec426c554e11</id>
<content type='text'>
Postgres lets you treat `count` as another alias for `COUNT(*)` apparently, even
if that's not the actual alias used.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Postgres lets you treat `count` as another alias for `COUNT(*)` apparently, even
if that's not the actual alias used.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add filter by my reaction</title>
<updated>2017-08-30T07:48:55+00:00</updated>
<author>
<name>Hiroyuki Sato</name>
<email>sathiroyuki@gmail.com</email>
</author>
<published>2017-08-30T07:48:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7187395ef13d8d84a145d1b5251882ebada3f7f2'/>
<id>7187395ef13d8d84a145d1b5251882ebada3f7f2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixes the user order being overriden in the autocomplete controller</title>
<updated>2017-07-14T15:31:45+00:00</updated>
<author>
<name>Tiago Botelho</name>
<email>tiagonbotelho@hotmail.com</email>
</author>
<published>2017-07-14T11:16:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=574b3efd6bfe7df64ec704844f2619c547731aa6'/>
<id>574b3efd6bfe7df64ec704844f2619c547731aa6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'dz-restrict-autocomplete' into 'security-9-1'</title>
<updated>2017-06-08T16:52:27+00:00</updated>
<author>
<name>DJ Mountney</name>
<email>david@twkie.net</email>
</author>
<published>2017-06-08T16:52:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=982368dc55bbd22f82bf908f8af220056202a65a'/>
<id>982368dc55bbd22f82bf908f8af220056202a65a</id>
<content type='text'>
Allow users autocomplete by author_id only for authenticated users

See merge request !2100
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Allow users autocomplete by author_id only for authenticated users

See merge request !2100
</pre>
</div>
</content>
</entry>
<entry>
<title>Add per page to user autocomplete</title>
<updated>2017-05-26T17:59:00+00:00</updated>
<author>
<name>Clement Ho</name>
<email>ClemMakesApps@gmail.com</email>
</author>
<published>2017-05-26T17:59:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2339bef1bcf77da258b2e07528122ad7a3a48407'/>
<id>2339bef1bcf77da258b2e07528122ad7a3a48407</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable the Style/TrailingCommaInLiteral cop</title>
<updated>2017-05-10T16:25:45+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-05-03T11:22:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d40e1f547ea9e31e822229bb808aaa6b9201f473'/>
<id>d40e1f547ea9e31e822229bb808aaa6b9201f473</id>
<content type='text'>
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix autocomplete in EE when permissions are sent</title>
<updated>2017-03-10T11:41:44+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-03-10T11:13:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c0f6c856de37b022f5a429b50a1784cf374c45f'/>
<id>5c0f6c856de37b022f5a429b50a1784cf374c45f</id>
<content type='text'>
In EE, `@users` can be an array at the point where we remove the current
user, because it can do a permissions check on the users for project
mirroring.

Fix this in CE by only using array methods, not AR methods. We can't use
`delete` because that uses `Object#equal?`, which isn't true in this
case.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In EE, `@users` can be an array at the point where we remove the current
user, because it can do a permissions check on the users for project
mirroring.

Fix this in CE by only using array methods, not AR methods. We can't use
`delete` because that uses `Object#equal?`, which isn't true in this
case.
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't call `#uniq` on a relation</title>
<updated>2017-01-27T15:28:17+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-01-25T14:44:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2c40a012d63784d1ad91a3629cb1e66ca9ffa96a'/>
<id>2c40a012d63784d1ad91a3629cb1e66ca9ffa96a</id>
<content type='text'>
When there was no project, no search, and no current user or author
param, the AutocompleteController would call `#uniq!` on a relation
instead of an array. This performed the less-efficient `SELECT DISTINCT`
when it wasn't even needed (because the query wouldn't return duplicates
anyway - duplicates were only added by putting a user on top of the
list).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When there was no project, no search, and no current user or author
param, the AutocompleteController would call `#uniq!` on a relation
instead of an array. This performed the less-efficient `SELECT DISTINCT`
when it wasn't even needed (because the query wouldn't return duplicates
anyway - duplicates were only added by putting a user on top of the
list).
</pre>
</div>
</content>
</entry>
<entry>
<title>Shows current user on top of filtered dropdown list</title>
<updated>2017-01-17T15:22:48+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2017-01-17T15:22:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=92682b8ae1ee0620916bdebfe3194967ce1eb2e7'/>
<id>92682b8ae1ee0620916bdebfe3194967ce1eb2e7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
