<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/admin, branch frozen_string_spec_models</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Externalize strings in admin controllers</title>
<updated>2019-03-21T13:31:34+00:00</updated>
<author>
<name>Martin Wortschack</name>
<email>mwortschack@gitlab.com</email>
</author>
<published>2019-03-21T13:31:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ce09a1d4292f474a9c11e50e4a24422b8e42390'/>
<id>8ce09a1d4292f474a9c11e50e4a24422b8e42390</id>
<content type='text'>
- Update PO file</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Update PO file</pre>
</div>
</content>
</entry>
<entry>
<title>Fix undefined variable error on json project views</title>
<updated>2019-03-19T00:27:28+00:00</updated>
<author>
<name>Alejandro Rodríguez</name>
<email>alejorro70@gmail.com</email>
</author>
<published>2019-03-19T00:01:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=585fcfb9e7be7300af04cd2f9c6d1d97d5333cf5'/>
<id>585fcfb9e7be7300af04cd2f9c6d1d97d5333cf5</id>
<content type='text'>
This mistake seems to have always been there, but it only resulted in
errors on the `/explore*.json` since they were the one that _actually_
relied on the local variables.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This mistake seems to have always been there, but it only resulted in
errors on the `/explore*.json` since they were the one that _actually_
relied on the local variables.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '56863-system-messages-in-email' into 'master'</title>
<updated>2019-02-28T16:16:30+00:00</updated>
<author>
<name>Douglas Barbosa Alexandre</name>
<email>dbalexandre@gmail.com</email>
</author>
<published>2019-02-28T16:16:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=790a51a42778b3aa3fb5c8c5afe687ef06dd4433'/>
<id>790a51a42778b3aa3fb5c8c5afe687ef06dd4433</id>
<content type='text'>
Show header and footer system messages in email

Closes #56863

See merge request gitlab-org/gitlab-ce!25474</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Show header and footer system messages in email

Closes #56863

See merge request gitlab-org/gitlab-ce!25474</pre>
</div>
</content>
</entry>
<entry>
<title>Show header and footer system messages in email</title>
<updated>2019-02-27T20:07:50+00:00</updated>
<author>
<name>Alexandru Croitor</name>
<email>acroitor@gitlab.com</email>
</author>
<published>2019-02-20T15:18:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=77985826d94454514c40b8da926e13b3b3791841'/>
<id>77985826d94454514c40b8da926e13b3b3791841</id>
<content type='text'>
* Add email_header_and_footer_enabled flag to appearances table
* Set email_header_and_footer_enabled default value to false
* Add checkbox to appearance to toggle show header and footer in emails
* Add email_header_and_footer_enabled to allowed params in controller
* Add header and footer messages to the html and text email layouts
* Remove the color styling for emails header and footer
* Add empty_mailer layout for emails without layout,
to have the header and footer applied
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Add email_header_and_footer_enabled flag to appearances table
* Set email_header_and_footer_enabled default value to false
* Add checkbox to appearance to toggle show header and footer in emails
* Add email_header_and_footer_enabled to allowed params in controller
* Add header and footer messages to the html and text email layouts
* Remove the color styling for emails header and footer
* Add empty_mailer layout for emails without layout,
to have the header and footer applied
</pre>
</div>
</content>
</entry>
<entry>
<title>don't filter tags by taggable type</title>
<updated>2019-02-27T19:19:50+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2018-12-11T08:43:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=022ee0c0c91d30dea3c1c0472525e86ec8379827'/>
<id>022ee0c0c91d30dea3c1c0472525e86ec8379827</id>
<content type='text'>
Due to performance reasons we cannot use the type filter on the tags.
The table for ActsAsTaggableOn is too big and too unoptimized, such that
the queries time out on production.

See the discussion
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740#note_120087938
for more info.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Due to performance reasons we cannot use the type filter on the tags.
The table for ActsAsTaggableOn is too big and too unoptimized, such that
the queries time out on production.

See the discussion
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740#note_120087938
for more info.
</pre>
</div>
</content>
</entry>
<entry>
<title>use lazy ajax filter dropdown for runner tags</title>
<updated>2019-02-27T19:19:49+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2018-11-15T15:10:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2e05292562e71deeff9b76bd3c696eca2a65a491'/>
<id>2e05292562e71deeff9b76bd3c696eca2a65a491</id>
<content type='text'>
the potential number of available runner tags is too large to load it
statically to a dropdown. we use the same lazy loaded dropdown as is
used for the users dropdown already.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
the potential number of available runner tags is too large to load it
statically to a dropdown. we use the same lazy loaded dropdown as is
used for the users dropdown already.
</pre>
</div>
</content>
</entry>
<entry>
<title>add tag filter to admin runners page</title>
<updated>2019-02-27T19:19:49+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2018-06-13T09:18:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0fad7aa79c7925391b3586187a6da464bffbd49d'/>
<id>0fad7aa79c7925391b3586187a6da464bffbd49d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-fix-users-controller-ruby-2.6-compat' into 'master'</title>
<updated>2019-02-25T11:20:41+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2019-02-25T11:20:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e5c7027faffb75f1d2f7221fa11609741010d82f'/>
<id>e5c7027faffb75f1d2f7221fa11609741010d82f</id>
<content type='text'>
Make Admin::UsersController work with Ruby 2.6

See merge request gitlab-org/gitlab-ce!25316</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make Admin::UsersController work with Ruby 2.6

See merge request gitlab-org/gitlab-ce!25316</pre>
</div>
</content>
</entry>
<entry>
<title>Port EE System Header And Footer feature to CE</title>
<updated>2019-02-21T15:55:51+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2018-04-02T14:26:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=28e1739a3fd8c93e4805fe0053faf820cec4e1bc'/>
<id>28e1739a3fd8c93e4805fe0053faf820cec4e1bc</id>
<content type='text'>
remove EE specific code
remove EE licence checks
move migration from EE to CE folder structure
move specs from EE to CE folder structure
remove EE specific flag specs
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
remove EE specific code
remove EE licence checks
move migration from EE to CE folder structure
move specs from EE to CE folder structure
remove EE specific flag specs
</pre>
</div>
</content>
</entry>
<entry>
<title>Make Admin::UsersController work with Ruby 2.6</title>
<updated>2019-02-19T23:36:05+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-02-16T22:26:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e87c255d9e76fb3ca691267107e83d48c90bc816'/>
<id>e87c255d9e76fb3ca691267107e83d48c90bc816</id>
<content type='text'>
Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
will fail with a `wrong number of arguments (given 1, expected 0)`
message because the `Enumerable#filter` implementation overrides the
delegated `ActiveRecord::Relation#filter` method.

To make Admin::UsersController compatible with Ruby 2.6, rename
`User.filter` to `User.filter_items`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
will fail with a `wrong number of arguments (given 1, expected 0)`
message because the `Enumerable#filter` implementation overrides the
delegated `ActiveRecord::Relation#filter` method.

To make Admin::UsersController compatible with Ruby 2.6, rename
`User.filter` to `User.filter_items`.
</pre>
</div>
</content>
</entry>
</feed>
