<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/controllers/admin/runner_projects_controller.rb, branch docs/doc-README</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Enable frozen string in app/controllers/**/*.rb</title>
<updated>2018-09-19T04:22:45+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-09-14T05:42:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=73322a0e551bbbc42d429b15e7ad9fd375ab761d'/>
<id>73322a0e551bbbc42d429b15e7ad9fd375ab761d</id>
<content type='text'>
Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Updates from `rubocop -a`</title>
<updated>2018-07-09T13:13:08+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2018-07-02T10:43:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ee08b77bc5ae11553d59c182ea8292b77699115'/>
<id>4ee08b77bc5ae11553d59c182ea8292b77699115</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve `Ci::Runner#assign_to` to return a flag whether it succeeded or not</title>
<updated>2018-05-31T08:56:41+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-05-28T10:49:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6e95b04405f1e07f76505b03c6c096f4c4d084b'/>
<id>c6e95b04405f1e07f76505b03c6c096f4c4d084b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers</title>
<updated>2017-06-06T22:45:16+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2017-06-06T22:45:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a544e46bb083c27bfa2966ea67ddf97b5dc7cb08'/>
<id>a544e46bb083c27bfa2966ea67ddf97b5dc7cb08</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>replace `find_with_namespace` with `find_by_full_path`</title>
<updated>2017-02-03T00:14:04+00:00</updated>
<author>
<name>Adam Pahlevi</name>
<email>adam.pahlevi@gmail.com</email>
</author>
<published>2017-02-02T23:43:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a0586dbc165cc09422412149712a218938137308'/>
<id>a0586dbc165cc09422412149712a218938137308</id>
<content type='text'>
add complete changelog for !8949
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
add complete changelog for !8949
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow admins to assign locked runners:</title>
<updated>2016-06-28T11:55:12+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T11:55:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=397a69f834ad8854301df4c09035e16d35ac5158'/>
<id>397a69f834ad8854301df4c09035e16d35ac5158</id>
<content type='text'>
And show information about locked status.

Help! This looks bad :o
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
And show information about locked status.

Help! This looks bad :o
</pre>
</div>
</content>
</entry>
<entry>
<title>Admin should be able to turn shared runners into specific ones:</title>
<updated>2016-06-28T05:46:47+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T05:46:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=95c99cd4fd0f768394d582ac49dc83ac93d9c1e5'/>
<id>95c99cd4fd0f768394d582ac49dc83ac93d9c1e5</id>
<content type='text'>
The regression was introduced by:

https://gitlab.com/gitlab-org/gitlab-ce/commit/1b8f52d9206bdf19c0dde04505c4c0b1cf46cfbe

I did that because there's a test specifying that a shared runner cannot
be enabled, in the API. So I assume that is the case for non-admin, but
admins should be able to do so anyway.

Also added a test to make sure this won't regress again.

Closes #19039
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The regression was introduced by:

https://gitlab.com/gitlab-org/gitlab-ce/commit/1b8f52d9206bdf19c0dde04505c4c0b1cf46cfbe

I did that because there's a test specifying that a shared runner cannot
be enabled, in the API. So I assume that is the case for non-admin, but
admins should be able to do so anyway.

Also added a test to make sure this won't regress again.

Closes #19039
</pre>
</div>
</content>
</entry>
<entry>
<title>Admin::RunnerProjectsController#index is not used</title>
<updated>2016-06-17T13:12:58+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-17T13:04:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dbd534a8537ba02b93dcf673aee0b62d51bf129d'/>
<id>dbd534a8537ba02b93dcf673aee0b62d51bf129d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix typo. It's ivar and the column was called locked</title>
<updated>2016-06-16T15:31:54+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-16T15:31:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=314befded7e30981bf858e8e4aebd3df7f8d7d54'/>
<id>314befded7e30981bf858e8e4aebd3df7f8d7d54</id>
<content type='text'>
Again! For admin.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Again! For admin.
</pre>
</div>
</content>
</entry>
<entry>
<title>Return the association and check it in controller instead:</title>
<updated>2016-06-14T15:11:43+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-14T15:11:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9cf45b058627f039040165519de9c2074dda141f'/>
<id>9cf45b058627f039040165519de9c2074dda141f</id>
<content type='text'>
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4641#note_12444891
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4641#note_12444891
</pre>
</div>
</content>
</entry>
</feed>
