delta/gitlab/gitlab-ce.git/app/controllers/admin/hooks_controller.rb, branch docs/doc-README

Externalize strings in admin controllers

2019-03-21T13:31:34+00:00

- Update PO file

Enable frozen string in app/controllers/**/*.rb

2018-09-19T04:22:45+00:00

Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.

Updates from `rubocop -a`

2018-07-09T13:13:08+00:00

Fixed pagination of web hook logs

2018-07-03T12:24:17+00:00

For reasons unknown, the logs of a web hook were paginated in memory.
This would result in the "Edit" page of a web hook timing out once it
has more than a few thousand log entries.

This commit makes the following changes:

1. We use LIMIT/OFFSET to paginate the data, instead of doing this in
   memory.

2. We limit the logs to the last two days, just like the documentation
   says (instead of retrieving everything).

3. We change the indexes on "web_hook_logs" so the query to get the data
   can perform a backwards index scan, without the need for a Filter.

These changes combined ensure that Projects::HooksController#edit no
longer times out.

Rails5 fix Admin::HooksController

2018-06-20T06:30:24+00:00

reference triggers.values for permitted parameters

2018-01-17T08:55:00+00:00

add missing permitted param

2018-01-17T08:55:00+00:00

Wrong data type when testing webhooks

2017-07-20T15:12:06+00:00

Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers

2017-06-06T22:45:16+00:00

Implement web hooks logging

2017-05-25T07:07:52+00:00

* implemented logging of project and system web hooks
* implemented UI for user area (project hooks)
* implemented UI for admin area (system hooks)
* implemented retry of logged webhook
* NOT imeplemented log remover