<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/assets/javascripts/protected_branch_create.js.es6, branch ci-https</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Toggle dropdown disabled attribute</title>
<updated>2016-08-21T05:20:57+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-21T05:20:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4a4d8608e8a09e0c55f690aeefc05f742bc67011'/>
<id>4a4d8608e8a09e0c55f690aeefc05f742bc67011</id>
<content type='text'>
Before this the dropdowns were not being disabled if the user unselected an option from the allowed to merge/push dropdowns.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before this the dropdowns were not being disabled if the user unselected an option from the allowed to merge/push dropdowns.
</pre>
</div>
</content>
</entry>
<entry>
<title>Backport changes from gitlab-org/gitlab-ee!581 to CE.</title>
<updated>2016-08-16T05:35:14+00:00</updated>
<author>
<name>Timothy Andrew</name>
<email>mail@timothyandrew.net</email>
</author>
<published>2016-08-16T05:09:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e805a6470031d942f7de604fdf7acfc7cf4f0b1a'/>
<id>e805a6470031d942f7de604fdf7acfc7cf4f0b1a</id>
<content type='text'>
!581 has a lot of changes that would cause merge conflicts if not
properly backported to CE. This commit/MR serves as a better
foundation for gitlab-org/gitlab-ee!581.

= Changes =

1. Move from `has_one {merge,push}_access_level` to `has_many`, with the
   `length` of the association limited to `1`. This is _effectively_ a
   `has_one` association, but should cause less conflicts with EE, which
   is set to `has_many`. This has a number of related changes in the
   views, specs, and factories.

2. Make `gon` variable loading more consistent (with EE!581) in the
   `ProtectedBranchesController`. Also use `::` to prefix the
   `ProtectedBranches` services, because this is required in EE.

3. Extract a `ProtectedBranchAccess` concern from the two access level
   models. This concern only has a single `humanize` method here, but
   will have more methods in EE.

4. Add `form_errors` to the protected branches creation form. This is
   not strictly required for EE compatibility, but was an oversight
   nonetheless.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
!581 has a lot of changes that would cause merge conflicts if not
properly backported to CE. This commit/MR serves as a better
foundation for gitlab-org/gitlab-ee!581.

= Changes =

1. Move from `has_one {merge,push}_access_level` to `has_many`, with the
   `length` of the association limited to `1`. This is _effectively_ a
   `has_one` association, but should cause less conflicts with EE, which
   is set to `has_many`. This has a number of related changes in the
   views, specs, and factories.

2. Make `gon` variable loading more consistent (with EE!581) in the
   `ProtectedBranchesController`. Also use `::` to prefix the
   `ProtectedBranches` services, because this is required in EE.

3. Extract a `ProtectedBranchAccess` concern from the two access level
   models. This concern only has a single `humanize` method here, but
   will have more methods in EE.

4. Add `form_errors` to the protected branches creation form. This is
   not strictly required for EE compatibility, but was an oversight
   nonetheless.
</pre>
</div>
</content>
</entry>
<entry>
<title>Refine selector for form submit button</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-05T20:26:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f9378bad06688bb4e1428d0b77debd9c6966a6ad'/>
<id>f9378bad06688bb4e1428d0b77debd9c6966a6ad</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Cache onSelect callback before passing to each dropdown instance</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-05T07:18:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0e730a14a108dac05b25783427e8f299b0db4adc'/>
<id>0e730a14a108dac05b25783427e8f299b0db4adc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Wrap classes with IIFE and define it inside gl namespace</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-05T06:57:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8f29c332b5f0520676c4e1466df5acc8cea5a513'/>
<id>8f29c332b5f0520676c4e1466df5acc8cea5a513</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Create protected branch dropdown directly</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-04T08:35:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2df9bae7163601ba28e8367ed121dc04b99836ac'/>
<id>2df9bae7163601ba28e8367ed121dc04b99836ac</id>
<content type='text'>
Since there’s only one dropdown of this type we don’t need a class to create this dropdown masively.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since there’s only one dropdown of this type we don’t need a class to create this dropdown masively.
</pre>
</div>
</content>
</entry>
<entry>
<title>No need to pass event as a parameter</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-04T06:44:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3f399fe1817264246f978f542083962319ed0a82'/>
<id>3f399fe1817264246f978f542083962319ed0a82</id>
<content type='text'>
We should stop passing events as a parameter since we cannot call the method programatically without faking or creating an event even when that event is not entirely required.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should stop passing events as a parameter since we cannot call the method programatically without faking or creating an event even when that event is not entirely required.
</pre>
</div>
</content>
</entry>
<entry>
<title>Select first value by default</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-04T01:08:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e1d86ec9149a328bf975f55d003b3c29806cadbb'/>
<id>e1d86ec9149a328bf975f55d003b3c29806cadbb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unnecesary classes to generate dropdowns</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-04T00:28:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3b228db1c20ed582c911e3269551fcdfd9f1bde7'/>
<id>3b228db1c20ed582c911e3269551fcdfd9f1bde7</id>
<content type='text'>
Since there are only one dropdown of each type there are no need to create a class to initialize multiple elements with the same CSS class name.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since there are only one dropdown of each type there are no need to create a class to initialize multiple elements with the same CSS class name.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix class names and move each class to its own file</title>
<updated>2016-08-05T22:19:01+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-08-03T21:45:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bc5bc7cb9efe760a540b761eb3cd712ef3de129f'/>
<id>bc5bc7cb9efe760a540b761eb3cd712ef3de129f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
