<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/assets/javascripts/gfm_auto_complete.js, branch patch-53</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Escape special characters in GFM auto complete highlighting</title>
<updated>2019-04-25T08:11:20+00:00</updated>
<author>
<name>Jan Beckmann</name>
<email>king-jan1999@hotmail.de</email>
</author>
<published>2019-04-25T08:11:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5848f2833ae40b73003be1e37dd379dd69c20fcc'/>
<id>5848f2833ae40b73003be1e37dd379dd69c20fcc</id>
<content type='text'>
Fixes #60552
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes #60552
</pre>
</div>
</content>
</entry>
<entry>
<title>Only use backslash escapes in autocomplete when needed</title>
<updated>2019-04-17T12:15:36+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-17T11:52:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=67b16f7ea3a616875b45d07215197b7e4a08eba4'/>
<id>67b16f7ea3a616875b45d07215197b7e4a08eba4</id>
<content type='text'>
Autocompletion for references happens on the frontend. Those references
are turned into actual references on the backend, but only after
Markdown processing has happened. That means that if a reference
contains a character that Markdown might consume, it won't render
correctly. So we need to do some escaping on the frontend.

We have these potential problem characters:
https://docs.gitlab.com/ee/user/markdown.html#emphasis

1. ~ - this is ~~strikethrough~~, but only when doubled.
2. _ - used for _emphasis_, doubled is __bold__.
3. * - also used for *emphasis*, doubled is **bold** also.
4. ` - used for `code spans`, any number works.

We don't need to escape `-` any more. When it comes to being inside a
word:

1. a~~b~~ has strikethrough, so it needs to be escaped everywhere.
2. a_b_ has no emphasis (see [a]) so it only needs to be escaped at the
   start and end of words.
3. a*b* has emphasis, so it needs to be escaped everywhere.
4. a`b` has a code span, so it needs to be escaped everywhere.

Or, in code terms:

1. Always escape ~~, *, and ` when being inserted by autocomplete.
2. Escape _ when it's either at the beginning or the end of a word.

[a]: https://docs.gitlab.com/ee/user/markdown.html#multiple-underscores-in-words
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Autocompletion for references happens on the frontend. Those references
are turned into actual references on the backend, but only after
Markdown processing has happened. That means that if a reference
contains a character that Markdown might consume, it won't render
correctly. So we need to do some escaping on the frontend.

We have these potential problem characters:
https://docs.gitlab.com/ee/user/markdown.html#emphasis

1. ~ - this is ~~strikethrough~~, but only when doubled.
2. _ - used for _emphasis_, doubled is __bold__.
3. * - also used for *emphasis*, doubled is **bold** also.
4. ` - used for `code spans`, any number works.

We don't need to escape `-` any more. When it comes to being inside a
word:

1. a~~b~~ has strikethrough, so it needs to be escaped everywhere.
2. a_b_ has no emphasis (see [a]) so it only needs to be escaped at the
   start and end of words.
3. a*b* has emphasis, so it needs to be escaped everywhere.
4. a`b` has a code span, so it needs to be escaped everywhere.

Or, in code terms:

1. Always escape ~~, *, and ` when being inserted by autocomplete.
2. Escape _ when it's either at the beginning or the end of a word.

[a]: https://docs.gitlab.com/ee/user/markdown.html#multiple-underscores-in-words
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Merge branch 'tz-reorganise-digests-json' into 'master'"</title>
<updated>2019-04-10T18:49:06+00:00</updated>
<author>
<name>Tim Zallmann</name>
<email>tzallmann@gitlab.com</email>
</author>
<published>2019-03-14T09:18:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c57529556c2ba3053e3a622efc2f5b6eeaabe009'/>
<id>c57529556c2ba3053e3a622efc2f5b6eeaabe009</id>
<content type='text'>
Reverts the loading of emojis and its images to move forward with RC
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reverts the loading of emojis and its images to move forward with RC
</pre>
</div>
</content>
</entry>
<entry>
<title>Moved all emojis to the public folder</title>
<updated>2019-03-07T09:33:03+00:00</updated>
<author>
<name>Tim Zallmann</name>
<email>tzallmann@gitlab.com</email>
</author>
<published>2019-03-07T09:33:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d07919de90e8212673adb47a4e60514c2573f2ce'/>
<id>d07919de90e8212673adb47a4e60514c2573f2ce</id>
<content type='text'>
Created new emojis map in public folder

Renamed folder to emojis

Loading now the emojis from Localstorage or from Server

Moved all emojis to the public folder

Loading the emojis.json file now through AJAX

Loads now the map in the web element instead when building the emoji tag

Updated the custom Element Setup to modern method

Fixed Emoji Karma Specs for async loading

Loading now the emojis from Localstorage or from Server

Loads now the map in the web element instead when building the emoji tag

Fixed problem with FIXTURE_PATH for emojis fixtures

Fixes Linting Error in gemojione.rake

Fixed Emoji Karma Specs

Fix static type check in gemojione and check if already registered

Testing if the Emoji Support Check is failing Rspec

Change of CLass Name, returning true on check to test

Fixes failing Emoji RSpec Tests

Moved Emojis into public/-/emojis/1/

Fixed Linting Errors in gl_emoji

Fix to fixtures creation for emojis

Fixed path spec for new subdirectory -/emojis

Optimized emojis.json output

Fix for Emoji Spec failure due to unicode dataset

Better catch handling for emojis
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Created new emojis map in public folder

Renamed folder to emojis

Loading now the emojis from Localstorage or from Server

Moved all emojis to the public folder

Loading the emojis.json file now through AJAX

Loads now the map in the web element instead when building the emoji tag

Updated the custom Element Setup to modern method

Fixed Emoji Karma Specs for async loading

Loading now the emojis from Localstorage or from Server

Loads now the map in the web element instead when building the emoji tag

Fixed problem with FIXTURE_PATH for emojis fixtures

Fixes Linting Error in gemojione.rake

Fixed Emoji Karma Specs

Fix static type check in gemojione and check if already registered

Testing if the Emoji Support Check is failing Rspec

Change of CLass Name, returning true on check to test

Fixes failing Emoji RSpec Tests

Moved Emojis into public/-/emojis/1/

Fixed Linting Errors in gl_emoji

Fix to fixtures creation for emojis

Fixed path spec for new subdirectory -/emojis

Optimized emojis.json output

Fix for Emoji Spec failure due to unicode dataset

Better catch handling for emojis
</pre>
</div>
</content>
</entry>
<entry>
<title>Style avatars for groups and projects</title>
<updated>2019-02-25T13:00:05+00:00</updated>
<author>
<name>Martin Wortschack</name>
<email>mwortschack@gitlab.com</email>
</author>
<published>2019-02-25T13:00:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12ed4dbf4a2a2e0a53d74470fc76b7e3b39cc1b7'/>
<id>12ed4dbf4a2a2e0a53d74470fc76b7e3b39cc1b7</id>
<content type='text'>
- Add rectangular avatar classes
- Update avatar for groups
- Update avatar for projects
- Update avatar for frequent items
- Update avatar on "Fork project" page
- Conditionally add rectangular avatar class to autocomplete items
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Add rectangular avatar classes
- Update avatar for groups
- Update avatar for projects
- Update avatar for frequent items
- Update avatar on "Fork project" page
- Conditionally add rectangular avatar class to autocomplete items
</pre>
</div>
</content>
</entry>
<entry>
<title>CE backport for `reference` in gfm_autocomplete</title>
<updated>2019-01-07T03:01:51+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>hleeyu@gmail.com</email>
</author>
<published>2018-12-21T08:49:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12b3a203228cef5946f1c8dc740ba739b1aed797'/>
<id>12b3a203228cef5946f1c8dc740ba739b1aed797</id>
<content type='text'>
Currently not used by any CE code
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently not used by any CE code
</pre>
</div>
</content>
</entry>
<entry>
<title>Escape label and milestone titles to prevent XSS</title>
<updated>2018-12-20T06:55:49+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushalspandya@gmail.com</email>
</author>
<published>2018-12-11T12:22:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5f03d26a194c25abef20b94c175ac4f587e821a2'/>
<id>5f03d26a194c25abef20b94c175ac4f587e821a2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for custom highlighting slash commands via warning flags</title>
<updated>2018-11-21T14:22:41+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushalspandya@gmail.com</email>
</author>
<published>2018-11-21T14:22:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3b98cb1664ff0dcf04e475c5dadd342b58e9cd0a'/>
<id>3b98cb1664ff0dcf04e475c5dadd342b58e9cd0a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix user name autocomplete XSS when name contains HTML</title>
<updated>2018-11-12T09:21:25+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushal@gitlab.com</email>
</author>
<published>2018-11-12T09:21:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=117072d45f7fbcc375bec66758f5187f2a0de3ea'/>
<id>117072d45f7fbcc375bec66758f5187f2a0de3ea</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix eslint violations</title>
<updated>2018-10-31T19:33:12+00:00</updated>
<author>
<name>Mike Greiling</name>
<email>mike@pixelcog.com</email>
</author>
<published>2018-10-30T21:36:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3d13d369f9a5c33466c8f5c99b79f92de5f85ba0'/>
<id>3d13d369f9a5c33466c8f5c99b79f92de5f85ba0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
