<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/Dangerfile, branch patch-68</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Extract roulette to its own module</title>
<updated>2019-05-30T11:24:28+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-29T14:38:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c90ba127bf8cdd4ccac9692b6c96fa746314cd55'/>
<id>c90ba127bf8cdd4ccac9692b6c96fa746314cd55</id>
<content type='text'>
So it's more modular and extensible
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
So it's more modular and extensible
</pre>
</div>
</content>
</entry>
<entry>
<title>Add Danger rule for EE/CE templates</title>
<updated>2019-04-24T12:08:33+00:00</updated>
<author>
<name>Nathan Friend</name>
<email>nathan@gitlab.com</email>
</author>
<published>2019-04-24T12:08:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c3268a6af542921d67c044976a0336f66ce38832'/>
<id>c3268a6af542921d67c044976a0336f66ce38832</id>
<content type='text'>
This commit adds a rule to Danger that warns the developer when their MR
includes changes to a CE .vue file that has a counterpart in the
EE repo or vice-versa.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit adds a rule to Danger that warns the developer when their MR
includes changes to a CE .vue file that has a counterpart in the
EE repo or vice-versa.
</pre>
</div>
</content>
</entry>
<entry>
<title>Exempt release automation MRs from Danger rules</title>
<updated>2019-04-04T11:26:01+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2019-04-04T11:26:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fee7036394c881aa5a1f9851b3531267104e8c1d'/>
<id>fee7036394c881aa5a1f9851b3531267104e8c1d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Set specific reviewers for the GitLab UI WG effort</title>
<updated>2019-03-29T11:56:18+00:00</updated>
<author>
<name>Filipa Lacerda</name>
<email>filipa@gitlab.com</email>
</author>
<published>2019-03-29T10:51:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=072489e36df3ef6824ba0f9b90e7a6f87f9ee4f4'/>
<id>072489e36df3ef6824ba0f9b90e7a6f87f9ee4f4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Set specific reviewers for single codebase effort</title>
<updated>2019-03-11T09:42:19+00:00</updated>
<author>
<name>Marin Jankovski</name>
<email>maxlazio@gmail.com</email>
</author>
<published>2019-02-27T13:39:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=87d19300e3394192d6872243ba8939f2e7ce1ec9'/>
<id>87d19300e3394192d6872243ba8939f2e7ce1ec9</id>
<content type='text'>
This extends Danger so it informs MR authors that single codebase merge
requests need to be approved by a specific group of engineers.

Co-authored-by: Yorick Peterse &lt;yorickpeterse@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This extends Danger so it informs MR authors that single codebase merge
requests need to be approved by a specific group of engineers.

Co-authored-by: Yorick Peterse &lt;yorickpeterse@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Reviewer roulette via Danger</title>
<updated>2019-02-13T16:41:28+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-02-05T17:16:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=77b2ecd2b1de3f66c3d9ebd5e58fedafb17ea606'/>
<id>77b2ecd2b1de3f66c3d9ebd5e58fedafb17ea606</id>
<content type='text'>
Make danger pick reviewers and maintainers at random, for feontend,
backend, database, etc, changes, whenever files belonging to those
teams get changed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make danger pick reviewers and maintainers at random, for feontend,
backend, database, etc, changes, whenever files belonging to those
teams get changed.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add danger check for duplicate yarn dependencies</title>
<updated>2018-12-17T08:58:39+00:00</updated>
<author>
<name>Lukas Eipert</name>
<email>leipert@gitlab.com</email>
</author>
<published>2018-09-07T11:20:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=243bd56f9db95a29deaec9ff093b2ff8d02f82ee'/>
<id>243bd56f9db95a29deaec9ff093b2ff8d02f82ee</id>
<content type='text'>
This danger check utilises `yarn-deduplicate` in order to show duplicate
dependencies in the yarn.lock dependency tree.
Often when introducing new dependencies or updating existing ones, yarn
does not seem to build the most optimal dependency tree.

In order to prevent those unnecessary dependency updates we are nudging
developers and maintainers to resolve these issues in MRs. Automating
this with danger especially helps, as yarn.lock files are not that easy
to review.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This danger check utilises `yarn-deduplicate` in order to show duplicate
dependencies in the yarn.lock dependency tree.
Often when introducing new dependencies or updating existing ones, yarn
does not seem to build the most optimal dependency tree.

In order to prevent those unnecessary dependency updates we are nudging
developers and maintainers to resolve these issues in MRs. Automating
this with danger especially helps, as yarn.lock files are not that easy
to review.
</pre>
</div>
</content>
</entry>
<entry>
<title>Create helper to get all changed files</title>
<updated>2018-10-22T09:04:55+00:00</updated>
<author>
<name>Lukas Eipert</name>
<email>leipert@gitlab.com</email>
</author>
<published>2018-10-16T13:56:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=253e1818aa3efafb05d9994aab0f778d339e26ac'/>
<id>253e1818aa3efafb05d9994aab0f778d339e26ac</id>
<content type='text'>
Danger apparently has three different objects which could contain files
you often want to check:

 - git.added_files
 - git.modified_files
 - git.renamed_files

The problem: If a file is renamed, `modified_files` contains the file
path before the rename. In some Danger checks we use `added_files` +
`modified_files`, which might contain the deleted paths of renamed
files, but missing the new paths of renamed files.

So we need to consider `renamed_files` as well.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Danger apparently has three different objects which could contain files
you often want to check:

 - git.added_files
 - git.modified_files
 - git.renamed_files

The problem: If a file is renamed, `modified_files` contains the file
path before the rename. In some Danger checks we use `added_files` +
`modified_files`, which might contain the deleted paths of renamed
files, but missing the new paths of renamed files.

So we need to consider `renamed_files` as well.
</pre>
</div>
</content>
</entry>
<entry>
<title>Danger check for ignored eslint rules</title>
<updated>2018-09-29T06:22:12+00:00</updated>
<author>
<name>Lukas Eipert</name>
<email>leipert@gitlab.com</email>
</author>
<published>2018-09-21T16:26:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=685d579472018c968e785d7d49ec7f84f7438e97'/>
<id>685d579472018c968e785d7d49ec7f84f7438e97</id>
<content type='text'>
We disabled a lot of eslint rules on a per-file basis. This checks
touched files for those and reminds you to re-enable the rules and fix
them.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We disabled a lot of eslint rules on a per-file basis. This checks
touched files for those and reminds you to re-enable the rules and fix
them.
</pre>
</div>
</content>
</entry>
<entry>
<title>Danger check for unprettified JavaScript</title>
<updated>2018-09-28T20:04:26+00:00</updated>
<author>
<name>Lukas Eipert</name>
<email>leipert@gitlab.com</email>
</author>
<published>2018-09-21T15:36:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4df24e5f046f94a04b379fcd1d6d57ef49cfd6dc'/>
<id>4df24e5f046f94a04b379fcd1d6d57ef49cfd6dc</id>
<content type='text'>
This adds a Dangerfile which executes `prettier` to find out if someone
touched Frontend files and forgot to run it on their current branch.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds a Dangerfile which executes `prettier` to find out if someone
touched Frontend files and forgot to run it on their current branch.
</pre>
</div>
</content>
</entry>
</feed>
