delta/gitlab/gitlab-ce.git, branch nik-db-migrations-prefer-atomic-docs gitlab.com: gitlab-org/gitlab-ce.git Addreses backend and technical writer comments: 2019-08-23T20:07:03+00:00 Mayra Cabrera mcabrera@gitlab.com 2019-08-16T16:31:02+00:00 aee8a868f6b74cf4350d1ac4f66d06515d0b78c3 - Removes text mentioning MySQL - Removes duplicated text - Makes section a bit more descriptive - Reorganices 'Atomicity' and 'Heave operations in a single transaction' sections. - Add missing commans and fixes typos - Makes the text more understandable. 
- Removes text mentioning MySQL
- Removes duplicated text
- Makes section a bit more descriptive
- Reorganices 'Atomicity' and 'Heave operations in a single transaction'
sections.
- Add missing commans and fixes typos
- Makes the text more understandable.
Correction on DML+DDL in a single transaction 2019-08-23T20:07:03+00:00 Nikolay Samokhvalov gitlab@samokhvalov.com 2019-07-22T15:35:23+00:00 4594d1c05e4c5181396713a49f6e7046a21a4d0a 






Apply suggestion to doc/development/migration_style_guide.md
2019-08-23T20:07:03+00:00

Nikolay Samokhvalov
gitlab@samokhvalov.com

2019-07-22T15:32:38+00:00

9d6411403de22a2d96b851ebcb9cb5b130029093












Migrations guide: use atomic steps, when possible
2019-08-23T20:07:03+00:00

Nikolay Samokhvalov
gitlab@samokhvalov.com

2019-07-19T23:16:04+00:00

87d6edf54dddfdf97281c4ca8606f269ed158403

Currently, the DB migrations guide says that "you must" use non-blocking
operations (such as CREATE INDEX CONCURRENTLY), always.

But this does not make sense in cases of empty tables and leads to
splitting the work to multiple non-atomic
(with disable_ddl_transaction!) DB migrations.

To follow KISS principle, to have fewer DB migrations steps,
to have them atomic when it's possible and simplify deployment
and troubleshooting, the following exceptions were added
to the doc:

- index creation,
- index dropping,
- defining an FK,
- adding a column with DEFAULT,





Currently, the DB migrations guide says that "you must" use non-blocking
operations (such as CREATE INDEX CONCURRENTLY), always.

But this does not make sense in cases of empty tables and leads to
splitting the work to multiple non-atomic
(with disable_ddl_transaction!) DB migrations.

To follow KISS principle, to have fewer DB migrations steps,
to have them atomic when it's possible and simplify deployment
and troubleshooting, the following exceptions were added
to the doc:

- index creation,
- index dropping,
- defining an FK,
- adding a column with DEFAULT,







Merge branch 'ce-jej/fix-sso-enforced-docker-registry-auth' into 'master'
2019-08-23T17:53:14+00:00

Kamil Trzciński
ayufan@ayufan.eu

2019-08-23T17:53:14+00:00

24ff249ded4bc2098e590d1f3605a3ebe3954723

[CE backport]  Enforced SSO shouldn't break container registry authentication

See merge request gitlab-org/gitlab-ce!32110




[CE backport]  Enforced SSO shouldn't break container registry authentication

See merge request gitlab-org/gitlab-ce!32110






Merge branch '62322-add-optional-id-to-label-api-put-delete-pd' into 'master'
2019-08-23T17:45:43+00:00

Kamil Trzciński
ayufan@ayufan.eu

2019-08-23T17:45:43+00:00

20d38feda1b7085a2d1246a960ab575cd545da8f

Add label_id parameter to label API for PUT and DELETE

Closes #62322

See merge request gitlab-org/gitlab-ce!31804




Add label_id parameter to label API for PUT and DELETE

Closes #62322

See merge request gitlab-org/gitlab-ce!31804






Add label_id parameter to label API for PUT and DELETE
2019-08-23T17:45:42+00:00

Patrick Derichs
pderichs@gitlab.com

2019-08-23T17:45:42+00:00

f1e24d4d31776f675cd4a7cdc21ddc9d496400cf

Add specs for new parameter and updated documentation as well.





Add specs for new parameter and updated documentation as well.







Merge branch 'jc-fix-auto-rugged-detection' into 'master'
2019-08-23T17:42:40+00:00

Lin Jen-Shin
godfat@godfat.org

2019-08-23T17:42:40+00:00

e84922906e51b22f2f335ebaa4390ccac2e4caf8

Handle when server info doesn't have the storage in question

See merge request gitlab-org/gitlab-ce!32023




Handle when server info doesn't have the storage in question

See merge request gitlab-org/gitlab-ce!32023






Update CHANGELOG.md for 12.2.1
2019-08-23T17:22:49+00:00

GitLab Release Tools Bot
delivery-team+release-tools@gitlab.com

2019-08-23T17:22:49+00:00

15ea614765ce88a93c91a3b055a7c4fb96fd1ccb

[ci skip]




[ci skip]






Merge branch 'sh-eliminate-gitaly-nplus-one-notes' into 'master'
2019-08-23T17:21:19+00:00

Kamil Trzciński
ayufan@ayufan.eu

2019-08-23T17:21:19+00:00

99e8b77e5eaa8bd60c02935ee5baaebf31bc645a

Eliminate Gitaly N+1 queries with notes API

See merge request gitlab-org/gitlab-ce!32089




Eliminate Gitaly N+1 queries with notes API

See merge request gitlab-org/gitlab-ce!32089