<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch install_souce_code_pro</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>install source code pro as font for diff and build pages</title>
<updated>2016-03-15T21:41:26+00:00</updated>
<author>
<name>Arinde Eniola</name>
<email>eniolaarinde1@gmail.com</email>
</author>
<published>2016-03-15T21:41:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f42728305bc555d16ecf053dc5849a2b169911e8'/>
<id>f42728305bc555d16ecf053dc5849a2b169911e8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add 8.5.6 CHANGELOG items</title>
<updated>2016-03-15T17:16:21+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-03-15T17:16:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ac8c6f24e3070c28ab6f246599c95fd8f3b7e3a5'/>
<id>ac8c6f24e3070c28ab6f246599c95fd8f3b7e3a5</id>
<content type='text'>
[ci skip]
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
[ci skip]
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'css-style-guide' into 'master'</title>
<updated>2016-03-15T16:52:53+00:00</updated>
<author>
<name>Jacob Schatz</name>
<email>jschatz1@gmail.com</email>
</author>
<published>2016-03-15T16:52:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=37707ac59e6c4e6db2b758338e13cb089dacd8c7'/>
<id>37707ac59e6c4e6db2b758338e13cb089dacd8c7</id>
<content type='text'>

CSS style guide

Working towards what was discussed in #13552, this adds the [SCSS Linter gem](https://github.com/brigade/scss-lint) for style guide conformity in CI.

TODO:
- [x] Agree on and write SCSS Style Guide Documentation.
- [x] Document the `scss-lint` config file.
- [x] Figure out how best to run this in CI, right now it's taking longer than I would think it should.
- [x] Use CSSComb for auto-correction (Maybe just include a CSSComb config file and have developers run the node package manually if they're interested in using it?).

My logic for not using CSSComb in the first place is that, AFAIK, we don't currently require Node/NPM, even in the dev environment. Maybe I'm wrong about that? `scss-lint` is a Ruby implementation of a similar concept, but it doesn't include autocorrect.

Is there a way we can run get GitLab CI to run `scss-lint` without having to put together the full GitLab application? Seeing as it's just static analysis, it seems like a waste of time/resources.

/cc @jschatz1 @rspeicher

See merge request !3069</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

CSS style guide

Working towards what was discussed in #13552, this adds the [SCSS Linter gem](https://github.com/brigade/scss-lint) for style guide conformity in CI.

TODO:
- [x] Agree on and write SCSS Style Guide Documentation.
- [x] Document the `scss-lint` config file.
- [x] Figure out how best to run this in CI, right now it's taking longer than I would think it should.
- [x] Use CSSComb for auto-correction (Maybe just include a CSSComb config file and have developers run the node package manually if they're interested in using it?).

My logic for not using CSSComb in the first place is that, AFAIK, we don't currently require Node/NPM, even in the dev environment. Maybe I'm wrong about that? `scss-lint` is a Ruby implementation of a similar concept, but it doesn't include autocorrect.

Is there a way we can run get GitLab CI to run `scss-lint` without having to put together the full GitLab application? Seeing as it's just static analysis, it seems like a waste of time/resources.

/cc @jschatz1 @rspeicher

See merge request !3069</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'if-statement-syntax-fix' into 'master'</title>
<updated>2016-03-15T16:45:40+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-03-15T16:45:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0602091f0cdebbc3183732dee78c38f89b4b7d01'/>
<id>0602091f0cdebbc3183732dee78c38f89b4b7d01</id>
<content type='text'>

Remove parentheses from if statement

Otherwise Rubocop will give a warning after we upgrade it.

As discussed in !3197.

[ci skip]

See merge request !3231</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Remove parentheses from if statement

Otherwise Rubocop will give a warning after we upgrade it.

As discussed in !3197.

[ci skip]

See merge request !3231</pre>
</div>
</content>
</entry>
<entry>
<title>Remove parentheses from if statement</title>
<updated>2016-03-15T16:42:16+00:00</updated>
<author>
<name>connorshea</name>
<email>connor.james.shea@gmail.com</email>
</author>
<published>2016-03-15T16:42:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0129f346ee7fe0d89c0b80b04afebe2c4faf4dc9'/>
<id>0129f346ee7fe0d89c0b80b04afebe2c4faf4dc9</id>
<content type='text'>
Otherwise Rubocop will give a warning.

As mentioned in !3197.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Otherwise Rubocop will give a warning.

As mentioned in !3197.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-activerecord-join-stupidity' into 'master'</title>
<updated>2016-03-15T16:25:02+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-03-15T16:25:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=178c80a561fa10a157bae6e5d4682b232ae727c7'/>
<id>178c80a561fa10a157bae6e5d4682b232ae727c7</id>
<content type='text'>

Ignore eager loading in Project.search UNION

This fixes issues such as filtering groups by names on pages such as
https://gitlab.com/dashboard/groups.

See merge request !3229</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Ignore eager loading in Project.search UNION

This fixes issues such as filtering groups by names on pages such as
https://gitlab.com/dashboard/groups.

See merge request !3229</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'todos-title-attr' into 'master'</title>
<updated>2016-03-15T16:23:15+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-03-15T16:23:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=09494ff413b342884f8df9d8385a71b6ec820688'/>
<id>09494ff413b342884f8df9d8385a71b6ec820688</id>
<content type='text'>

Set link title for todos. Closes #14042

See merge request !3161</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Set link title for todos. Closes #14042

See merge request !3161</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'external-issue-tracker' into 'master'</title>
<updated>2016-03-15T16:16:39+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-15T16:16:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b5a47c0a38691322be4fd90b0eed12e669436295'/>
<id>b5a47c0a38691322be4fd90b0eed12e669436295</id>
<content type='text'>

See merge request !3218</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

See merge request !3218</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'patch-1' into 'master'</title>
<updated>2016-03-15T16:13:49+00:00</updated>
<author>
<name>Jeroen van Baarsen</name>
<email>jeroenvanbaarsen@gmail.com</email>
</author>
<published>2016-03-15T16:13:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=07325005951734fb448842104a50837cf76f3cf8'/>
<id>07325005951734fb448842104a50837cf76f3cf8</id>
<content type='text'>

Fix typo in Ruby CI test and deploy example

[skip ci]

See merge request !3201</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix typo in Ruby CI test and deploy example

[skip ci]

See merge request !3201</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'revert-avatar-cropping' into 'master'</title>
<updated>2016-03-15T15:53:42+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-03-15T15:53:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c1f6f8cfcc30597ca3f9bea8ab4431049ed1bd6'/>
<id>5c1f6f8cfcc30597ca3f9bea8ab4431049ed1bd6</id>
<content type='text'>

Revert the avatar cropping feature

Reverts !2951 since the added 'mini_magick' dependency should be replaced by client-side croppping

See merge request !3223</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Revert the avatar cropping feature

Reverts !2951 since the added 'mini_magick' dependency should be replaced by client-side croppping

See merge request !3223</pre>
</div>
</content>
</entry>
</feed>
