<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch grapify-projects-api</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Grapify the projects API</title>
<updated>2016-11-28T20:01:43+00:00</updated>
<author>
<name>Robert Schilling</name>
<email>rschilling@student.tugraz.at</email>
</author>
<published>2016-11-09T14:51:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7c607a55ab339293b0e67eeb33439d5407e22aad'/>
<id>7c607a55ab339293b0e67eeb33439d5407e22aad</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'dynamic-build-fixture' into 'master'</title>
<updated>2016-11-28T16:43:46+00:00</updated>
<author>
<name>Alfredo Sumaran</name>
<email>alfredo@gitlab.com</email>
</author>
<published>2016-11-28T16:43:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c54827961a6ecefc6cb3361b3978d169e29b5e36'/>
<id>c54827961a6ecefc6cb3361b3978d169e29b5e36</id>
<content type='text'>

Create dynamic fixture for build_spec

## What does this MR do?

Replace `spec/javascripts/fixtures/build.html.haml` by a dynamically created fixture (using `rake teaspoon:fixtures`).

## Why was this MR needed?

The existing fixture was not representing the real page. 

## What are the relevant issue numbers?

#24614 would have been avoided

following !6059

See merge request !7589</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Create dynamic fixture for build_spec

## What does this MR do?

Replace `spec/javascripts/fixtures/build.html.haml` by a dynamically created fixture (using `rake teaspoon:fixtures`).

## Why was this MR needed?

The existing fixture was not representing the real page. 

## What are the relevant issue numbers?

#24614 would have been avoided

following !6059

See merge request !7589</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '24813-project-members-with-developer-access-can-no-longer-create-tags' into 'master'</title>
<updated>2016-11-28T16:02:46+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2016-11-28T16:02:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cfb4d65f84898f433771e2deafc36d597db9b8df'/>
<id>cfb4d65f84898f433771e2deafc36d597db9b8df</id>
<content type='text'>

Create tag after running pre-hooks and pass updated SHA to post-hooks

Closes #24813

See merge request !7700</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Create tag after running pre-hooks and pass updated SHA to post-hooks

Closes #24813

See merge request !7700</pre>
</div>
</content>
</entry>
<entry>
<title>Pass tag SHA to post-receive hook when tag is created via UI</title>
<updated>2016-11-28T14:04:51+00:00</updated>
<author>
<name>Adam Niedzielski</name>
<email>adamsunday@gmail.com</email>
</author>
<published>2016-11-28T14:04:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cf58271e11f6704523be5211ecfb2d02ae1091fe'/>
<id>cf58271e11f6704523be5211ecfb2d02ae1091fe</id>
<content type='text'>
We only know the tag SHA after we create the tag.
This means that we pass a different value to the hooks that happen before
creating the tag, and a different value to the hooks that happen after
creating the tag.

This is not an ideal situation, but it is a trade-off we decided to
make. For discussion of the alternatives please refer to
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7700#note_18982873

"pre-receive" and "update" hooks always get the SHA of the commit
that the tag points to. "post-receive" gets the tag SHA if it is
an annotated tag or the commit SHA if it is an lightweight tag.
Currently we always create annotated tags if UI is used.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We only know the tag SHA after we create the tag.
This means that we pass a different value to the hooks that happen before
creating the tag, and a different value to the hooks that happen after
creating the tag.

This is not an ideal situation, but it is a trade-off we decided to
make. For discussion of the alternatives please refer to
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7700#note_18982873

"pre-receive" and "update" hooks always get the SHA of the commit
that the tag points to. "post-receive" gets the tag SHA if it is
an annotated tag or the commit SHA if it is an lightweight tag.
Currently we always create annotated tags if UI is used.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '24860-actionview-template-error-undefined-method-size-for-nil-nilclass' into 'master'</title>
<updated>2016-11-28T12:44:10+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2016-11-28T12:44:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e6d31ce31ff9d408503ea7b0ba1e6faad7cd5290'/>
<id>e6d31ce31ff9d408503ea7b0ba1e6faad7cd5290</id>
<content type='text'>

Prevent error when submitting a merge request and pipeline is not defined

Closes #24860

See merge request !7707</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Prevent error when submitting a merge request and pipeline is not defined

Closes #24860

See merge request !7707</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Pass correct tag target to post-receive hook when creating tag via UI"</title>
<updated>2016-11-28T12:00:42+00:00</updated>
<author>
<name>Adam Niedzielski</name>
<email>adamsunday@gmail.com</email>
</author>
<published>2016-11-28T12:00:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9e6cdc64741583ed0db74485892c1970ff960eab'/>
<id>9e6cdc64741583ed0db74485892c1970ff960eab</id>
<content type='text'>
This reverts commit ae51774bc45d2e15ccc61b01a30d1b588f179f85.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit ae51774bc45d2e15ccc61b01a30d1b588f179f85.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'issuable_filters_present-refactor' into 'master'</title>
<updated>2016-11-28T11:37:53+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-11-28T11:37:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=333e83a2ef29a0fce10b3e1b0110cd30685eea15'/>
<id>333e83a2ef29a0fce10b3e1b0110cd30685eea15</id>
<content type='text'>

Refactor issuable_filters_present to reduce duplications

See https://gitlab.com/gitlab-org/gitlab-ce/issues/23546

See merge request !7776</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Refactor issuable_filters_present to reduce duplications

See https://gitlab.com/gitlab-org/gitlab-ce/issues/23546

See merge request !7776</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'rs-phantomjs-disable-images' into 'master'</title>
<updated>2016-11-28T11:37:21+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-11-28T11:37:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=13c0039891fb33a6f3cf88e9c62e1d493a5f75da'/>
<id>13c0039891fb33a6f3cf88e9c62e1d493a5f75da</id>
<content type='text'>

Pass `--load-images=no` to PhantomJS via Capybara/Poltergeist

We were unintentionally hitting `gravatar.com` whenever a test that used
Poltergeist was run. This was certainly wasting their resources and
slowing down our tests even further, for no reason.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24899

See merge request !7781</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Pass `--load-images=no` to PhantomJS via Capybara/Poltergeist

We were unintentionally hitting `gravatar.com` whenever a test that used
Poltergeist was run. This was certainly wasting their resources and
slowing down our tests even further, for no reason.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24899

See merge request !7781</pre>
</div>
</content>
</entry>
<entry>
<title>Prevent error when submitting a merge request and pipeline is not defined</title>
<updated>2016-11-28T11:03:59+00:00</updated>
<author>
<name>Adam Niedzielski</name>
<email>adamsunday@gmail.com</email>
</author>
<published>2016-11-28T11:03:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d9a2093e7e6b0d532131b18dc57c240f5b4a7c55'/>
<id>d9a2093e7e6b0d532131b18dc57c240f5b4a7c55</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'rs-project-security-spec-speed' into 'master'</title>
<updated>2016-11-28T10:42:21+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-11-28T10:42:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6ea0b8d56322108788727a2f4ad27843013d43f1'/>
<id>6ea0b8d56322108788727a2f4ad27843013d43f1</id>
<content type='text'>

Speed up Project security access specs

Prior, every single test was creating four `ProjectMember` objects, each
of which created one `User` record, even though each test only used
_one_ of those Users, if any.

Now each test only creates the single user record it needs, if it needs
one. This shaves minutes off of each spec file changed here.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24899

See merge request !7779</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Speed up Project security access specs

Prior, every single test was creating four `ProjectMember` objects, each
of which created one `User` record, even though each test only used
_one_ of those Users, if any.

Now each test only creates the single user record it needs, if it needs
one. This shaves minutes off of each spec file changed here.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24899

See merge request !7779</pre>
</div>
</content>
</entry>
</feed>
