<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch frozen_string_spec_support</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Frozen string cannot change encoding</title>
<updated>2019-07-25T12:13:25+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-07-25T09:33:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d4ef3be35b63f3ef022e21d6ba56ffe41b8f192c'/>
<id>d4ef3be35b63f3ef022e21d6ba56ffe41b8f192c</id>
<content type='text'>
This was shown in specs but surely this will be happening in application
code as well if this method is passes a frozen string.

We were also trying to force_encode a OmniAuth::AuthHash which had the
very confusing behaviour of returning nil when it was sent a method that
it did not define. Fix that by only force_encoding a String.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was shown in specs but surely this will be happening in application
code as well if this method is passes a frozen string.

We were also trying to force_encode a OmniAuth::AuthHash which had the
very confusing behaviour of returning nil when it was sent a method that
it did not define. Fix that by only force_encoding a String.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix frozen string error</title>
<updated>2019-07-25T09:33:18+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-07-25T08:20:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=595a092a083a9a16cad12dc663cad1a674551a51'/>
<id>595a092a083a9a16cad12dc663cad1a674551a51</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add frozen_string_literal to spec/support</title>
<updated>2019-07-25T05:33:34+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-07-25T05:27:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f0391c2517879bbb73702ccafd5e02bf25b40eec'/>
<id>f0391c2517879bbb73702ccafd5e02bf25b40eec</id>
<content type='text'>
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '64746-Commit-authors-avatar-sretched-in-commit-view-if-no-image-is-loaded' into 'master'</title>
<updated>2019-07-24T21:28:27+00:00</updated>
<author>
<name>Paul Slaughter</name>
<email>pslaughter@gitlab.com</email>
</author>
<published>2019-07-24T21:28:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7fa0c7662b88efa72d29087a273f0b6c1e484b3e'/>
<id>7fa0c7662b88efa72d29087a273f0b6c1e484b3e</id>
<content type='text'>
Changed `author_avatar` to inline-block class

Closes #64746

See merge request gitlab-org/gitlab-ce!30904</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Changed `author_avatar` to inline-block class

Closes #64746

See merge request gitlab-org/gitlab-ce!30904</pre>
</div>
</content>
</entry>
<entry>
<title>Changed `author_avatar` to inline-block class</title>
<updated>2019-07-24T21:28:26+00:00</updated>
<author>
<name>Marc Schwede</name>
<email>git@schwedenmut.de</email>
</author>
<published>2019-07-24T21:28:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2246bb7d22498565d77c4b8fa05f50b27db09ec8'/>
<id>2246bb7d22498565d77c4b8fa05f50b27db09ec8</id>
<content type='text'>
Fixes #64746
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes #64746
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '64763-fix-tags-page-layout' into 'master'</title>
<updated>2019-07-24T21:27:02+00:00</updated>
<author>
<name>Fatih Acet</name>
<email>acetfatih@gmail.com</email>
</author>
<published>2019-07-24T21:27:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7595e3ba59680f56e51c8d41579106af33af2f0e'/>
<id>7595e3ba59680f56e51c8d41579106af33af2f0e</id>
<content type='text'>
Fix tags page layout

See merge request gitlab-org/gitlab-ce!30951</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix tags page layout

See merge request gitlab-org/gitlab-ce!30951</pre>
</div>
</content>
</entry>
<entry>
<title>Fix tags page layout</title>
<updated>2019-07-24T21:27:01+00:00</updated>
<author>
<name>André Luís</name>
<email>me@andr3.net</email>
</author>
<published>2019-07-24T21:27:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ff209f73a00a2415b182b8eb55401a7313939d8a'/>
<id>ff209f73a00a2415b182b8eb55401a7313939d8a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-enable-rubocop-hash-search' into 'master'</title>
<updated>2019-07-24T20:39:34+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2019-07-24T20:39:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=35ec674ee69a04d771ed82eeb205c3cd527e4112'/>
<id>35ec674ee69a04d771ed82eeb205c3cd527e4112</id>
<content type='text'>
Enable Rubocop Performance/InefficientHashSearch

Closes #64975

See merge request gitlab-org/gitlab-ce!31117</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enable Rubocop Performance/InefficientHashSearch

Closes #64975

See merge request gitlab-org/gitlab-ce!31117</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'ce-docker_image_replication-event-generation' into 'master'</title>
<updated>2019-07-24T20:11:49+00:00</updated>
<author>
<name>Douglas Barbosa Alexandre</name>
<email>dbalexandre@gmail.com</email>
</author>
<published>2019-07-24T20:11:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=feb07ce08e755786ec869f31eef57c67d70eecb7'/>
<id>feb07ce08e755786ec869f31eef57c67d70eecb7</id>
<content type='text'>
Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14597

See merge request gitlab-org/gitlab-ce!30520</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14597

See merge request gitlab-org/gitlab-ce!30520</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '48717-rate-limit-raw-controller-show' into 'master'</title>
<updated>2019-07-24T19:49:31+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-07-24T19:49:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6dcde68b6dbce7190ef78e7fef280b634b549450'/>
<id>6dcde68b6dbce7190ef78e7fef280b634b549450</id>
<content type='text'>
Add RateLimiter to RawController

See merge request gitlab-org/gitlab-ce!30635</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add RateLimiter to RawController

See merge request gitlab-org/gitlab-ce!30635</pre>
</div>
</content>
</entry>
</feed>
