<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch fix-migration</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Drop existing trigger before creating new one</title>
<updated>2019-08-24T02:20:58+00:00</updated>
<author>
<name>rpereira2</name>
<email>rpereira@gitlab.com</email>
</author>
<published>2019-08-23T13:02:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c09aa0ddcc53641a8f15722b8405cb372688d73e'/>
<id>c09aa0ddcc53641a8f15722b8405cb372688d73e</id>
<content type='text'>
- When renaming a column concurrently, drop any existing trigger before
attempting to create a new one.

When running migration specs multiple times (as it happens during
local development), the down method of previous migrations are called.
If any of the called methods contains a call to
rename_column_concurrently, a trigger will be created and not removed.
So, the next time a migration spec is run, if the same down method is
executed again, it will cause an error when attempting to create the
trigger (since it already exists). Dropping the trigger if it already
exists will prevent this problem.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- When renaming a column concurrently, drop any existing trigger before
attempting to create a new one.

When running migration specs multiple times (as it happens during
local development), the down method of previous migrations are called.
If any of the called methods contains a call to
rename_column_concurrently, a trigger will be created and not removed.
So, the next time a migration spec is run, if the same down method is
executed again, it will cause an error when attempting to create the
trigger (since it already exists). Dropping the trigger if it already
exists will prevent this problem.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '56883-migration' into 'master'</title>
<updated>2019-08-23T22:27:43+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2019-08-23T22:27:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=523c619fe41191e32c852dae972958302364c3ca'/>
<id>523c619fe41191e32c852dae972958302364c3ca</id>
<content type='text'>
Add migration to execute SelfMonitoring::Project::CreateService

See merge request gitlab-org/gitlab-ce!31389</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add migration to execute SelfMonitoring::Project::CreateService

See merge request gitlab-org/gitlab-ce!31389</pre>
</div>
</content>
</entry>
<entry>
<title>Add a link to docs in project description</title>
<updated>2019-08-23T22:27:41+00:00</updated>
<author>
<name>Reuben Pereira</name>
<email>rpereira@gitlab.com</email>
</author>
<published>2019-08-23T22:27:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2515c0cd44db9e14ebea9a9218b05853b9afcaad'/>
<id>2515c0cd44db9e14ebea9a9218b05853b9afcaad</id>
<content type='text'>
Add to the service and migration both.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add to the service and migration both.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fe-fix-issuable-sidebar-icon-of-notification-disabled' into 'master'</title>
<updated>2019-08-23T22:01:11+00:00</updated>
<author>
<name>Mike Greiling</name>
<email>mike@pixelcog.com</email>
</author>
<published>2019-08-23T22:01:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a93612aa5fab7d70f0b6165856402ac53ab18faf'/>
<id>a93612aa5fab7d70f0b6165856402ac53ab18faf</id>
<content type='text'>
Fix issuable sidebar icon of notification disabled

See merge request gitlab-org/gitlab-ce!32134</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix issuable sidebar icon of notification disabled

See merge request gitlab-org/gitlab-ce!32134</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'docs/fix-template-link' into 'master'</title>
<updated>2019-08-23T21:37:03+00:00</updated>
<author>
<name>Mike Lewis</name>
<email>mlewis@gitlab.com</email>
</author>
<published>2019-08-23T21:37:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4c8a656f7b89314011825931a4ecc682ab78c088'/>
<id>4c8a656f7b89314011825931a4ecc682ab78c088</id>
<content type='text'>
Fix link to issue template

See merge request gitlab-org/gitlab-ce!32144</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix link to issue template

See merge request gitlab-org/gitlab-ce!32144</pre>
</div>
</content>
</entry>
<entry>
<title>Fix link to issue template</title>
<updated>2019-08-23T21:37:02+00:00</updated>
<author>
<name>Achilleas Pipinellis</name>
<email>axil@gitlab.com</email>
</author>
<published>2019-08-23T21:37:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6308a450c70e9e6d9804cdd9d346b713adefeb95'/>
<id>6308a450c70e9e6d9804cdd9d346b713adefeb95</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '64505-add-rubocop-cop-to-enforce-string-length-on-migrations' into 'master'</title>
<updated>2019-08-23T21:36:14+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-23T21:36:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d02226dad5a5f44f8a36f217533d21495e4a58da'/>
<id>d02226dad5a5f44f8a36f217533d21495e4a58da</id>
<content type='text'>
Adds cop to enforce string limits on migrations

See merge request gitlab-org/gitlab-ce!31433</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds cop to enforce string limits on migrations

See merge request gitlab-org/gitlab-ce!31433</pre>
</div>
</content>
</entry>
<entry>
<title>Adds cop to enforce string limits on migrations</title>
<updated>2019-08-23T21:36:12+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2019-08-23T21:36:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4706352416005962ccb34bad1c3acc5d7479523c'/>
<id>4706352416005962ccb34bad1c3acc5d7479523c</id>
<content type='text'>
This cop will analyze migrations that add columns with string, and
report an offense if the string has no limit enforced

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This cop will analyze migrations that add columns with string, and
report an offense if the string has no limit enforced

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '55999-misleading-pipeline-tooltip-messages-and-misleading-ci-status-icons-on-simple-commits' into 'master'</title>
<updated>2019-08-23T21:28:47+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2019-08-23T21:28:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b8dec7ecb43d3825f994136ca68e88aada832218'/>
<id>b8dec7ecb43d3825f994136ca68e88aada832218</id>
<content type='text'>
Change misleading pipeline status tooltip

See merge request gitlab-org/gitlab-ce!31861</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change misleading pipeline status tooltip

See merge request gitlab-org/gitlab-ce!31861</pre>
</div>
</content>
</entry>
<entry>
<title>Change misleading pipeline status tooltip</title>
<updated>2019-08-23T21:28:46+00:00</updated>
<author>
<name>Scott Hampton</name>
<email>shampton@gitlab.com</email>
</author>
<published>2019-08-23T21:28:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f093ceb4a0b15420cfe64fa9d97e73531b5fb35c'/>
<id>f093ceb4a0b15420cfe64fa9d97e73531b5fb35c</id>
<content type='text'>
Some pipeline status icon tooltips were showing
"Commit: ..." which customers found to be
misleading since it was not the commit that was
failing but the pipeline.

We are changing all status icon tooltips to say
"Pipeline: ..." instead of "Commit: ..." now.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some pipeline status icon tooltips were showing
"Commit: ..." which customers found to be
misleading since it was not the commit that was
failing but the pipeline.

We are changing all status icon tooltips to say
"Pipeline: ..." instead of "Commit: ..." now.
</pre>
</div>
</content>
</entry>
</feed>
