<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch fix-capitalization</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix capitalization in notification to be consistent with other notifications.</title>
<updated>2016-10-25T18:41:01+00:00</updated>
<author>
<name>Matt Lee</name>
<email>mattl@gitlab.com</email>
</author>
<published>2016-10-25T18:41:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b45eae2d492b44e0ee55bf13887f932214277390'/>
<id>b45eae2d492b44e0ee55bf13887f932214277390</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Updated logo from @luke</title>
<updated>2016-10-17T14:55:35+00:00</updated>
<author>
<name>Matt Lee</name>
<email>mattl@gitlab.com</email>
</author>
<published>2016-10-17T14:55:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3fe36c5b5356ee76edc7010e4d91073b2063495a'/>
<id>3fe36c5b5356ee76edc7010e4d91073b2063495a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-pipeline-metrics-failure' into 'master'</title>
<updated>2016-10-17T13:41:03+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2016-10-17T13:41:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=77507df6030dad9e317e092c70003d4c85d8f889'/>
<id>77507df6030dad9e317e092c70003d4c85d8f889</id>
<content type='text'>

Fix broken specs on MySQL

## What does this MR do?
Fixes broken master after https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6896

See merge request !6935</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix broken specs on MySQL

## What does this MR do?
Fixes broken master after https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6896

See merge request !6935</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix_test_env' into 'master'</title>
<updated>2016-10-17T13:08:40+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2016-10-17T13:08:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d2591df1642654b2d211ddbb3dee1edc1592bd98'/>
<id>d2591df1642654b2d211ddbb3dee1edc1592bd98</id>
<content type='text'>

Fix Test Env (proper error handling when gitlab-shell is not clonned)

## What does this MR do?

If we were not able to clone gitlab-shell we have to stop all test suite, for now we run it regardless we cloned it or not.

## Why was this MR needed?

To not confuse developers when build is red, to get fasts feedback, to save resources and time.

See merge request !6933</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix Test Env (proper error handling when gitlab-shell is not clonned)

## What does this MR do?

If we were not able to clone gitlab-shell we have to stop all test suite, for now we run it regardless we cloned it or not.

## Why was this MR needed?

To not confuse developers when build is red, to get fasts feedback, to save resources and time.

See merge request !6933</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'safari-is-baNaNas' into 'master'</title>
<updated>2016-10-17T12:51:09+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-10-17T12:51:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0f5c31d59b694a9f211500b6be160918410af684'/>
<id>0f5c31d59b694a9f211500b6be160918410af684</id>
<content type='text'>

Fix Safari displaying NaN for selected due date

## What does this MR do?

1. Stops using `Date.parse` to parse selected due dates. 
2. Refactors DueDateSelectors to be more maintainable and readable

## Are there points in the code the reviewer needs to double check?

**To review the actual fix, look here:** https://gitlab.com/gitlab-org/gitlab-ce/commit/4ad43ac3a12902d7ea01dc09f8a361b01c21a0ee. It would be difficult to pick out from the overall diff. 

## Why was this MR needed?

In Safari, the due date selector was displaying 'NaN' when a date is selected, which was being returned by `Date.parse`. Because `Date.parse` is implemented differently across browsers it's generally recommended to favor implicit Date parsing with the `Date` constructor. For more background on this, [see MDN on Date.parse](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Date/parse).

Also, the code for DueDateSelector was pretty messy, and its logic was very tightly coupled, so I refactored it. None of the basic logic changed, I just broke it up into smaller pieces and made it more OO. 

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/22984

See merge request !6797</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix Safari displaying NaN for selected due date

## What does this MR do?

1. Stops using `Date.parse` to parse selected due dates. 
2. Refactors DueDateSelectors to be more maintainable and readable

## Are there points in the code the reviewer needs to double check?

**To review the actual fix, look here:** https://gitlab.com/gitlab-org/gitlab-ce/commit/4ad43ac3a12902d7ea01dc09f8a361b01c21a0ee. It would be difficult to pick out from the overall diff. 

## Why was this MR needed?

In Safari, the due date selector was displaying 'NaN' when a date is selected, which was being returned by `Date.parse`. Because `Date.parse` is implemented differently across browsers it's generally recommended to favor implicit Date parsing with the `Date` constructor. For more background on this, [see MDN on Date.parse](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Date/parse).

Also, the code for DueDateSelector was pretty messy, and its logic was very tightly coupled, so I refactored it. None of the basic logic changed, I just broke it up into smaller pieces and made it more OO. 

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/22984

See merge request !6797</pre>
</div>
</content>
</entry>
<entry>
<title>Fix broken specs on MySQL after https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6896</title>
<updated>2016-10-17T12:31:43+00:00</updated>
<author>
<name>Kamil Trzcinski</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2016-10-17T12:31:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=009da2fc80924778ba61c6363b6e12d7daf1fa75'/>
<id>009da2fc80924778ba61c6363b6e12d7daf1fa75</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Test Env (proper error handling when gitlab-shell is not clonned)</title>
<updated>2016-10-17T11:41:29+00:00</updated>
<author>
<name>Valery Sizov</name>
<email>valery@gitlab.com</email>
</author>
<published>2016-10-17T11:10:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7762d8f5a350c92295fc11cdffa703b3cb498974'/>
<id>7762d8f5a350c92295fc11cdffa703b3cb498974</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'dz-fix-spinach-mr' into 'master'</title>
<updated>2016-10-17T11:27:39+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2016-10-17T11:27:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c9a54d65f87ab1f20b2e8836b33ccd25df85d1a'/>
<id>5c9a54d65f87ab1f20b2e8836b33ccd25df85d1a</id>
<content type='text'>

Fix randomly crashing spinach test for merge request

For https://gitlab.com/gitlab-org/gitlab-ce/issues/23378

See merge request !6932</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix randomly crashing spinach test for merge request

For https://gitlab.com/gitlab-org/gitlab-ce/issues/23378

See merge request !6932</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-spinach-atom-feed-failure-due-to-carriage-returns' into 'master'</title>
<updated>2016-10-17T11:22:36+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2016-10-17T11:22:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d00d3e28716133c87ab2594b2c85dae29c2c0c50'/>
<id>d00d3e28716133c87ab2594b2c85dae29c2c0c50</id>
<content type='text'>

Fix atom feed spinach failure

## What does this MR do?

Replaces all carriage returns in the expected commit description.

Is a partial fix to...

&gt; spinach 5 10 https://gitlab.com/gitlab-org/gitlab-ce/builds/5132637 - partial fix in !6910

As you can see, the other half of the fix to this build is in !6910.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

Failed spinach tests

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

See merge request !6922</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix atom feed spinach failure

## What does this MR do?

Replaces all carriage returns in the expected commit description.

Is a partial fix to...

&gt; spinach 5 10 https://gitlab.com/gitlab-org/gitlab-ce/builds/5132637 - partial fix in !6910

As you can see, the other half of the fix to this build is in !6910.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

Failed spinach tests

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

See merge request !6922</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'add-pipeline-metrics-worker' into 'master'</title>
<updated>2016-10-17T11:03:51+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2016-10-17T11:03:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3de4a15050777e0e6762b7e9e453cba08bbaa9b1'/>
<id>3de4a15050777e0e6762b7e9e453cba08bbaa9b1</id>
<content type='text'>

Add Pipeline metrics worker

## What does this MR do?
Creating a new Merge Request metrics is time consuming, because we need to access repository.

This makes this operation asynchronous, thus non-blocking for updating pipeline.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

See merge request !6896</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Add Pipeline metrics worker

## What does this MR do?
Creating a new Merge Request metrics is time consuming, because we need to access repository.

This makes this operation asynchronous, thus non-blocking for updating pipeline.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

See merge request !6896</pre>
</div>
</content>
</entry>
</feed>
