delta/gitlab/gitlab-ce.git, branch enable-shared-runners-with-admins

Disable Metrics/CyclomaticComplexity for Ability.allowed

2016-06-30T13:38:29+00:00

There's little point to cut that down.

Use warning for locked runners:

2016-06-30T13:26:50+00:00

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4961#note_12794221

Use Ability to check pre-requisite. Change back to 403 because:

2016-06-29T11:04:06+00:00

If we're using `can?` it would look weird to use 409

Admins should be able to assign locked runners as well

2016-06-28T12:15:50+00:00

They're projects, so we shouldn't show lock icon

2016-06-28T12:10:42+00:00

Allow admins to assign locked runners:

2016-06-28T11:55:12+00:00

And show information about locked status.

Help! This looks bad :o

Use 409 to indicate that interface might be outdated

2016-06-28T11:54:18+00:00

Because invalid actions shouldn't be shown on the page.

Rename to assignable runner for shared examples:

2016-06-28T10:33:25+00:00

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4961#note_12738607

Admin should be able to turn shared runners into specific ones:

2016-06-28T05:46:47+00:00

The regression was introduced by:

https://gitlab.com/gitlab-org/gitlab-ce/commit/1b8f52d9206bdf19c0dde04505c4c0b1cf46cfbe

I did that because there's a test specifying that a shared runner cannot
be enabled, in the API. So I assume that is the case for non-admin, but
admins should be able to do so anyway.

Also added a test to make sure this won't regress again.

Closes #19039

Merge remote-tracking branch 'dev/master'

2016-06-27T22:39:42+00:00