<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch compare-code-view</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Apply diff view cookie on compare</title>
<updated>2016-07-15T18:42:18+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2016-07-07T11:36:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a9d5b07769b56286903534cde0fcf8e6063c8eb0'/>
<id>a9d5b07769b56286903534cde0fcf8e6063c8eb0</id>
<content type='text'>
Closes #19573
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes #19573
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'revert-lock-for-issuable' into 'master'</title>
<updated>2016-07-15T18:29:50+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-07-15T18:29:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d4677353b84681bd73f321a0b04bb7eba32dbc9c'/>
<id>d4677353b84681bd73f321a0b04bb7eba32dbc9c</id>
<content type='text'>

Revert "Optimistic locking for Issue and Merge Requests"

The migration to add `lock_version` in !5146 to every issue and merge request takes too long on GitLab.com since it has to add a default value of 0 to every row. Unfortunately, Rails 4.2 doesn't work properly if the value is left as `nil`; anything using optimistic locking cannot be edited. 

This bug was fixed in Rails 5.0 via this commit: https://github.com/rails/rails/commit/13772bfa49325a8dc26410d2dcb555665a320f92. I suggest we revert this change for now, and when we upgrade to Rails 5.0 we can reintroduce this feature.

See merge request !5245</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Revert "Optimistic locking for Issue and Merge Requests"

The migration to add `lock_version` in !5146 to every issue and merge request takes too long on GitLab.com since it has to add a default value of 0 to every row. Unfortunately, Rails 4.2 doesn't work properly if the value is left as `nil`; anything using optimistic locking cannot be edited. 

This bug was fixed in Rails 5.0 via this commit: https://github.com/rails/rails/commit/13772bfa49325a8dc26410d2dcb555665a320f92. I suggest we revert this change for now, and when we upgrade to Rails 5.0 we can reintroduce this feature.

See merge request !5245</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'update-rubocop' into 'master'</title>
<updated>2016-07-15T17:19:38+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-07-15T17:19:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dfea11e1e791d0343ccc7d560f03710f5c1e2a98'/>
<id>dfea11e1e791d0343ccc7d560f03710f5c1e2a98</id>
<content type='text'>

Update rubocop to 0.41.2

Adds a couple of cops to the TODO files, but I wanted [a specific cop](https://github.com/bbatsov/rubocop/pull/3135/files) which just had about 65 offences, so Ill do that later.

See merge request !4999</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Update rubocop to 0.41.2

Adds a couple of cops to the TODO files, but I wanted [a specific cop](https://github.com/bbatsov/rubocop/pull/3135/files) which just had about 65 offences, so Ill do that later.

See merge request !4999</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'disable-statement-timeout' into 'master'</title>
<updated>2016-07-15T14:51:20+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-07-15T14:51:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8b7932c21951de172d531ab8a3e9506c98db7483'/>
<id>8b7932c21951de172d531ab8a3e9506c98db7483</id>
<content type='text'>

Disable PostgreSQL statement timeout during migrations

Long-running migrations may take more than the timeout allowed by the database. Disable the session's statement timeout to ensure migrations don't get killed prematurely.

See merge request !5263</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Disable PostgreSQL statement timeout during migrations

Long-running migrations may take more than the timeout allowed by the database. Disable the session's statement timeout to ensure migrations don't get killed prematurely.

See merge request !5263</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix/import-issues-last-updated' into 'master'</title>
<updated>2016-07-15T14:44:04+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-07-15T14:44:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7cb51ba5728626433a2620940f969419e1daa895'/>
<id>7cb51ba5728626433a2620940f969419e1daa895</id>
<content type='text'>

Fix issues last update timestamp not preserved after importing a project

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/19689 and https://gitlab.com/gitlab-org/gitlab-ce/issues/19792 (similar, but not the same)

Now `updated_at` should be the time from the original project.

See merge request !5253</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix issues last update timestamp not preserved after importing a project

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/19689 and https://gitlab.com/gitlab-org/gitlab-ce/issues/19792 (similar, but not the same)

Now `updated_at` should be the time from the original project.

See merge request !5253</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'collapse-diffs-more' into 'master'</title>
<updated>2016-07-15T13:49:10+00:00</updated>
<author>
<name>Fatih Acet</name>
<email>acetfatih@gmail.com</email>
</author>
<published>2016-07-15T13:49:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=50abec8ca36c5cbdb1f7878b3ac956211fc67d3d'/>
<id>50abec8ca36c5cbdb1f7878b3ac956211fc67d3d</id>
<content type='text'>

Reduce padding on collapsed diff message

## What does this MR do?

Reduce the padding on the collapsed diff message so it takes up less space.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

Collapsed diffs took up too much space before.

## Screenshots (if relevant)

Before:

![image](/uploads/62c6fe19439bc3bc91bde83df72e7004/image.png)

After:

![image](/uploads/ec89230065c37fc4022d949d1233a90d/image.png)

## Does this MR meet the acceptance criteria?

- ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~
- ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- ~~API support added~~
- Tests
  - ~~Added for this feature/bug~~
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5256</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Reduce padding on collapsed diff message

## What does this MR do?

Reduce the padding on the collapsed diff message so it takes up less space.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

Collapsed diffs took up too much space before.

## Screenshots (if relevant)

Before:

![image](/uploads/62c6fe19439bc3bc91bde83df72e7004/image.png)

After:

![image](/uploads/ec89230065c37fc4022d949d1233a90d/image.png)

## Does this MR meet the acceptance criteria?

- ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~
- ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- ~~API support added~~
- Tests
  - ~~Added for this feature/bug~~
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5256</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'issuable-sidebar-collapsed-tooltip' into 'master'</title>
<updated>2016-07-15T13:40:13+00:00</updated>
<author>
<name>Fatih Acet</name>
<email>acetfatih@gmail.com</email>
</author>
<published>2016-07-15T13:40:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=877c77ccdb4af63e90a17c712ad2050296d198d4'/>
<id>877c77ccdb4af63e90a17c712ad2050296d198d4</id>
<content type='text'>

Changed collapsed assignee tooltip to users name

## What does this MR do?

- Changes the collapsed assignee tooltip the users name rather than the username
- Updates the tooltip after updating the assignee

## What are the relevant issue numbers?

Closes #19280, #19281

## Screenshots (if relevant)

![Screen_Shot_2016-06-28_at_17.55.52](/uploads/e6ccc1703f59966c978e731a841aabdc/Screen_Shot_2016-06-28_at_17.55.52.png)

See merge request !4976</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Changed collapsed assignee tooltip to users name

## What does this MR do?

- Changes the collapsed assignee tooltip the users name rather than the username
- Updates the tooltip after updating the assignee

## What are the relevant issue numbers?

Closes #19280, #19281

## Screenshots (if relevant)

![Screen_Shot_2016-06-28_at_17.55.52](/uploads/e6ccc1703f59966c978e731a841aabdc/Screen_Shot_2016-06-28_at_17.55.52.png)

See merge request !4976</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-navbar-icon' into 'master'</title>
<updated>2016-07-15T13:37:06+00:00</updated>
<author>
<name>Fatih Acet</name>
<email>acetfatih@gmail.com</email>
</author>
<published>2016-07-15T13:37:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=47ca5c369a039e7f5e195fe884a54f86cdde195a'/>
<id>47ca5c369a039e7f5e195fe884a54f86cdde195a</id>
<content type='text'>

navbar_icon was renamed to custom_icon

In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4909 it's still using `navbar_icon` but now it's renamed to `custom_icon` in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5156

/cc @iamphill @smcgivern @annabeldunstone 

See merge request !5265</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

navbar_icon was renamed to custom_icon

In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4909 it's still using `navbar_icon` but now it's renamed to `custom_icon` in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5156

/cc @iamphill @smcgivern @annabeldunstone 

See merge request !5265</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '4424-improve-ui-admin-area' into 'master'</title>
<updated>2016-07-15T12:34:01+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2016-07-15T12:34:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=de204b9565cbe5f614ada9ea4f89c6b3495b7d0a'/>
<id>de204b9565cbe5f614ada9ea4f89c6b3495b7d0a</id>
<content type='text'>

Address UI feedback for admin area

## What does this MR do?
Addresses @dzaporozhets's feedback for !4424

## Why was this MR needed?
!4424 was merged with some design issues which affected other areas of the app and broke consistency. This MR fixes that.

## What are the relevant issue numbers?
#3946 

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5190</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Address UI feedback for admin area

## What does this MR do?
Addresses @dzaporozhets's feedback for !4424

## Why was this MR needed?
!4424 was merged with some design issues which affected other areas of the app and broke consistency. This MR fixes that.

## What are the relevant issue numbers?
#3946 

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5190</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'update-permissions-links' into 'master'</title>
<updated>2016-07-15T09:59:16+00:00</updated>
<author>
<name>Achilleas Pipinellis</name>
<email>axilleas@axilleas.me</email>
</author>
<published>2016-07-15T09:59:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=573f38876ab58e9c77dcd1a5a5e4ce22742f73b6'/>
<id>573f38876ab58e9c77dcd1a5a5e4ce22742f73b6</id>
<content type='text'>

Update permissons links to new page

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5210 updated the location in the docs, but we link to this page a bunch in the app too.

See merge request !5247</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Update permissons links to new page

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5210 updated the location in the docs, but we link to this page a bunch in the app too.

See merge request !5247</pre>
</div>
</content>
</entry>
</feed>
