<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch 56089-merge-gitlab-keys</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix static analysis failure</title>
<updated>2019-03-19T04:06:57+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-18T06:56:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6d097a6c56792fdfb4e89a58b231f86de30289f7'/>
<id>6d097a6c56792fdfb4e89a58b231f86de30289f7</id>
<content type='text'>
No need for a `begin` within a block.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
No need for a `begin` within a block.
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle error for #batch_add_keys</title>
<updated>2019-03-19T04:06:57+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-15T03:14:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cd8eaa96f656ebe24995a2f05486f1a2912b48f4'/>
<id>cd8eaa96f656ebe24995a2f05486f1a2912b48f4</id>
<content type='text'>
Since there are 2 different branches for #branch_add_keys,
we need to handle 2 different errors but ensure that it
returns the same value (true or false).

This way, the consumer of the method can handle whatever
the case is easily. In this case, it's only being used
in `gitlab:shell:setup`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since there are 2 different branches for #branch_add_keys,
we need to handle 2 different errors but ensure that it
returns the same value (true or false).

This way, the consumer of the method can handle whatever
the case is easily. In this case, it's only being used
in `gitlab:shell:setup`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use gitlab-keys if authorized_keys_file is not set</title>
<updated>2019-03-18T05:58:47+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-14T10:05:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f013fa78011501275712f168de832f94e526bba6'/>
<id>f013fa78011501275712f168de832f94e526bba6</id>
<content type='text'>
This is so that if the authorized_keys_file config is
not yet set (e.g. GDK configuration not updated) things
will still work.

Set `authorized_keys_file` to `nil` as default so we don't
assume its default location.

Will be removed in future releases.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is so that if the authorized_keys_file config is
not yet set (e.g. GDK configuration not updated) things
will still work.

Set `authorized_keys_file` to `nil` as default so we don't
assume its default location.

Will be removed in future releases.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename Gitlab::Keys to Gitlab::AuthorizedKeys</title>
<updated>2019-03-18T05:58:47+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-14T04:43:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7e983379c8068224a7f487e9598632c9c65158a0'/>
<id>7e983379c8068224a7f487e9598632c9c65158a0</id>
<content type='text'>
This commit also includes adding documentation for each
public method of the class and changes to the signature
of #batch_add_keys.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit also includes adding documentation for each
public method of the class and changes to the signature
of #batch_add_keys.
</pre>
</div>
</content>
</entry>
<entry>
<title>Renamed auth_file to authorized_keys_file</title>
<updated>2019-03-18T05:58:47+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-14T04:10:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3325cd09cb360e65986143656855ee0690efe9ac'/>
<id>3325cd09cb360e65986143656855ee0690efe9ac</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix gitlab:shell:setup rake task</title>
<updated>2019-03-18T05:58:47+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-13T08:07:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0fd2ff0d584902e2d83217637a3e5953e3768c99'/>
<id>0fd2ff0d584902e2d83217637a3e5953e3768c99</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add back Gitlab::Shell#remove_keys_not_found_in_db</title>
<updated>2019-03-18T05:58:47+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-12T07:50:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6fe15d1cccdd012456cdff089a93df51f1287aa0'/>
<id>6fe15d1cccdd012456cdff089a93df51f1287aa0</id>
<content type='text'>
It's still being used in gitlab-ee
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's still being used in gitlab-ee
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove Gitlab.config.gitlab_shell stub</title>
<updated>2019-03-18T05:58:47+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-11T08:25:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6371b95828607fec8b48b85f8dec912269fc69b0'/>
<id>6371b95828607fec8b48b85f8dec912269fc69b0</id>
<content type='text'>
Set it via gitlab.yml under test environment instead
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Set it via gitlab.yml under test environment instead
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix static analysis failures</title>
<updated>2019-03-18T05:58:47+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-11T08:15:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6b579d6c80a1b81d44ddf68f52525b11499afcf8'/>
<id>6b579d6c80a1b81d44ddf68f52525b11499afcf8</id>
<content type='text'>
- Use File#open instead of Kernel#open
- Add spaces inside hashes
- Remove unneeded disabling of Lint/AssignmentInCondition
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Use File#open instead of Kernel#open
- Add spaces inside hashes
- Remove unneeded disabling of Lint/AssignmentInCondition
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix failure due to #batch_add_keys</title>
<updated>2019-03-18T05:58:47+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-03-08T07:01:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6abd81f1cd8579dd56c07ba62f1223fdc026ae2b'/>
<id>6abd81f1cd8579dd56c07ba62f1223fdc026ae2b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
