<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/.rubocop_todo.yml, branch fix-include-description-commit-message</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'rubocop-todo' into 'master'</title>
<updated>2017-01-19T09:44:15+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzegorz@gitlab.com</email>
</author>
<published>2017-01-17T16:15:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dc646ec003f583466d5beac912656a782a0fbe31'/>
<id>dc646ec003f583466d5beac912656a782a0fbe31</id>
<content type='text'>

Disable all cops in .rubocop_todo.yml

See merge request !8610</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Disable all cops in .rubocop_todo.yml

See merge request !8610</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Rubocop YAML config files to avoid CE-&gt;EE issues</title>
<updated>2017-01-11T09:48:29+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2017-01-11T09:48:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8a75f68ddec788f10b23467d104987726cf40bc8'/>
<id>8a75f68ddec788f10b23467d104987726cf40bc8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update rubocop and rubocop-rspec to fix build errors</title>
<updated>2017-01-06T18:52:18+00:00</updated>
<author>
<name>Brian Neel</name>
<email>brian@gitlab.com</email>
</author>
<published>2017-01-05T22:03:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=23316b4963da5dd0173498904a2cd428ed2b0778'/>
<id>23316b4963da5dd0173498904a2cd428ed2b0778</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update RuboCop to 0.43.0 and update configuration</title>
<updated>2016-10-04T11:28:01+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-10-04T11:28:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=961c53c2ca46e6cfdb2bcaddc0570b1e210302d2'/>
<id>961c53c2ca46e6cfdb2bcaddc0570b1e210302d2</id>
<content type='text'>
`Style/VariableNumber` is explicitly disabled because I don't think we
care if we name a variable `var_1` or `var1`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`Style/VariableNumber` is explicitly disabled because I don't think we
care if we name a variable `var_1` or `var1`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable Lint/StringConversionInInterpolation cop and autocorrect offenses</title>
<updated>2016-10-03T14:09:57+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-10-03T14:09:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4a191c83d1db31aac16241dbf99ac45088efb99a'/>
<id>4a191c83d1db31aac16241dbf99ac45088efb99a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Regenerate .rubocop_todo.yml based on rubocop 0.42.0</title>
<updated>2016-09-14T19:50:11+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-09-14T19:50:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=287293bec1a1e6fc4ffbe84e05ddddf5f48bd8ab'/>
<id>287293bec1a1e6fc4ffbe84e05ddddf5f48bd8ab</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable Style/SpaceAroundEqualsInParameterDefault cop</title>
<updated>2016-08-06T02:03:01+00:00</updated>
<author>
<name>Gabriel Mazetto</name>
<email>gabriel@gitlab.com</email>
</author>
<published>2016-08-06T02:03:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c9aa19881cf719baaea1bbb9bb00f84145a99b8b'/>
<id>c9aa19881cf719baaea1bbb9bb00f84145a99b8b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'rubocop/enable-access-modifiers-cops' into 'master'</title>
<updated>2016-07-29T15:58:09+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-07-29T15:58:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=34c083a184b98372b3b28a661d5cf41e0f2d8259'/>
<id>34c083a184b98372b3b28a661d5cf41e0f2d8259</id>
<content type='text'>

Enable Rubocop cops that check access modifiers

## What does this MR do?

This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.

This also fixes existing offenses.

## Why was this MR needed?

Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.

## What are the relevant issue numbers?

See #17478  
Closes #17372 

See merge request !5014</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Enable Rubocop cops that check access modifiers

## What does this MR do?

This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.

This also fixes existing offenses.

## Why was this MR needed?

Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.

## What are the relevant issue numbers?

See #17478  
Closes #17372 

See merge request !5014</pre>
</div>
</content>
</entry>
<entry>
<title>Enable Style/MultilineTernaryOperator rubocop cop</title>
<updated>2016-07-20T12:24:39+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2016-05-30T12:06:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=07be5943788fe0b672e8c6bea6859582cbdd3d11'/>
<id>07be5943788fe0b672e8c6bea6859582cbdd3d11</id>
<content type='text'>
Avoid multi-line ?: (the ternary operator). Use if/unless instead.

See #17478
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Avoid multi-line ?: (the ternary operator). Use if/unless instead.

See #17478
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable Rubocop cops for invalid access modifiers</title>
<updated>2016-07-19T13:12:15+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2016-07-19T13:07:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d6f669774481b160c2d963b56309ab6262216c42'/>
<id>d6f669774481b160c2d963b56309ab6262216c42</id>
<content type='text'>
This enables following cops:

Check for useless access modifiers

  Lint/UselessAccessModifier

Checks for attempts to use `private` or `protected` to set the
visibility of a class method, which does not work.

  Lint/IneffectiveAccessModifier

This also disables two false possitives in concerns.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This enables following cops:

Check for useless access modifiers

  Lint/UselessAccessModifier

Checks for attempts to use `private` or `protected` to set the
visibility of a class method, which does not work.

  Lint/IneffectiveAccessModifier

This also disables two false possitives in concerns.
</pre>
</div>
</content>
</entry>
</feed>
