From 13019d413647c4fbd3bb1564bbdf0d934c0a74d7 Mon Sep 17 00:00:00 2001 From: Sergey Vlasov Date: Wed, 4 May 2005 21:44:15 +0400 Subject: [PATCH] Fix memory leaks in git-fsck-cache This patch fixes memory leaks in parse_object() and related functions; these leaks were very noticeable when running git-fsck-cache. Signed-off-by: Sergey Vlasov Signed-off-by: Linus Torvalds --- tree.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'tree.c') diff --git a/tree.c b/tree.c index 72305a357b..4a26603f6e 100644 --- a/tree.c +++ b/tree.c @@ -101,9 +101,11 @@ int parse_tree(struct tree *item) if (!buffer) return error("Could not read %s", sha1_to_hex(item->object.sha1)); - if (strcmp(type, tree_type)) + if (strcmp(type, tree_type)) { + free(buffer); return error("Object %s not a tree", sha1_to_hex(item->object.sha1)); + } list_p = &item->entries; while (size) { struct object *obj; @@ -113,8 +115,10 @@ int parse_tree(struct tree *item) char *path = strchr(bufptr, ' '); unsigned int mode; if (size < len + 20 || !path || - sscanf(bufptr, "%o", &mode) != 1) + sscanf(bufptr, "%o", &mode) != 1) { + free(buffer); return -1; + } entry = xmalloc(sizeof(struct tree_entry_list)); entry->name = strdup(path + 1); @@ -138,5 +142,6 @@ int parse_tree(struct tree *item) *list_p = entry; list_p = &entry->next; } + free(buffer); return 0; } -- cgit v1.2.1