From 6d2bf96e550731499c73731e5623017d193f837f Mon Sep 17 00:00:00 2001 From: Clemens Buchacher Date: Sun, 31 May 2009 16:26:48 +0200 Subject: match_refs: search ref list tail internally Avoid code duplication by moving list tail search to match_refs(). This does not change the semantics, except for http-push, which now inserts to the front of the ref list in order to get rid of the global remote_tail. Signed-off-by: Clemens Buchacher Signed-off-by: Junio C Hamano --- transport.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'transport.c') diff --git a/transport.c b/transport.c index efecb65258..2f5786d38b 100644 --- a/transport.c +++ b/transport.c @@ -1003,7 +1003,6 @@ int transport_push(struct transport *transport, if (transport->push_refs) { struct ref *remote_refs = transport->get_refs_list(transport, 1); - struct ref **remote_tail; struct ref *local_refs = get_local_heads(); int match_flags = MATCH_REFS_NONE; int verbose = flags & TRANSPORT_PUSH_VERBOSE; @@ -1014,10 +1013,7 @@ int transport_push(struct transport *transport, if (flags & TRANSPORT_PUSH_MIRROR) match_flags |= MATCH_REFS_MIRROR; - remote_tail = &remote_refs; - while (*remote_tail) - remote_tail = &((*remote_tail)->next); - if (match_refs(local_refs, remote_refs, &remote_tail, + if (match_refs(local_refs, &remote_refs, refspec_nr, refspec, match_flags)) { return -1; } -- cgit v1.2.1