From 4621085b7eb2f4cffe16d508988ff9b4a874b4ef Mon Sep 17 00:00:00 2001 From: Jeff King Date: Tue, 9 Jul 2013 20:18:40 -0400 Subject: add missing "format" function attributes For most of our functions that take printf-like formats, we use gcc's __attribute__((format)) to get compiler warnings when the functions are misused. Let's give a few more functions the same protection. In most cases, the annotations do not uncover any actual bugs; the only code change needed is that we passed a size_t to transfer_debug, which expected an int. Since we expect the passed-in value to be a relatively small buffer size (and cast a similar value to int directly below), we can just cast away the problem. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- trace.c | 1 + 1 file changed, 1 insertion(+) (limited to 'trace.c') diff --git a/trace.c b/trace.c index 5ec0e3bd16..3d744d1d4d 100644 --- a/trace.c +++ b/trace.c @@ -75,6 +75,7 @@ static void trace_vprintf(const char *key, const char *fmt, va_list ap) strbuf_release(&buf); } +__attribute__((format (printf, 2, 3))) static void trace_printf_key(const char *key, const char *fmt, ...) { va_list ap; -- cgit v1.2.1