From 2a73b3dad09ef162eb5917e9e0d01d7c306f6b35 Mon Sep 17 00:00:00 2001 From: Stefan Beller Date: Mon, 29 Feb 2016 13:57:06 -0800 Subject: run-command: do not pass child process data into callbacks The expected way to pass data into the callback is to pass them via the customizable callback pointer. The error reporting in default_{start_failure, task_finished} is not user friendly enough, that we want to encourage using the child data for such purposes. Furthermore the struct child data is cleaned by the run-command API, before we access them in the callbacks, leading to use-after-free situations. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- test-run-command.c | 1 - 1 file changed, 1 deletion(-) (limited to 'test-run-command.c') diff --git a/test-run-command.c b/test-run-command.c index fbe0a27ef3..30a64a98dc 100644 --- a/test-run-command.c +++ b/test-run-command.c @@ -41,7 +41,6 @@ static int no_job(struct child_process *cp, } static int task_finished(int result, - struct child_process *cp, struct strbuf *err, void *pp_cb, void *pp_task_cb) -- cgit v1.2.1