From 449f5c751c22a12de48c273395540a42460795eb Mon Sep 17 00:00:00 2001 From: Eric Sunshine Date: Wed, 31 Jul 2013 04:15:40 -0400 Subject: t4211: retire soon-to-be unimplementable tests 58960978 and 99780b0a added tests which demonstrated bugs (crashes) in range-set and line-log when handed empty ranges specified via "log -LX:file" where X is one greater than the last line of the file. After these tests were added, it was realized that the ability to specify an empty range is a loophole due to a bug in -L bounds checking. That bug is slated to be fixed in a subsequent patch. Unfortunately, the closure of this loophole makes it impossible to continue checking range-set and line-log behavior with regard to empty ranges since there is no other way to specify empty ranges via the command-line. APIs of both facilities are private (file static) so there likewise is no way to test their behaviors programmatically. Consequently, retire these two tests. Signed-off-by: Eric Sunshine Signed-off-by: Junio C Hamano --- t/t4211-line-log.sh | 13 ------------- 1 file changed, 13 deletions(-) (limited to 't/t4211-line-log.sh') diff --git a/t/t4211-line-log.sh b/t/t4211-line-log.sh index f98275c37c..769ac686c3 100755 --- a/t/t4211-line-log.sh +++ b/t/t4211-line-log.sh @@ -94,17 +94,4 @@ test_expect_success '-L ,Y (Y == nlines + 2)' ' test_must_fail git log -L ,$n:b.c ' -# There is a separate bug when an empty -L range is the first -L encountered, -# thus to demonstrate this particular bug, the empty -L range must follow a -# non-empty -L range. -test_expect_success '-L {empty-range} (any -L)' ' - n=$(expr $(wc -l