From 101dd4de16eea300a59e432452fd4fc06e1ac7f2 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 19 May 2017 08:55:11 -0400 Subject: handle_revision_arg: record modes for "a..b" endpoints The "a..b" revision syntax was designed to handle commits, so it doesn't bother to record any mode we find while traversing a "tree:path" endpoint. These days "git diff" can diff blobs using either "a:path..b:path" (with dots) or "a:path b:path" (without), but the two behave inconsistently, as the with-dots version fails to notice the mode. Let's teach the dot-dot range parser to record modes; it doesn't cost us anything, and it makes this case work. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- t/t4063-diff-blobs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 't/t4063-diff-blobs.sh') diff --git a/t/t4063-diff-blobs.sh b/t/t4063-diff-blobs.sh index 90c6f6b85b..df9c35b2dd 100755 --- a/t/t4063-diff-blobs.sh +++ b/t/t4063-diff-blobs.sh @@ -71,7 +71,7 @@ test_expect_success 'index of ranged tree:path diff' ' test_expect_failure 'ranged tree:path diff uses filenames as paths' ' check_paths one two ' -test_expect_failure 'ranged tree:path diff shows mode change' ' +test_expect_success 'ranged tree:path diff shows mode change' ' check_mode 100644 100755 ' -- cgit v1.2.1