From f93d7c6fa0548e95ca2795d900671a87c1a88ea3 Mon Sep 17 00:00:00 2001 From: Tanay Abhra Date: Fri, 18 Jul 2014 02:19:00 -0700 Subject: replace memset with string-list initializers Using memset and then manually setting values of the string-list members is not future proof as the internal representation of string-list may change any time. Use `string_list_init()` or STRING_LIST_INIT_* macros instead of memset. Signed-off-by: Tanay Abhra Reviewed-by: Matthieu Moy Signed-off-by: Junio C Hamano --- submodule.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'submodule.c') diff --git a/submodule.c b/submodule.c index b80ecacf60..2fe2ad8ee4 100644 --- a/submodule.c +++ b/submodule.c @@ -544,10 +544,7 @@ static int push_submodule(const char *path) int push_unpushed_submodules(unsigned char new_sha1[20], const char *remotes_name) { int i, ret = 1; - struct string_list needs_pushing; - - memset(&needs_pushing, 0, sizeof(struct string_list)); - needs_pushing.strdup_strings = 1; + struct string_list needs_pushing = STRING_LIST_INIT_DUP; if (!find_unpushed_submodules(new_sha1, remotes_name, &needs_pushing)) return 1; -- cgit v1.2.1