From d3ba566342a4fd81b24d926efc35506d58e10a19 Mon Sep 17 00:00:00 2001 From: Christian Couder Date: Wed, 16 Aug 2017 14:40:36 +0200 Subject: sub-process: print the cmd when a capability is unsupported In handshake_capabilities() we use warning() when a capability is not supported, so the exit code of the function is 0 and no further error is shown. This is a problem because the warning message doesn't tell us which subprocess cmd failed. On the contrary if we cannot write a packet from this function, we use error() and then subprocess_start() outputs: initialization for subprocess '' failed so we can know which subprocess cmd failed. Let's improve the warning() message, so that we can know which subprocess cmd failed. Helped-by: Lars Schneider Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- sub-process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sub-process.c') diff --git a/sub-process.c b/sub-process.c index 86de8d7bfb..fcc4832c14 100644 --- a/sub-process.c +++ b/sub-process.c @@ -181,8 +181,8 @@ static int handshake_capabilities(struct child_process *process, if (supported_capabilities) *supported_capabilities |= capabilities[i].flag; } else { - warning("external filter requested unsupported filter capability '%s'", - p); + warning("subprocess '%s' requested unsupported capability '%s'", + process->argv[0], p); } } -- cgit v1.2.1