From 2c68f577fc8a400f4d354f4700e4809c1bfd6470 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 7 Dec 2021 18:38:10 +0000 Subject: cbtree: remove broken and unused cb_unlink cb_unlink is broken once a node is no longer self-referential due to subsequent insertions. This is a consequence of an intrusive implementation and I'm not sure if it's easily fixable while retaining our cache-friendly intrusive property (I've tried for several hours in another project). In any case, we're not using cb_unlink anywhere in our codebase, just get rid of it to avoid misleading future readers. Signed-off-by: Eric Wong Signed-off-by: Junio C Hamano --- cbtree.h | 1 - 1 file changed, 1 deletion(-) (limited to 'cbtree.h') diff --git a/cbtree.h b/cbtree.h index dedbb8e2a4..0be14fb7ee 100644 --- a/cbtree.h +++ b/cbtree.h @@ -47,7 +47,6 @@ static inline void cb_init(struct cb_tree *t) struct cb_node *cb_lookup(struct cb_tree *, const uint8_t *k, size_t klen); struct cb_node *cb_insert(struct cb_tree *, struct cb_node *, size_t klen); -struct cb_node *cb_unlink(struct cb_tree *t, const uint8_t *k, size_t klen); typedef enum cb_next (*cb_iter)(struct cb_node *, void *arg); -- cgit v1.2.1