From 28b3563241ac13733781fb0bada37f776a39f43d Mon Sep 17 00:00:00 2001 From: Jeff King Date: Thu, 24 Jul 2014 00:41:11 -0400 Subject: free ref string returned by dwim_ref A call to "dwim_ref(name, len, flags, &ref)" will allocate a new string in "ref" to return the exact ref we found. We do not consistently free it in all code paths, leading to small leaks. The worst is in get_sha1_basic, which may be called many times (e.g., by "cat-file --batch"), though it is relatively unlikely, as it only triggers on a bogus reflog specification. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- builtin/show-branch.c | 1 + 1 file changed, 1 insertion(+) (limited to 'builtin/show-branch.c') diff --git a/builtin/show-branch.c b/builtin/show-branch.c index d87317290c..b29309019b 100644 --- a/builtin/show-branch.c +++ b/builtin/show-branch.c @@ -779,6 +779,7 @@ int cmd_show_branch(int ac, const char **av, const char *prefix) sprintf(nth_desc, "%s@{%d}", *av, base+i); append_ref(nth_desc, sha1, 1); } + free(ref); } else if (all_heads + all_remotes) snarf_refs(all_heads, all_remotes); -- cgit v1.2.1