From 249c61a62d82c22df98cb72ec61c120887b944e1 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Mon, 9 Jun 2008 22:23:16 +0100 Subject: merge-recursive: respect core.autocrlf when writing out the result The code forgot to convert the blob contents into work tree representation before writing it out. Also fixes leaks -- earlier the updated blobs were never freed. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- builtin-merge-recursive.c | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'builtin-merge-recursive.c') diff --git a/builtin-merge-recursive.c b/builtin-merge-recursive.c index 910c0d20e7..175e8b1660 100644 --- a/builtin-merge-recursive.c +++ b/builtin-merge-recursive.c @@ -551,9 +551,19 @@ static void update_file_flags(const unsigned char *sha, die("cannot read object %s '%s'", sha1_to_hex(sha), path); if (type != OBJ_BLOB) die("blob expected for %s '%s'", sha1_to_hex(sha), path); + if (S_ISREG(mode)) { + struct strbuf strbuf; + strbuf_init(&strbuf, 0); + if (convert_to_working_tree(path, buf, size, &strbuf)) { + free(buf); + size = strbuf.len; + buf = strbuf_detach(&strbuf, NULL); + } + } if (make_room_for_path(path) < 0) { update_wd = 0; + free(buf); goto update_index; } if (S_ISREG(mode) || (!has_symlinks && S_ISLNK(mode))) { @@ -576,6 +586,7 @@ static void update_file_flags(const unsigned char *sha, } else die("do not know what to do with %06o %s '%s'", mode, sha1_to_hex(sha), path); + free(buf); } update_index: if (update_cache) -- cgit v1.2.1