delta/git.git/t/lib-git-p4.sh, branch sb/string-list-split-appends

git-p4 tests: time_in_seconds should use $PYTHON_PATH

2016-04-26T17:48:32+00:00

The time_in_seconds script should use $PYTHON_PATH, rather than
just hard-coded python, so that users can override which version
gets used, as is done for other python invocations.

Signed-off-by: Luke Diamand 
Signed-off-by: Junio C Hamano

git-p4 tests: work with python3 as well as python2

2016-04-26T17:48:13+00:00

Update the git-p4 tests so that they work with both
Python2 and Python3.

We have to be explicit about the difference between
Unicode text strings (Python3 default) and raw binary
strings which will be exchanged with Perforce.

Additionally, print always takes parentheses in Python3.

Signed-off-by: Luke Diamand 
Signed-off-by: Junio C Hamano

git-p4 tests: cd to / before running python

2016-04-26T17:47:02+00:00

The python one-liner for getting the current time prints out
error messages if the current directory is deleted while it is
running if using python3.

Avoid these messages by switching to "/" before running it.

This problem does not arise if using python2.

Signed-off-by: Luke Diamand 
Signed-off-by: Junio C Hamano

git-p4: add trap to kill p4d on test exit

2015-11-20T13:02:06+00:00

Sometimes the "prove" test runner hangs on test exit because p4d is
still running. Add a trap to always kill "p4d" on test exit.

You can reproduce the problem by commenting "P4D_TIMEOUT" in
"lib-git-p4.sh" and running "prove ./t9800-git-p4-basic.sh".

Signed-off-by: Lars Schneider 
Signed-off-by: Jeff King

git-p4: add p4d timeout in tests

2015-11-20T13:02:06+00:00

In rare cases p4d seems to hang. This watchdog will kill the p4d
process after 300s in any case. That means each individual git p4 test
needs to finish before 300s or it will fail.

Signed-off-by: Lars Schneider 
Acked-by: Luke Diamand 
Signed-off-by: Jeff King

git-p4: retry kill/cleanup operations in tests with timeout

2015-11-20T13:02:06+00:00

In rare cases kill/cleanup operations in tests fail. Retry these
operations with a timeout to make the test less flaky.

Signed-off-by: Lars Schneider 
Signed-off-by: Jeff King

git-p4: add failing tests for case-folding p4d

2015-04-28T19:19:43+00:00

When p4d runs on a case-folding OS, git-p4 can end up getting
very confused. This adds failing tests to demonstrate the problem.

Signed-off-by: Luke Diamand 
Signed-off-by: Junio C Hamano

git p4 test: do not pollute /tmp

2014-01-22T16:06:19+00:00

Generating the submit template for p4 uses tempfile.mkstemp(),
which by default puts files in /tmp.  For a test that fails,
possibly on purpose, this is not cleaned up.  Run with TMPDIR
pointing into the trash directory so the temp files go away
with the test results.

To do this required some other minor changes.  First, the editor
is launched using system(editor + " " + template_file), using
shell expansion to build the command string.  This doesn't work
if editor has a space in it.  And is generally unwise as it's
easy to fool the shell into doing extra work.  Exec the args
directly, without shell expansion.

Second, without shell expansion, the trick of "P4EDITOR=:" used
in the tests doesn't work.  Use a real command, true, as the
non-interactive editor for testing.

Signed-off-by: Pete Wyckoff 
Signed-off-by: Junio C Hamano

git p4 test: run as user "author"

2014-01-22T16:05:27+00:00

The tests use author@example.com as the canonical submitter,
but he does not have an entry in the p4 users database.
This causes the generated change description to complain
that the git and p4 users disagree.  The complaint message
is still valid, but isn't useful in tests.  It was introduced
in 848de9c (git-p4: warn if git authorship won't be retained,
2011-05-13).

Fix t9813 to use @example.com instead of @localhost due to
change in p4_add_user().  Move the function into the git p4
test library so author can be added at initialization time.

Signed-off-by: Pete Wyckoff 
Signed-off-by: Junio C Hamano

git p4 test: sanitize P4CHARSET

2013-08-12T06:19:08+00:00

In the tests, p4d is started without using "internationalized
mode".  Make sure this environment variable is unset, otherwise
a mis-matched user setting would break the tests.  The error
message would be "Unicode clients require a unicode enabled server."

[pw: use unset, add commit text]

Signed-off-by: Kazuki Saitoh 
Signed-off-by: Pete Wyckoff 
Signed-off-by: Junio C Hamano