delta/git.git/promisor-remote.h, branch jch

promisor-remote: remove a return value

2022-10-05T18:06:52+00:00

No caller of promisor_remote_get_direct() is checking its return value,
so remove it.

Not checking the return value means that the user would not know
whether the failure of reading an object is due to the promisor remote
not supplying the object or because of local repository corruption, but
this will be fixed in a subsequent patch.

Signed-off-by: Jonathan Tan 
Signed-off-by: Junio C Hamano

promisor-remote: support per-repository config

2021-06-28T16:57:42+00:00

Instead of using global variables to store promisor remote information,
store this config in struct repository instead, and add
repository-agnostic non-static functions corresponding to the existing
non-static functions that only work on the_repository.

The actual lazy-fetching of missing objects currently does not work on
repositories other than the_repository, and will still not work after
this commit, so add a BUG message explaining this. A subsequent commit
will remove this limitation.

Signed-off-by: Jonathan Tan 
Signed-off-by: Junio C Hamano 
Reviewed-by: Elijah Newren 
Signed-off-by: Junio C Hamano

repository: move global r_f_p_c to repo struct

2021-06-28T16:57:41+00:00

Move repository_format_partial_clone, which is currently a global
variable, into struct repository. (Full support for per-repository
partial clone config will be done in a subsequent commit - this is split
into its own commit because of the extent of the changes needed.)

The new repo-specific variable cannot be set in
check_repository_format_gently() (as is currently), because that
function does not know which repo it is operating on (or even whether
the value is important); therefore this responsibility is delegated to
the outermost caller that knows. Of all the outermost callers that know
(found by looking at all functions that call clear_repository_format()),
I looked at those that either read from the main Git directory or write
into a struct repository. These callers have been modified accordingly
(write to the_repository in the former case and write to the given
struct repository in the latter case).

Signed-off-by: Jonathan Tan 
Signed-off-by: Junio C Hamano 
Reviewed-by: Elijah Newren 
Signed-off-by: Junio C Hamano

promisor-remote: remove unused variable

2020-09-22T05:32:49+00:00

The variable core_partial_clone_filter_default has been unused since
fa3d1b63e8 ("promisor-remote: parse remote.*.partialclonefilter",
2019-06-25), when Git was changed to refer to
remote.*.partialclonefilter as the default filter when fetching in a
partial clone, but (perhaps inadvertently) there was no fallback to
core.partialclonefilter.

One alternative is to add the fallback, but the aforementioned change
was made more than a year ago and I have not heard of any complaints
regarding this matter. In addition, there is currently no mention of
core.partialclonefilter in the user documentation. So it seems best to
reaffirm that Git will only support remote.*.partialclonefilter.

Signed-off-by: Jonathan Tan 
Signed-off-by: Junio C Hamano

promisor-remote: accept 0 as oid_nr in function

2020-04-02T19:42:32+00:00

There are 3 callers to promisor_remote_get_direct() that first check if
the number of objects to be fetched is equal to 0. Fold that check into
promisor_remote_get_direct(), and in doing so, be explicit as to what
promisor_remote_get_direct() does if oid_nr is 0 (it returns 0, success,
immediately).

Signed-off-by: Jonathan Tan 
Signed-off-by: Junio C Hamano

Merge branch 'dl/honor-cflags-in-hdr-check'

2019-10-07T02:33:02+00:00

Dev support.

* dl/honor-cflags-in-hdr-check:
  ci: run `hdr-check` as part of the `Static Analysis` job
  Makefile: emulate compile in $(HCO) target better
  pack-bitmap.h: remove magic number
  promisor-remote.h: include missing header
  apply.h: include missing header

promisor-remote.h: include missing header

2019-09-28T05:04:19+00:00

When we ran `make hdr-check`, we got the following warning message:

	promisor-remote.h:21:46: warning: declaration of 'struct repository' will not be visible outside of this function [-Wvisibility]
	extern int promisor_remote_get_direct(struct repository *repo,
						     ^
	1 warning generated.

This was caused by a missing reference to `struct repository`, which is
defined in "repository.h".

Include this missing header to fix this warning.

Signed-off-by: Denton Liu 
Signed-off-by: Junio C Hamano

promisor-remote.h: drop extern from function declaration

2019-09-28T04:03:08+00:00

During the creation of this file, each time a new function declaration
was introduced, it included an `extern`. However, starting from
554544276a (*.[ch]: remove extern from function declarations using
spatch, 2019-04-29), we've been actively trying to prevent externs from
being used in function declarations because they're unnecessary.

Remove these spurious `extern`s.

Signed-off-by: Denton Liu 
Signed-off-by: Junio C Hamano

Move repository_format_partial_clone to promisor-remote.c

2019-06-25T21:05:38+00:00

Now that we have has_promisor_remote() and can use many
promisor remotes, let's hide repository_format_partial_clone
as a static in promisor-remote.c to avoid it being use
for anything other than managing backward compatibility.

Signed-off-by: Christian Couder 
Signed-off-by: Junio C Hamano

promisor-remote: parse remote.*.partialclonefilter

2019-06-25T21:05:37+00:00

This makes it possible to specify a different partial clone
filter for each promisor remote.

Signed-off-by: Christian Couder 
Signed-off-by: Junio C Hamano