delta/git.git/mailinfo.c, branch ce/https-public-key-pinning

mailinfo: fix passing wrong address to git_mailinfo_config

2015-11-01T18:29:40+00:00

git_mailinfo_config() expects "struct mailinfo *". But in
setup_mailinfo(), "mi" is already "struct mailinfo *". &mi would make
it "struct mailinfo **" and git_mailinfo_config() would damage some
other memory when it assigns some value to mi->use_scissors.

This is caught by t4150.20. git_mailinfo_config() breaks
mi->name.alloc and makes strbuf_release() in clear_mailinfo() attempt
to free strbuf_slopbuf.

Signed-off-by: Nguyễn Thái Ngọc Duy 
Signed-off-by: Junio C Hamano

mailinfo: remove calls to exit() and die() deep in the callchain

2015-10-21T22:59:34+00:00

The top-level mailinfo() would instead punt when the code in the
deeper part of the callchain detects an unrecoverable error in the
input.

Signed-off-by: Junio C Hamano

mailinfo: handle charset conversion errors in the caller

2015-10-21T22:59:34+00:00

Instead of dying in convert_to_utf8(), just report an error and let
the callers handle it.  Between the two callers:

 - decode_header() silently punts when it cannot parse a broken
   RFC2047 encoded text (e.g. when it sees anything other than B or
   Q after it sees "=?") by jumping to release_return,
   returning the string it successfully parsed out so far, to the
   caller.  A piece of string that convert_to_utf8() cannot handle
   can be treated the same way.

 - handle_commit_msg() doesn't cope with a malformed line well, so
   die there for now.  We'll lift this even higher in later changes
   in this series.

Signed-off-by: Junio C Hamano

mailinfo: libify

2015-10-21T22:59:34+00:00

Move the bulk of the code from builtin/mailinfo.c to mailinfo.c
so that new callers can start calling mailinfo() directly.

Note that a few calls to exit() and die() need to be cleaned up
for the API to be truly useful, which will come in later steps.

Signed-off-by: Junio C Hamano

Make git-mailinfo a builtin

2006-06-19T05:10:28+00:00

[jc: with a bit of constness tightening]

Signed-off-by: Lukas Sandström 
Signed-off-by: Junio C Hamano

mailinfo: ignore blanks after in-body headers.

2006-06-18T00:05:36+00:00

[jc: this is based on Eric's patch but also fixes up the parsed
 subject headers].

Signed-off-by: Junio C Hamano

Don't parse any headers in the real body of an email message.

2006-06-17T23:27:12+00:00

It was pointed out that the current behaviour might mispart a patch comment
so remove this behaviour for now.

[jc: this fixes "From: line in the middle" check in t5100 test.]

Signed-off-by: Eric W. Biederman 
Signed-off-by: Junio C Hamano

Merge branch 'jc/mailinfo'

2006-05-28T20:39:05+00:00

* jc/mailinfo:
  mailinfo: skip bogus UNIX From line inside body

mailinfo: More carefully parse header lines in read_one_header_line()

2006-05-26T07:49:36+00:00

We exited prematurely from header parsing loop when the header
field did not have a space after the colon but we insisted on
it, and we got the check wrong because we forgot that we strip
the trailing whitespace before we do the check.

The space after the colon is not even required by RFC2822, so
stop requiring it.  While we are at it, the header line is
specified to be more strict than "anything with a colon in it"
(there must be one or more characters before the colon, and they
must not be controls, SP or non US-ASCII), so implement that
check as well, lest we mistakenly think something like:

	Bogus not a header line: this is not.

as a header line.

Signed-off-by: Junio C Hamano

Allow in body headers beyond the in body header prefix.

2006-05-23T21:11:03+00:00

- handle_from is fixed to not mangle it's input line.

- Then handle_inbody_header is allowed to look in
  the body of a commit message for additional headers
  that we haven't already seen.

This allows patches with all of the right information in
unfortunate places to be imported.

Signed-off-by: Eric W. Biederman 
Signed-off-by: Junio C Hamano