delta/git.git/ewah, branch ks/prepare-commit-msg-sample

Merge branch 'jk/ewah-use-right-type-in-sizeof'

2017-03-13T06:21:35+00:00

Code clean-up.

* jk/ewah-use-right-type-in-sizeof:
  ewah: fix eword_t/uint64_t confusion

ewah: fix eword_t/uint64_t confusion

2017-03-06T20:03:40+00:00

The ewah subsystem typedefs eword_t to be uint64_t, but some
code uses a bare uint64_t. This isn't a bug now, but it's a
potential maintenance problem if the definition of eword_t
ever changes. Let's use the correct type.

Note that we can't use COPY_ARRAY() here because the source
and destination point to objects of different sizes. For
that reason we'll also skip the usual "sizeof(*dst)" and use
the real type, which should make it more clear that there's
something tricky going on.

Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano

ewah: convert to REALLOC_ARRAY, etc

2016-02-22T22:51:09+00:00

Now that we're built around xmalloc and friends, we can use
helpers like REALLOC_ARRAY, ALLOC_GROW, and so on to make
the code shorter and protect against integer overflow.

Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano

convert ewah/bitmap code to use xmalloc

2016-02-22T22:51:09+00:00

This code was originally written with the idea that it could
be spun off into its own ewah library, and uses the
overrideable ewah_malloc to do allocations.

We plug in xmalloc as our ewah_malloc, of course. But over
the years the ewah code itself has become more entangled
with git, and the return value of many ewah_malloc sites is
not checked.

Let's just drop the level of indirection and use xmalloc and
friends directly. This saves a few lines, and will let us
adapt these sites to our more advanced malloc helpers.

Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano

Merge branch 'es/osx-header-pollutes-mask-macro'

2015-06-24T19:21:44+00:00

* es/osx-header-pollutes-mask-macro:
  ewah: use less generic macro name
  ewah/bitmap: silence warning about MASK macro redefinition

ewah: use less generic macro name

2015-06-03T07:04:01+00:00

The ewah/ewok.h header pollutes the global namespace with
"BITS_IN_WORD", without any specific notion that we are
talking about the bits in an eword_t. We can give this the
more specific name "BITS_IN_EWORD".

Signed-off-by: Jeff King 
Reviewed-by: Eric Sunshine 
Signed-off-by: Junio C Hamano

ewah/bitmap: silence warning about MASK macro redefinition

2015-06-03T07:03:03+00:00

On PowerPC Mac OS X (10.5.8 "Leopard" with Xcode 3.1),
system header /usr/include/ppc/param.h[1] pollutes the
preprocessor namespace with a macro generically named MASK.
This conflicts with the same-named macro in ewah/bitmap.c.
We can avoid this conflict by using a more specific name.

[1]: Included indirectly via:
     git-compat-util.h ->
     sys/sysctl.h ->
     sys/ucred.h ->
     sys/param.h ->
     machine/param.h ->
     ppc/param.h

Signed-off-by: Eric Sunshine 
Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano

ewah: add convenient wrapper ewah_serialize_strbuf()

2015-03-12T20:45:16+00:00

Signed-off-by: Nguyễn Thái Ngọc Duy 
Signed-off-by: Junio C Hamano

Merge branch 'jk/pack-bitmap'

2015-02-18T19:45:00+00:00

The pack bitmap support did not build with older versions of GCC.

* jk/pack-bitmap:
  ewah: fix building with gcc < 3.4.0

ewah: fix building with gcc < 3.4.0

2015-02-04T18:45:31+00:00

The __builtin_ctzll function was added in gcc 3.4.0.
This extends the check for gcc so that use of __builtin_ctzll is only
enabled if gcc >= 3.4.0.

Signed-off-by: Tom G. Christensen 
Reviewed-by: Jeff King 
Signed-off-by: Junio C Hamano