delta/git.git/builtin/remote.c, branch ce/https-public-key-pinning

ref_newer: convert to use struct object_id

2015-11-20T13:02:05+00:00

Convert ref_newer and its caller to use struct object_id instead of
unsigned char *.

Signed-off-by: brian m. carlson 
Signed-off-by: Jeff King

Convert struct ref to use object_id.

2015-11-20T13:02:05+00:00

Use struct object_id in three fields in struct ref and convert all the
necessary places that use it.

Signed-off-by: brian m. carlson 
Signed-off-by: Jeff King

Merge branch 'bb/remote-get-url'

2015-10-05T19:30:25+00:00

"git remote" learned "get-url" subcommand to show the URL for a
given remote name used for fetching and pushing.

* bb/remote-get-url:
  remote: add get-url subcommand

remote: add get-url subcommand

2015-09-17T19:19:57+00:00

Expanding `insteadOf` is a part of ls-remote --url and there is no way
to expand `pushInsteadOf` as well. Add a get-url subcommand to be able
to query both as well as a way to get all configured urls.

Signed-off-by: Ben Boeckel 
Signed-off-by: Junio C Hamano

remote.c: drop extraneous local variable from migrate_file

2015-08-10T22:37:12+00:00

It's an anti-pattern to assign the result of git_path to a
variable, since other calls may reuse our buffer. In this
case, we feed the result to unlink_or_warn immediately
afterwards, so it's OK. However, it's nice to avoid
assignment entirely, which makes it more obvious that
there's no bug.

We can just pass the result directly to unlink_or_warn,
which is a known-simple function. As a bonus, the code flow
is a little more obvious, as we eliminate an extra
conditional (a reader does not have to wonder any more
"under which circumstances is 'path' set?").

Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano

prune_remote(): use delete_refs()

2015-06-22T20:17:10+00:00

This slightly changes how errors are reported. The old and new code
both report errors that come from repack_without_refs() the same way.
But if an error occurs within delete_ref(), the old version only
emitted an error within delete_ref() without further comment. The new
version (in delete_refs()) still emits that error, but then follows it
up with

    error(_("could not remove reference %s"), refname)

The "could not remove reference" error originally came from a similar
message in remove_branches() (from builtin/remote.c).

This is an improvement, because the error from delete_ref() (which
usually comes from ref_transaction_commit()) can be pretty low-level,
like

    Cannot lock ref '%s': unable to resolve reference %s: %s

where the last "%s" is the original strerror.

In any case, I don't think we need to sweat the details too much,
because these errors should only ever be seen in the case of a broken
repository or a race between two processes; i.e., only in pretty rare
and anomalous situations.

Signed-off-by: Michael Haggerty 
Signed-off-by: Junio C Hamano

delete_refs(): new function for the refs API

2015-06-22T20:17:09+00:00

Move the function remove_branches() from builtin/remote.c to refs.c,
rename it to delete_refs(), and make it public.

Signed-off-by: Michael Haggerty 
Signed-off-by: Junio C Hamano

remove_branches(): remove temporary

2015-06-22T20:17:08+00:00

Signed-off-by: Michael Haggerty 
Signed-off-by: Junio C Hamano

builtin/remote: rewrite functions to take object_id arguments

2015-05-25T19:19:30+00:00

Signed-off-by: Michael Haggerty 
Signed-off-by: brian m. carlson 
Signed-off-by: Junio C Hamano

add_branch_for_removal(): don't set "util" field of string_list entries

2015-05-25T19:19:30+00:00

They were never used.

Signed-off-by: Michael Haggerty 
Signed-off-by: brian m. carlson 
Signed-off-by: Junio C Hamano