delta/git.git/builtin/mailinfo.c, branch sb/string-list-split-appends

mailinfo: libify

2015-10-21T22:59:34+00:00

Move the bulk of the code from builtin/mailinfo.c to mailinfo.c
so that new callers can start calling mailinfo() directly.

Note that a few calls to exit() and die() need to be cleaned up
for the API to be truly useful, which will come in later steps.

Signed-off-by: Junio C Hamano

mailinfo: keep the parsed log message in a strbuf

2015-10-21T22:57:17+00:00

When mailinfo() is eventually libified, the calling "git am" still
will have to write out the log message in the "msg" file for hooks
and other users of the information, but it does not have to reopen
and reread what it wrote earlier if the function kept it in a strbuf.

This also removes the need for seeking and truncating the output
file when we see a scissors mark in the input, which in turn allows
us to lose two callsites of die_errno().

Signed-off-by: Junio C Hamano

mailinfo: handle_commit_msg() shouldn't be called after finding patchbreak

2015-10-21T22:57:17+00:00

There is a strange "if (!mi->cmitmsg) return 0" at the very beginning
of handle_commit_msg(), but the condition should never trigger, because:

 * The only place cmitmsg is set to NULL is after this function sees
   a patch break, closes the FILE * to write the commit log message
   and returns 1.  This function returns non-zero only from that
   codepath.

 * The caller of this function, upon seeing a non-zero return,
   increments filter_stage, starts treating the input as patch text
   and will never call handle_commit_msg() again.

Replace it with an assert(!mi->filter_stage) to ensure the above
observation will stay to be true.

Signed-off-by: Junio C Hamano

mailinfo: move content/content_top to struct mailinfo

2015-10-21T22:57:17+00:00

Signed-off-by: Junio C Hamano

mailinfo: move [ps]_hdr_data to struct mailinfo

2015-10-21T22:56:17+00:00

Signed-off-by: Junio C Hamano

mailinfo: move cmitmsg and patchfile to struct mailinfo

2015-10-21T22:55:01+00:00

Signed-off-by: Junio C Hamano

mailinfo: move charset to struct mailinfo

2015-10-21T22:55:01+00:00

Signed-off-by: Junio C Hamano

mailinfo: move transfer_encoding to struct mailinfo

2015-10-21T22:53:25+00:00

Signed-off-by: Junio C Hamano

mailinfo: move check for metainfo_charset to convert_to_utf8()

2015-10-21T22:50:17+00:00

All callers of this function refrain from calling it when
mi->metainfo_charset is NULL; move the check to the callee,
as it already has a few conditions at its beginning to turn
it into a no-op.

Signed-off-by: Junio C Hamano

mailinfo: move metainfo_charset to struct mailinfo

2015-10-21T22:50:17+00:00

This requires us to pass the struct down to decode_header() and
convert_to_utf8() callchain.

Signed-off-by: Junio C Hamano