delta/git.git/bisect.c, branch fc/mergetools-vimdiff3

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05T22:13:21+00:00

Leaving only the function definitions and declarations so that any
new topic in flight can still make use of the old functions, replace
existing uses of the prefixcmp() and suffixcmp() with new API
functions.

The change can be recreated by mechanically applying this:

    $ git grep -l -e prefixcmp -e suffixcmp -- \*.c |
      grep -v strbuf\\.c |
      xargs perl -pi -e '
        s|!prefixcmp\(|starts_with\(|g;
        s|prefixcmp\(|!starts_with\(|g;
        s|!suffixcmp\(|ends_with\(|g;
        s|suffixcmp\(|!ends_with\(|g;
      '

on the result of preparatory changes in this series.

Signed-off-by: Christian Couder 
Signed-off-by: Junio C Hamano

list-objects: reduce one argument in mark_edges_uninteresting

2013-08-28T18:54:18+00:00

mark_edges_uninteresting() is always called with this form

  mark_edges_uninteresting(revs->commits, revs, ...);

Remove the first argument and let mark_edges_uninteresting figure that
out by itself. It helps answer the question "are this commit list and
revs related in any way?" when looking at mark_edges_uninteresting
implementation.

Signed-off-by: Nguyễn Thái Ngọc Duy 
Signed-off-by: Junio C Hamano

register_ref(): make a copy of the bad reference SHA-1

2013-06-02T22:28:47+00:00

The lifetime of the sha1 parameter passed to an each_ref_fn callback
is not guaranteed, so make a copy for later use.

Signed-off-by: Michael Haggerty 
Signed-off-by: Junio C Hamano

Merge branch 'jk/bisect-prn-unsigned'

2013-04-07T21:32:54+00:00

* jk/bisect-prn-unsigned:
  bisect: avoid signed integer overflow

bisect: avoid signed integer overflow

2013-04-03T19:49:14+00:00

Signed-off-by: John Keeping 
Signed-off-by: Junio C Hamano

Move estimate_bisect_steps to libgit.a

2012-10-29T07:08:30+00:00

This function is used by bisect.c, part of libgit.a while
estimate_bisect_steps stays in builtin/rev-list.c. Move it to bisect.a
so we won't have undefine reference if a standalone program that uses
libgit.a happens to pull it in.

Signed-off-by: Nguyễn Thái Ngọc Duy 
Signed-off-by: Jeff King

Call git_pathdup() rather than xstrdup(git_path("..."))

2012-09-04T20:34:46+00:00

In addition to updating the two xstrdup(git_path("...")) call sites
with git_pathdup(), we also fix a memory leak by freeing the memory
allocated to the ADD_EDIT.patch 'file' in the edit_patch() function.

Signed-off-by: Ramsay Jones 
Signed-off-by: Junio C Hamano

bisect: copy filename string obtained from git_path()

2012-05-03T20:15:35+00:00

Prevent the string from being overwritten by other callers of
git_path() and friends before we are done using it.

Signed-off-by: Michael Haggerty 
Signed-off-by: Junio C Hamano

Merge branch 'rs/pending'

2011-10-14T02:03:22+00:00

* rs/pending:
  commit: factor out clear_commit_marks_for_object_array
  checkout: use leak_pending flag
  bundle: use leak_pending flag
  bisect: use leak_pending flag
  revision: add leak_pending flag
  checkout: use add_pending_{object,sha1} in orphan check
  revision: factor out add_pending_sha1
  checkout: check for "Previous HEAD" notice in t2020

Conflicts:
	builtin/checkout.c
	revision.c

Merge branch 'jk/argv-array'

2011-10-05T19:36:24+00:00

* jk/argv-array:
  run_hook: use argv_array API
  checkout: use argv_array API
  bisect: use argv_array API
  quote: provide sq_dequote_to_argv_array
  refactor argv_array into generic code
  quote.h: fix bogus comment
  add sha1_array API docs